Fixup for v3.7
Subsystems (3)
PATCH 1/1 Fixup for v3.7
Olof: Could you apply this patch by hand? Fixes a compile-time error in v3.7 which prevents building vt8500 since gpio.h was removed as part of the multiplatform update.
Tony Prisk (1):
arm: vt8500: Fixup for missing gpio.h
arch/arm/mach-vt8500/vt8500.c | 1 - 1 file changed, 1 deletion(-)
Signature · 1 line
1.7.9.5
PATCH 1/1 arm: vt8500: Fixup for missing gpio.h
mach/include/gpio.h was removed as part of the multiplatform-3.7 update. This patch removes the include from arch-vt8500/vt8500.c
--- arch/arm/mach-vt8500/vt8500.c | 1 - 1 file changed, 1 deletion(-)
arch/arm/mach-vt8500/vt8500.c +0 -1
@@ -32,7 +32,6 @@#include <linux/of_platform.h> #include <mach/restart.h> -#include <mach/gpio.h> #include "common.h"
Signature · 1 line
1.7.9.5
PATCH 1/1 arm: vt8500: Fixup for missing gpio.h
Quoted 13 lines · Tony Prisk
mach/include/gpio.hwas removed as part of the multiplatform-3.7 update. This patch removes the include fromarch-vt8500/vt8500.cSigned-off-by Tony Prisk <[email protected]>--- arch/arm/mach-vt8500/vt8500.c | 1 - 1 file changed, 1 deletion(-)arch/arm/mach-vt8500/vt8500.c +0
-0
arch/arm/mach-vt8500/vt8500.c line 36
Quoted 6 lines
arch/arm/mach-vt8500/vt8500.c +0
-1@@ -32,7 +32,6 @@#include <linux/of_platform.h> #include <mach/restart.h> -#include <mach/gpio.h> #include "common.h"
Applied on top of existing vt8500/devel branch, thanks.
By the way, I noticed that there is no VT8500 defconfig in the tree, so there's no easy way for us to check for build breakages of your platform. You might want to add one.
Also, I noticed the following build warnings that you might want to address when I just built a very trivial config that enables the platform:
arch/arm/mach-vt8500/vt8500.c: In function 'vt8500_init':arch/arm/mach-vt8500/vt8500.c:81:8: warning: unused variable 'gpio_base' [-Wunused-variable] arch/arm/mach-vt8500/vt8500.c:80:27: warning: unused variable 'fb' [-Wunused-variable]
-Olof
PATCH 1/1 arm: vt8500: Fixup for missing gpio.h
Quoted 30 lines · Olof Johansson
Quoted 13 lines · Tony Prisk
mach/include/gpio.hwas removed as part of the multiplatform-3.7 update. This patch removes the include fromarch-vt8500/vt8500.cSigned-off-by Tony Prisk <[email protected]>--- arch/arm/mach-vt8500/vt8500.c | 1 - 1 file changed, 1 deletion(-)arch/arm/mach-vt8500/vt8500.c +0
-0arch/arm/mach-vt8500/vt8500.c line 36
Quoted 6 lines
arch/arm/mach-vt8500/vt8500.c +0
-1@@ -32,7 +32,6 @@#include <linux/of_platform.h> #include <mach/restart.h> -#include <mach/gpio.h> #include "common.h" Applied on top of existing vt8500/devel branch, thanks.
By the way, I noticed that there is no VT8500 defconfig in the tree, so there's no easy way for us to check for build breakages of your platform. You might want to add one.
Also, I noticed the following build warnings that you might want to address when I just built a very trivial config that enables the platform:
Quoted 6 lines
arch/arm/mach-vt8500/vt8500.c: In function 'vt8500_init':arch/arm/mach-vt8500/vt8500.c:81:8: warning: unused variable 'gpio_base' [-Wunused-variable]arch/arm/mach-vt8500/vt8500.c:80:27: warning: unused variable 'fb' [-Wunused-variable]-Olof
Argh.. I fixed that twice already.
Somehow I must have lost it while fixing up other problems.
I'll include that in the 3.7 cleanup stuff once -rc comes around.
Regards
Tony P
PATCH 1/1 arm: vt8500: Fixup for missing gpio.h
In reply to Olof JohanssonQuoted 3 lines · Olof Johansson
By the way, I noticed that there is no VT8500 defconfig in the tree, so there's no easy way for us to check for build breakages of your platform. You might want to add one.
I suppose if Tony and the other vt8500 developers manage to get the platform enabled for CONFIG_MULTIPLATFORM in 3.8, we can simply enable it in a future multi_v5_defconfig and don't even need the specific one.
On the other hand, those systems are fairly resource limited, so maybe we want to do both after all.
Arnd