fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup"

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Signed-off-by Stefan Roese <[email protected]>

---

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

common/cmd_fdt.c +3 -1

index e2225c4..d688334 100644
@@ -425,8 +425,10 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 	}
 #ifdef CONFIG_OF_BOARD_SETUP
 	/* Call the board-specific fixup routine */
-	else if (strncmp(argv[1], "boa", 3) == 0)
+	else if (strncmp(argv[1], "boa", 3) == 0) {
 		ft_board_setup(working_fdt, gd->bd);
+		fdt_chosen(working_fdt, 1);
+	}
 #endif
 	/* Create a chosen node */
 	else if (argv[1][0] == 'c') {

Signature · 6 lines

1.7.12.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 13 lines

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Signed-off-by Stefan Roese <[email protected]>

---

Quoted 2 lines

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen()

Hi Kumar,

Quoted 16 lines · Kumar Gala

Quoted 15 lines

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Signed-off-by Stefan Roese <[email protected]>

---

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

Quoted 3 lines

There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen()

Could you please elaborate what exactly you fear here? Is this a NACK for this patch?

Quoted 19 lines · Stefan Roese

Hi Kumar,

Quoted 16 lines · Kumar Gala

Quoted 15 lines

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Signed-off-by Stefan Roese <[email protected]>

---

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

Quoted 6 lines

Quoted 3 lines

There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen()

Could you please elaborate what exactly you fear here? Is this a NACK for this patch?

Possibly. I've got to find our docs on how we do 2-core AMP booting sequence w/regards to device tree.

Quoted 20 lines

Quoted 20 lines

Quoted 19 lines

Quoted 10 lines

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Quoted 5 lines

Signed-off-by Stefan Roese <[email protected]>

---

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen()

Quoted 4 lines

Quoted 2 lines

Could you please elaborate what exactly you fear here? Is this a NACK for this patch?

Possibly. I've got to find our docs on how we do 2-core AMP booting sequence w/regards to device tree.

See if this works:

http://www.freescale.com/infocenter/index.jsp?topic=%2FQORIQSDK%2F2151493.html

Quoted 23 lines · On 09/27/2012 10:43 PM, McClintock Matthew-B29882 wrote:

Quoted 23 lines

Quoted 22 lines

Quoted 13 lines

Quoted 13 lines

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Signed-off-by Stefan Roese <[email protected]>

---

Quoted 6 lines

Quoted 2 lines

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen()

Could you please elaborate what exactly you fear here? Is this a NACK for this patch?

Quoted 5 lines

Quoted 1 line

Possibly. I've got to find our docs on how we do 2-core AMP booting sequence w/regards to device tree.

See if this works:

http://www.freescale.com/infocenter/index.jsp?topic=%2FQORIQSDK%2F2151493.html

Kumar, did you find the time to check/test this? I would really like to know if this patch is okay with you.

Quoted 24 lines · Stefan Roese

Quoted 23 lines · On 09/27/2012 10:43 PM, McClintock Matthew-B29882 wrote:

Quoted 23 lines

Quoted 22 lines

Quoted 13 lines

Quoted 13 lines

By calling fdt_chosen(), the chosen node will be updated / created by the "fdt boardsetup" command. This is useful for setting of the kernel commandline via the "bootargs" env variable.

With this change, the "fdt boardsetup" can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting.

Signed-off-by Stefan Roese <[email protected]>

---

Quoted 6 lines

Quoted 2 lines

common/cmd_fdt.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen()

Could you please elaborate what exactly you fear here? Is this a NACK for this patch?

Quoted 8 lines

Quoted 5 lines

Quoted 1 line

Possibly. I've got to find our docs on how we do 2-core AMP booting sequence w/regards to device tree.

See if this works:

http://www.freescale.com/infocenter/index.jsp?topic=%2FQORIQSDK%2F2151493.html

Kumar, did you find the time to check/test this? I would really like to know if this patch is okay with you.

This should be fine. You are calling fdt_chosen(), but we can still run 'fdt chosen $initrd_start $initrd_end' after 'fdt boardsetup'. A quick glance at fdt_chosen() suggest it can be run multiple times without error.

You might add a comment in the U_BOOT_CMD that mentions boardsetup calls chosen.