mfd: tps65910: remove warning during dt node parsing
Subsystems (2)
Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this case it should not throw the warning message.
It creates noise from driver as follows:
[ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
Removing the warning message from driver.
---
It seems orginal patch has been lost. Reposting it.
drivers/mfd/tps65910.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
drivers/mfd/tps65910.c +0 -4
@@ -184,14 +184,10 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client, ret =of_property_read_u32 (np,"ti,vmbch-threshold" , &prop);if (!ret) board_info->vmbch_threshold = prop; -else if (*chip_id ==TPS65911 ) -dev_warn (&client->dev,"VMBCH-Threshold not specified" ); ret =of_property_read_u32 (np,"ti,vmbch2-threshold" , &prop);if (!ret) board_info->vmbch2_threshold = prop; -else if (*chip_id ==TPS65911 ) -dev_warn (&client->dev,"VMBCH2-Threshold not specified" ); prop =of_property_read_bool (np,"ti,en-ck32k-xtal" ); board_info->en_ck32k_xtal = prop;
Signature · 1 line
1.7.1.1
Hi,
Quoted 6 lines · Laxman Dewangan
Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this case it should not throw the warning message.
It creates noise from driver as follows:
Quoted 8 lines
[ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specifiedRemoving the warning message from driver.
Signed-off-by Laxman Dewangan <[email protected]>---
It seems orginal patch has been lost. Reposting it.
I still see this with 3.12-rc. Sam?
Hi Olof,
Quoted 12 lines · Olof Johansson
Hi,
Quoted 9 lines · Laxman Dewangan
Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this case it should not throw the warning message.
It creates noise from driver as follows:[ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
Quoted 7 lines
Quoted 5 lines
Removing the warning message from driver.
Signed-off-by Laxman Dewangan <[email protected]>---
It seems orginal patch has been lost. Reposting it.I still see this with 3.12-rc. Sam?
I can take it through mfd-next, but do you really think it's material for mfd-fixes ?
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/
Hi,
Quoted 17 lines · Samuel Ortiz
Hi Olof,
Quoted 14 lines · Olof Johansson
Hi,
Quoted 11 lines · Laxman Dewangan
Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this case it should not throw the warning message.
It creates noise from driver as follows:[ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specifiedRemoving the warning message from driver.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Laxman Dewangan <[email protected]>---
It seems orginal patch has been lost. Reposting it.I still see this with 3.12-rc. Sam?
I can take it through mfd-next, but do you really think it's material for mfd-fixes ?
Oh, 3.13 is definitely fine, it'd just be good to see it not fall between the cracks. It's a harmless warning.
-Olof
Hi Laxman,
Quoted 9 lines · Laxman Dewangan
Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this case it should not throw the warning message.
It creates noise from driver as follows:[ 0.384605] tps65910 4-002d: VMBCH-Threshold not specified [ 0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
Quoted 8 lines
Removing the warning message from driver.
Signed-off-by Laxman Dewangan <[email protected]>---
It seems orginal patch has been lost. Reposting it.drivers/mfd/tps65910.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
Applied and pushed to mfd-next, thanks.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/