nand: add ID for Micron MT29F8G08A

PATCH New Lucas Stach 2 participants 7 messages Sep 27, 2012 – Sep 28, 2012

Subsystems (2)

Memory technology devices (MTD) NAND flash

lore

Share & tools

lore

Lucas Stach

author

2012-09-27 21:49 UTC #0 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

As found on the Colibri T20 engineering sample board.

Signed-off-by Lucas Stach <[email protected]>

---
 drivers/mtd/nand/nand_ids.c | 1 +

1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)

drivers/mtd/nand/nand_ids.c +1 -0

index 3953549..ae300fe 100644
@@ -105,6 +105,7 @@ const struct nand_flash_dev nand_flash_ids[] = {
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0, LP_OPTIONS16},
 
 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0, LP_OPTIONS16},

Signature · 1 line

1.7.11.4

Scott Wood

2012-09-27 21:53 UTC #1 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

Quoted 20 lines · Lucas Stach

As found on the Colibri T20 engineering sample board.

Signed-off-by Lucas Stach <[email protected]>

---
 drivers/mtd/nand/nand_ids.c | 1 +

1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)

drivers/mtd/nand/nand_ids.c +1 -1

index 3953549..ae300fe 100644
@@ -105,6 +105,7 @@ const struct nand_flash_dev nand_flash_ids[] = {
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0, LP_OPTIONS16},
 
 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0, LP_OPTIONS16},
--

Quoted 1 line

1.7.11.4

Does this chip support ONFI? If so, we don't use the ID table.

-Scott

Lucas Stach

author

2012-09-27 22:08 UTC #2 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

Am Donnerstag, den 27.09.2012, 16:53 -0500 schrieb Scott Wood:

Quoted 15 lines · Lucas Stach

Quoted 14 lines
As found on the Colibri T20 engineering sample board.
Signed-off-by Lucas Stach <[email protected]>
---
 drivers/mtd/nand/nand_ids.c | 1 +
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)
drivers/mtd/nand/nand_ids.c +0 -0
index 3953549..ae300fe 100644
@@ -105,6 +105,7 @@ const struct nand_flash_dev nand_flash_ids[] = {
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0, LP_OPTIONS16},
 

Quoted 10 lines

Quoted 7 lines

drivers/mtd/nand/nand_ids.c +1 -1

 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0, LP_OPTIONS16},
--

1.7.11.4

Does this chip support ONFI? If so, we don't use the ID table.

I just rechecked, the datasheet claims the chip supports ONFI 2.0, but it does not get detected by the u-boot NAND code without the entry in the id table. CONFIG_SYS_NAND_ONFI_DETECTION is set.

Lucas

Scott Wood

2012-09-27 22:13 UTC #3 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

Quoted 28 lines · Lucas Stach

Am Donnerstag, den 27.09.2012, 16:53 -0500 schrieb Scott Wood:
Quoted 9 lines · Lucas Stach
Review
Quoted 8 lines
As found on the Colibri T20 engineering sample board.
Signed-off-by Lucas Stach <[email protected]>
---
 drivers/mtd/nand/nand_ids.c | 1 +
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)
(quoted diff) +0 -0
b/drivers/mtd/nand/nand_ids.c
Quoted 4 lines
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev nand_flash_ids[]
Quoted 4 lines
index 3953549..ae300fe 100644
drivers/mtd/nand/nand_ids.c +0 -0
@@ -105,6 +105,7 @@ const struct nand_flash_dev nand_flash_ids[]  
= {
Quoted 12 lines
Quoted 9 lines
drivers/mtd/nand/nand_ids.c +1 -1
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0, LP_OPTIONS16},
 
 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0, LP_OPTIONS16},
--
1.7.11.4
Does this chip support ONFI? If so, we don't use the ID table.

Quoted 3 lines

I just rechecked, the datasheet claims the chip supports ONFI 2.0, but it does not get detected by the u-boot NAND code without the entry in the id table. CONFIG_SYS_NAND_ONFI_DETECTION is set.

Could you debug it? Could there be a problem in the NAND controller (or the driver)?

Are you using a recent U-Boot tree?

-Scott

Lucas Stach

author

2012-09-27 22:19 UTC #4 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

Am Donnerstag, den 27.09.2012, 17:13 -0500 schrieb Scott Wood:

Quoted 29 lines · Lucas Stach

Quoted 28 lines
Am Donnerstag, den 27.09.2012, 16:53 -0500 schrieb Scott Wood:
Quoted 9 lines · Lucas Stach
Review
Quoted 8 lines
As found on the Colibri T20 engineering sample board.
Signed-off-by Lucas Stach <[email protected]>
---
 drivers/mtd/nand/nand_ids.c | 1 +
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)
(quoted diff) +0 -0
b/drivers/mtd/nand/nand_ids.c
Quoted 4 lines
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev nand_flash_ids[]
Quoted 4 lines
index 3953549..ae300fe 100644
drivers/mtd/nand/nand_ids.c +0 -0
@@ -105,6 +105,7 @@ const struct nand_flash_dev nand_flash_ids[]  
= {
Quoted 12 lines
Quoted 9 lines
drivers/mtd/nand/nand_ids.c +1 -1
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0, LP_OPTIONS16},
 
 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0, LP_OPTIONS},
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0, LP_OPTIONS16},
--
1.7.11.4
Does this chip support ONFI? If so, we don't use the ID table.

Quoted 7 lines

Quoted 3 lines
I just rechecked, the datasheet claims the chip supports ONFI 2.0, but it does not get detected by the u-boot NAND code without the entry in the id table. CONFIG_SYS_NAND_ONFI_DETECTION is set.
Could you debug it? Could there be a problem in the NAND controller (or the driver)?

Haven't done much in tracking this down much further. Could quite possible be a bug in the Tegra nand driver, this driver isn't in tree for a long time and it seems no Tegra board so far tried using ONFI.

Quoted 2 lines

Are you using a recent U-Boot tree?

Recent master tree as of today.

Lucas

Scott Wood

2012-09-27 22:27 UTC #5 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

Quoted 40 lines · Lucas Stach

Am Donnerstag, den 27.09.2012, 17:13 -0500 schrieb Scott Wood:
Quoted 10 lines · Lucas Stach
Quoted 9 lines
Am Donnerstag, den 27.09.2012, 16:53 -0500 schrieb Scott Wood:
Quoted 8 lines · Lucas Stach
Quoted 7 lines
As found on the Colibri T20 engineering sample board.
Signed-off-by Lucas Stach <[email protected]>
---
 drivers/mtd/nand/nand_ids.c | 1 +
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0 -0
b/drivers/mtd/nand/nand_ids.c
Quoted 4 lines
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev
Quoted 4 lines
index 3953549..ae300fe 100644
drivers/mtd/nand/nand_ids.c +0 -0
@@ -105,6 +105,7 @@ const struct nand_flash_dev  
nand_flash_ids[]
Quoted 2 lines
Quoted 2 lines
= {
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0,  
LP_OPTIONS16},
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 107
Quoted 3 lines
drivers/mtd/nand/nand_ids.c +1 -0
 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0,  
LP_OPTIONS},
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 108
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0,  
LP_OPTIONS},
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 109
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0,  
LP_OPTIONS},
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 110
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0,  
LP_OPTIONS16},
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
drivers/mtd/nand/nand_ids.c +0 -1
--
1.7.11.4
Does this chip support ONFI? If so, we don't use the ID table.
I just rechecked, the datasheet claims the chip supports ONFI
2.0, but
Quoted 1 line
Quoted 1 line
it does not get detected by the u-boot NAND code without the
entry in

Quoted 8 lines

Quoted 5 lines
Quoted 1 line
the id table. CONFIG_SYS_NAND_ONFI_DETECTION is set.
Could you debug it? Could there be a problem in the NAND controller (or the driver)?
Haven't done much in tracking this down much further. Could quite possible be a bug in the Tegra nand driver, this driver isn't in tree for a long time and it seems no Tegra board so far tried using ONFI.

I don't see the Tegra READID code using column, which is a problem. Hopefully this is a driver limitation and not hardware, unlike i.MX.

-Scott

Lucas Stach

author

2012-09-28 15:20 UTC #6 lore raw

PATCH 1/1 nand: add ID for Micron MT29F8G08A

Hi Scott,

Am Donnerstag, den 27.09.2012, 17:27 -0500 schrieb Scott Wood:

Quoted 46 lines · Lucas Stach

Quoted 45 lines
Am Donnerstag, den 27.09.2012, 17:13 -0500 schrieb Scott Wood:
Quoted 10 lines · Lucas Stach
Quoted 9 lines
Am Donnerstag, den 27.09.2012, 16:53 -0500 schrieb Scott Wood:
Quoted 8 lines · Lucas Stach
Quoted 7 lines
As found on the Colibri T20 engineering sample board.
Signed-off-by Lucas Stach <[email protected]>
---
 drivers/mtd/nand/nand_ids.c | 1 +
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0 -0
b/drivers/mtd/nand/nand_ids.c
Quoted 4 lines
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev
Quoted 4 lines
index 3953549..ae300fe 100644
drivers/mtd/nand/nand_ids.c +0 -0
@@ -105,6 +105,7 @@ const struct nand_flash_dev  
nand_flash_ids[]
Quoted 2 lines
Quoted 2 lines
= {
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 512MiB 3,3V 16-bit",	0xCC, 0, 512, 0,  
LP_OPTIONS16},
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 107
Quoted 3 lines
drivers/mtd/nand/nand_ids.c +1 -0
 	/* 8 Gigabit */
+	{"NAND 1GiB 3,3V 8-bit",	0x38, 0, 1024, 0,  
LP_OPTIONS},
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 108
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 1GiB 1,8V 8-bit",	0xA3, 0, 1024, 0,  
LP_OPTIONS},
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 109
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 1GiB 3,3V 8-bit",	0xD3, 0, 1024, 0,  
LP_OPTIONS},
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/mtd/nand/nand_ids.c const struct nand_flash_dev · line 110
Quoted 1 line
drivers/mtd/nand/nand_ids.c +0 -0
 	{"NAND 1GiB 1,8V 16-bit",	0xB3, 0, 1024, 0,  
LP_OPTIONS16},
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
drivers/mtd/nand/nand_ids.c +0 -1
--
1.7.11.4
Does this chip support ONFI? If so, we don't use the ID table.
I just rechecked, the datasheet claims the chip supports ONFI
2.0, but
Quoted 1 line
Quoted 1 line
it does not get detected by the u-boot NAND code without the
entry in
Quoted 5 lines
Quoted 1 line
the id table. CONFIG_SYS_NAND_ONFI_DETECTION is set.
Could you debug it? Could there be a problem in the NAND controller (or the driver)?

Quoted 7 lines

Quoted 3 lines
Haven't done much in tracking this down much further. Could quite possible be a bug in the Tegra nand driver, this driver isn't in tree for a long time and it seems no Tegra board so far tried using ONFI.
I don't see the Tegra READID code using column, which is a problem. Hopefully this is a driver limitation and not hardware, unlike i.MX.

Please disregard this patch. I've got ONFI working properly on the Tegra and will send out a patch to enable this shortly.

Thanks,
Lucas