Skip to contentSkip to conversation

gpio: mvebu: Add missing breaks in mvebu_gpio_irq_set_type

PATCH In review Axel Lin 5 participants 5 messages Sep 30, 2012 – Oct 1, 2012 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: mvebu: Add missing breaks in mvebu_gpio_irq_set_type

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-mvebu.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpio/gpio-mvebu.c +3 -0
index 902af43..7a874129 100644
@@ -381,11 +381,13 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 		u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
 		u &= ~(1 << pin);
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	case IRQ_TYPE_EDGE_FALLING:
 	case IRQ_TYPE_LEVEL_LOW:
 		u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
 		u |= 1 << pin;
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	case IRQ_TYPE_EDGE_BOTH: {
 		u32 v;
 

@@ -401,6 +403,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 		else
 			u &= ~(1 << pin);	/* rising */
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	}
 	}
 	return 0;
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 24 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-mvebu.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpio/gpio-mvebu.c +2 -0
index 902af43..7a874129 100644
@@ -381,11 +381,13 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 		u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
 		u &= ~(1 << pin);
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	case IRQ_TYPE_EDGE_FALLING:
 	case IRQ_TYPE_LEVEL_LOW:
 		u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
 		u |= 1 << pin;
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	case IRQ_TYPE_EDGE_BOTH: {
 		u32 v;

drivers/gpio/gpio-mvebu.c static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type) · line 409

Quoted 7 lines
drivers/gpio/gpio-mvebu.c +1 -0
@@ -401,6 +403,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 		else
 			u &= ~(1 << pin);	/* rising */
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	}
 	}
 	return 0;

Hi Axel

Good catch, thanks.

Acked-by Andrew Lunn <[email protected]>

Andrew

Acked-by on v1 1/1
#2 lore raw
In reply to Axel Lin

Dear Axel Lin,

Quoted 24 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-mvebu.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpio/gpio-mvebu.c +2 -0
index 902af43..7a874129 100644
@@ -381,11 +381,13 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 		u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
 		u &= ~(1 << pin);
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	case IRQ_TYPE_EDGE_FALLING:
 	case IRQ_TYPE_LEVEL_LOW:
 		u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
 		u |= 1 << pin;
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	case IRQ_TYPE_EDGE_BOTH: {
 		u32 v;

drivers/gpio/gpio-mvebu.c static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type) · line 409

Quoted 7 lines
drivers/gpio/gpio-mvebu.c +1 -0
@@ -401,6 +403,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 		else
 			u &= ~(1 << pin);	/* rising */
 		writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip));
+		break;
 	}
 	}
 	return 0;

Doh, I missed this when converting the if() series to a switch() construct. It was just pure luck that it worked. Good catch indeed.

Acked-by Thomas Petazzoni <[email protected]>
Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com