mm/mempolicy.c:2426 mpol_parse_str() error: buffer overflow 'policy_modes

PATCH Peter Zijlstra 1 participant 1 message Oct 1, 2012

Subsystems (3)

Memory management Kernel janitors MM NUMA placement

lore

Share & tools

lore

Peter Zijlstra

author

2012-10-01 13:22 UTC #0 lore raw

Quoted 1 line · Fengguang Wu

+ mm/mempolicy.c:2426 mpol_parse_str() error: buffer overflow 'policy_modes' 5 <= 5

---
Subject: mm, mpol: Fix buffer overflow in mpol_parse_str()
From: Peter Zijlstra <[email protected]>
Date: Mon Oct 01 15:12:16 CEST 2012

Wu reported a smatch error:

+ mm/mempolicy.c:2426 mpol_parse_str() error: buffer overflow 'policy_modes' 5 <= 5

Fix it by growing the array to the right size, but avoid it being a valid string for mpol_parse_str() because its not an effective policy.

Reported-by Fengguang Wu <[email protected]>

Signed-off-by Peter Zijlstra <[email protected]>

---
 mm/mempolicy.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

mm/mempolicy.c +3 -2

@@ -2514,7 +2514,8 @@ static const char * const policy_modes[]
 	[MPOL_PREFERRED]  = "prefer",
 	[MPOL_BIND]       = "bind",
 	[MPOL_INTERLEAVE] = "interleave",
-	[MPOL_LOCAL]      = "local"
+	[MPOL_LOCAL]      = "local",
+	[MPOL_NOOP]	  = "noop",	/* should not actually be used */
 };

@@ -2565,7 +2566,7 @@ int mpol_parse_str(char *str, struct mem
 			break;
 		}
 	}
-	if (mode >= MPOL_MAX)
+	if (mode >= MPOL_MAX || mode = MPOL_NOOP)
 		goto out;
 
 	switch (mode) {