Documentation: update nfs option in filesystem/vfat.txt
PATCH v4 4/4 Documentation: update nfs option in filesystem/vfat.txt
From: Namjae Jeon <[email protected]>
update nfs option in filesystem/vfat.txt
--- Documentation/filesystems/vfat.txt | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-)
Documentation/filesystems/vfat.txt +18 -5
@@ -141,13 +141,26 @@ discard -- If set, issues discard/TRIM commands to the block device when blocks are freed. This is useful for SSD devices and sparse/thinly-provisoned LUNs. -nfs -- This option maintains an index (cache) of directory - inodes by i_logstart which is used by the nfs-related code to - improve look-ups. - - Enable this only if you want to export the FAT filesystem +nfs= stale_rw|nostale_ro + -- Enable this only if you want to export the FAT filesystem over NFS + stale_rw:This option maintains an index (cache) of directory + inodes by i_logstart which is used by the nfs-related code to + improve look-ups.Full file operations (read/write) over NFS is supported + but with cache eviction at NFS server, this could result in ESTALE issues. + + nostale_ro:This option bases the inode number and filehandle on the on-disk + location of a file in the MS-DOS directory entry.This ensures that ESTALE + will not be returned after a file is evicted from the inode cache. However, + it means that operations such as rename, create and unlink could cause + filehandles that previously pointed at one file to point at a different file, + potentially causing data corruption. For this reason, this option also mounts + the filesystem readonly. + + To maintain backward compatibility, '-o nfs' is also accepted, defaulting to + stale_rw + <bool>: 0,1,yes,no,true,false TODO
Signature · 1 line
1.7.9.5
Quoted 34 lines · Namjae Jeon
From: Namjae Jeon <[email protected]>
update nfs option in
filesystem/vfat.txtSigned-off-by Namjae Jeon <[email protected]>Signed-off-by Ravishankar N <[email protected]>Signed-off-by Amit Sahrawat <[email protected]>--- Documentation/filesystems/vfat.txt | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-)Documentation/filesystems/vfat.txt +8
-5@@ -141,13 +141,26 @@ discard -- If set, issues discard/TRIM commands to the block device when blocks are freed. This is useful for SSD devices and sparse/thinly-provisoned LUNs. -nfs -- This option maintains an index (cache) of directory - inodes by i_logstart which is used by the nfs-related code to - improve look-ups. - - Enable this only if you want to export the FAT filesystem +nfs= stale_rw|nostale_ro + -- Enable this only if you want to export the FAT filesystem over NFS + stale_rw:This option maintains an index (cache) of directory + inodes by i_logstart which is used by the nfs-related code to + improve look-ups.Full file operations (read/write) over NFS is supported + but with cache eviction at NFS server, this could result in ESTALE issues. + + nostale_ro:This option bases the inode number and filehandle on the on-disk
Documentation/filesystems/vfat.txt discard -- If set, issues discard/TRIM commands to the block · line 163
Quoted 10 lines
Documentation/filesystems/vfat.txt +10
-0+ location of a file in the MS-DOS directory entry.This ensures that ESTALE + will not be returned after a file is evicted from the inode cache. However, + it means that operations such as rename, create and unlink could cause + filehandles that previously pointed at one file to point at a different file, + potentially causing data corruption. For this reason, this option also mounts + the filesystem readonly. + + To maintain backward compatibility, '-o nfs' is also accepted, defaulting to + stale_rw +
The documentation makes more sense to me now, thanks.
--b.
2012/10/9, J. Bruce Fields <[email protected]>:
Quoted 50 lines · Namjae Jeon
Quoted 49 lines
From: Namjae Jeon <[email protected]>
update nfs option in
filesystem/vfat.txtSigned-off-by Namjae Jeon <[email protected]>Signed-off-by Ravishankar N <[email protected]>Signed-off-by Amit Sahrawat <[email protected]>--- Documentation/filesystems/vfat.txt | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-)Documentation/filesystems/vfat.txt +0
-0@@ -141,13 +141,26 @@ discard -- If set, issues discard/TRIMcommands to the block
Documentation/filesystems/vfat.txt +5
-5device when blocks are freed. This is useful for SSD devices and sparse/thinly-provisoned LUNs. -nfs -- This option maintains an index (cache) of directory - inodes by i_logstart which is used by the nfs-related code to - improve look-ups. - - Enable this only if you want to export the FAT filesystem +nfs= stale_rw|nostale_ro + -- Enable this only if you want to export the FAT filesystem over NFS + stale_rw:This option maintains an index (cache) of directory + inodes by i_logstart which is used by the nfs-related code to + improve look-ups.Full file operations (read/write) over NFS issupported
Documentation/filesystems/vfat.txt +1
-0+ but with cache eviction at NFS server, this could result in ESTALEissues.
Documentation/filesystems/vfat.txt +2
-0+ + nostale_ro:This option bases the inode number and filehandle on theon-disk
Documentation/filesystems/vfat.txt +1
-0+ location of a file in the MS-DOS directory entry.This ensures thatESTALE
Documentation/filesystems/vfat.txt +1
-0+ will not be returned after a file is evicted from the inode cache.However,
Documentation/filesystems/vfat.txt +1
-0+ it means that operations such as rename, create and unlink couldcause
Documentation/filesystems/vfat.txt +1
-0+ filehandles that previously pointed at one file to point at adifferent file,
Documentation/filesystems/vfat.txt +1
-0+ potentially causing data corruption. For this reason, this option alsomounts
Quoted 8 lines
Documentation/filesystems/vfat.txt discard -- If set, issues discard/TRIM commands to the block · line 163
Quoted 6 lines
Documentation/filesystems/vfat.txt +3
-0+ the filesystem readonly. + + To maintain backward compatibility, '-o nfs' is also accepted,defaulting to
Documentation/filesystems/vfat.txt +2
-0+ stale_rw +The documentation makes more sense to me now, thanks.
Thanks for your review.
Quoted 3 lines
--b.