Skip to contentSkip to conversation

Documentation: update nfs option in filesystem/vfat.txt

PATCH Superseded Namjae Jeon 2 participants 3 messages Oct 7, 2012 – Oct 9, 2012 Documentation

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 4/4 Documentation: update nfs option in filesystem/vfat.txt

From: Namjae Jeon <[email protected]>

update nfs option in filesystem/vfat.txt

---
 Documentation/filesystems/vfat.txt |   23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)
Documentation/filesystems/vfat.txt +18 -5
index de1e6c4..d62f8e6 100644
@@ -141,13 +141,26 @@ discard       -- If set, issues discard/TRIM commands to the block
 		 device when blocks are freed. This is useful for SSD devices
 		 and sparse/thinly-provisoned LUNs.
 
-nfs           -- This option maintains an index (cache) of directory
-		 inodes by i_logstart which is used by the nfs-related code to
-		 improve look-ups.
-
-		 Enable this only if you want to export the FAT filesystem
+nfs= stale_rw|nostale_ro
+	      -- Enable this only if you want to export the FAT filesystem
 		 over NFS
 
+		 stale_rw:This option maintains an index (cache) of directory
+		 inodes by i_logstart which is used by the nfs-related code to
+		 improve look-ups.Full file operations (read/write) over NFS is supported
+		 but with cache eviction at NFS server, this could result in ESTALE issues.
+
+		 nostale_ro:This option bases the inode number and filehandle on the on-disk
+		 location of a file in the MS-DOS directory entry.This ensures that ESTALE
+		 will not be returned after a file is evicted from the inode cache. However,
+		 it means that operations such as rename, create and unlink could cause
+		 filehandles that previously pointed at one file to point at a different file,
+		 potentially causing data corruption. For this reason, this option also mounts
+		 the filesystem readonly.
+
+		 To maintain backward compatibility, '-o nfs' is also accepted, defaulting to
+		 stale_rw
+
 <bool>: 0,1,yes,no,true,false
 
 TODO
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 34 lines · Namjae Jeon

From: Namjae Jeon <[email protected]>

update nfs option in filesystem/vfat.txt

---
 Documentation/filesystems/vfat.txt |   23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)
Documentation/filesystems/vfat.txt +8 -5
index de1e6c4..d62f8e6 100644
@@ -141,13 +141,26 @@ discard       -- If set, issues discard/TRIM commands to the block
 		 device when blocks are freed. This is useful for SSD devices
 		 and sparse/thinly-provisoned LUNs.
 
-nfs           -- This option maintains an index (cache) of directory
-		 inodes by i_logstart which is used by the nfs-related code to
-		 improve look-ups.
-
-		 Enable this only if you want to export the FAT filesystem
+nfs= stale_rw|nostale_ro
+	      -- Enable this only if you want to export the FAT filesystem
 		 over NFS
 
+		 stale_rw:This option maintains an index (cache) of directory
+		 inodes by i_logstart which is used by the nfs-related code to
+		 improve look-ups.Full file operations (read/write) over NFS is supported
+		 but with cache eviction at NFS server, this could result in ESTALE issues.
+
+		 nostale_ro:This option bases the inode number and filehandle on the on-disk

Documentation/filesystems/vfat.txt discard -- If set, issues discard/TRIM commands to the block · line 163

Quoted 10 lines
Documentation/filesystems/vfat.txt +10 -0
+		 location of a file in the MS-DOS directory entry.This ensures that ESTALE
+		 will not be returned after a file is evicted from the inode cache. However,
+		 it means that operations such as rename, create and unlink could cause
+		 filehandles that previously pointed at one file to point at a different file,
+		 potentially causing data corruption. For this reason, this option also mounts
+		 the filesystem readonly.
+
+		 To maintain backward compatibility, '-o nfs' is also accepted, defaulting to
+		 stale_rw
+

The documentation makes more sense to me now, thanks.

--b.

#2 lore raw

2012/10/9, J. Bruce Fields <[email protected]>:

Quoted 50 lines · Namjae Jeon
Quoted 49 lines

From: Namjae Jeon <[email protected]>

update nfs option in filesystem/vfat.txt

---
 Documentation/filesystems/vfat.txt |   23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)
Documentation/filesystems/vfat.txt +0 -0
index de1e6c4..d62f8e6 100644
@@ -141,13 +141,26 @@ discard       -- If set, issues discard/TRIM

commands to the block

Documentation/filesystems/vfat.txt +5 -5
 		 device when blocks are freed. This is useful for SSD devices
 		 and sparse/thinly-provisoned LUNs.
 
-nfs           -- This option maintains an index (cache) of directory
-		 inodes by i_logstart which is used by the nfs-related code to
-		 improve look-ups.
-
-		 Enable this only if you want to export the FAT filesystem
+nfs= stale_rw|nostale_ro
+	      -- Enable this only if you want to export the FAT filesystem
 		 over NFS
 
+		 stale_rw:This option maintains an index (cache) of directory
+		 inodes by i_logstart which is used by the nfs-related code to
+		 improve look-ups.Full file operations (read/write) over NFS is

supported

Documentation/filesystems/vfat.txt +1 -0
+		 but with cache eviction at NFS server, this could result in ESTALE

issues.

Documentation/filesystems/vfat.txt +2 -0
+
+		 nostale_ro:This option bases the inode number and filehandle on the

on-disk

Documentation/filesystems/vfat.txt +1 -0
+		 location of a file in the MS-DOS directory entry.This ensures that

ESTALE

Documentation/filesystems/vfat.txt +1 -0
+		 will not be returned after a file is evicted from the inode cache.

However,

Documentation/filesystems/vfat.txt +1 -0
+		 it means that operations such as rename, create and unlink could

cause

Documentation/filesystems/vfat.txt +1 -0
+		 filehandles that previously pointed at one file to point at a

different file,

Documentation/filesystems/vfat.txt +1 -0
+		 potentially causing data corruption. For this reason, this option also

mounts

Quoted 8 lines

Documentation/filesystems/vfat.txt discard -- If set, issues discard/TRIM commands to the block · line 163

Quoted 6 lines
Documentation/filesystems/vfat.txt +3 -0
+		 the filesystem readonly.
+
+		 To maintain backward compatibility, '-o nfs' is also accepted,

defaulting to

Documentation/filesystems/vfat.txt +2 -0
+		 stale_rw
+

The documentation makes more sense to me now, thanks.

Thanks for your review.

Quoted 3 lines

--b.