cpuidle: menu: Avoid overflows when computing variance
PATCH 1/1 cpuidle: menu: Avoid overflows when computing variance
From: Rafael J. Wysocki <[email protected]>
The variance computation in get_typical_interval() may overflow if the square of the value of diff exceeds the maximum for the int64_t data type value which basically is the case when it is of the order of UINT_MAX.
However, data points so far in the future don't matter for idle state selection anyway, so change the initial threshold value in get_typical_interval() to INT_MAX which will cause more "outlying" data points to be discarded without affecting the selection result.
Reported-by Randy Dunlap <[email protected]>
Signed-off-by Rafael J. Wysocki <[email protected]>
--- drivers/cpuidle/governors/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpuidle/governors/menu.c +1 -1
@@ -186,7 +186,7 @@ static unsigned int get_typical_intervalunsigned int min, max, thresh, avg;uint64_t sum, variance; - thresh =UINT_MAX ;/* Discard outliers above this value */ + thresh =INT_MAX ;/* Discard outliers above this value */ again: