arm-soc: vt8500: Cleanup patches for 3.7
Subsystems (3)
cover arm-soc: vt8500: Cleanup patches for 3.7
Minor cleanup patches for 3.7.
Tony Prisk (4):
vt8500: Remove unused headers from include/mach/
vt8500: Remove arm/boot/compressed/head-vt8500.S
vt8500: Fix header in mach-vt8500/timer.c
vt8500: Fix build warning when no framebuffer selected
arch/arm/boot/compressed/Makefile | 4 --- arch/arm/boot/compressed/head-vt8500.S | 46 -------------------------- arch/arm/mach-vt8500/include/mach/hardware.h | 12 ------- arch/arm/mach-vt8500/include/mach/i8042.h | 18 ---------- arch/arm/mach-vt8500/include/mach/restart.h | 17 ---------- arch/arm/mach-vt8500/timer.c | 2 +- arch/arm/mach-vt8500/vt8500.c | 7 ++-- 7 files changed, 5 insertions(+), 101 deletions(-) delete mode 100644 arch/arm/boot/compressed/head-vt8500.S delete mode 100644 arch/arm/mach-vt8500/include/mach/hardware.h delete mode 100644 arch/arm/mach-vt8500/include/mach/i8042.h delete mode 100644 arch/arm/mach-vt8500/include/mach/restart.h
Signature · 1 line
1.7.9.5
PATCH 1/4 vt8500: Remove unused headers from include/mach/
Remove restart.h and reference in vt8500.c - unused. Remove hardware.h - empty and now optional. Remove i8042.h - not supported now that devicetree-only.
--- arch/arm/mach-vt8500/include/mach/hardware.h | 12 ------------ arch/arm/mach-vt8500/include/mach/i8042.h | 18 ------------------ arch/arm/mach-vt8500/include/mach/restart.h | 17 ----------------- arch/arm/mach-vt8500/vt8500.c | 2 -- 4 files changed, 49 deletions(-) delete mode 100644 arch/arm/mach-vt8500/include/mach/hardware.h delete mode 100644 arch/arm/mach-vt8500/include/mach/i8042.h delete mode 100644 arch/arm/mach-vt8500/include/mach/restart.h
arch/arm/mach-vt8500/include/mach/hardware.h deleted +0 -12
@@ -1,12 +0,0 @@ -/* arch/arm/mach-vt8500/include/mach/hardware.h -* -* This software is licensed under the terms of the GNU General Public -* License version 2, as published by the Free Software Foundation, and -* may be copied, distributed, and modified under those terms. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -*/
arch/arm/mach-vt8500/include/mach/i8042.h deleted +0 -18
@@ -1,18 +0,0 @@ -/* arch/arm/mach-vt8500/include/mach/i8042.h -* -* Copyright (C) 2010 Alexey Charkov <[email protected]> -* -* This software is licensed under the terms of the GNU General Public -* License version 2, as published by the Free Software Foundation, and -* may be copied, distributed, and modified under those terms. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -*/ - -extern unsigned long wmt_i8042_base__initdata ; -extern int wmt_i8042_kbd_irq; -extern int wmt_i8042_aux_irq;
arch/arm/mach-vt8500/include/mach/restart.h deleted +0 -17
@@ -1,17 +0,0 @@ -/* linux/arch/arm/mach-vt8500/restart.h -* -* Copyright (C) 2012 Tony Prisk <[email protected]> -* -* This software is licensed under the terms of the GNU General Public -* License version 2, as published by the Free Software Foundation, and -* may be copied, distributed, and modified under those terms. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -*/ - -void vt8500_setup_restart (void ); -void vt8500_restart (char mode,const char *cmd);
arch/arm/mach-vt8500/vt8500.c +0 -2
@@ -31,8 +31,6 @@#include <linux/of_irq.h> #include <linux/of_platform.h> -#include <mach/restart.h> -#include "common.h" #define LEGACY_GPIO_BASE 0xD8110000
Signature · 1 line
1.7.9.5
PATCH 2/4 vt8500: Remove arm/boot/compressed/head-vt8500.S
In reply to Tony PriskConverting arch-vt8500 to devicetree-only makes this file redundant.
--- arch/arm/boot/compressed/Makefile | 4 --- arch/arm/boot/compressed/head-vt8500.S | 46 -------------------------------- 2 files changed, 50 deletions(-) delete mode 100644 arch/arm/boot/compressed/head-vt8500.S
arch/arm/boot/compressed/Makefile +0 -4
@@ -50,10 +50,6 @@ ifeq ($(CONFIG_ARCH_SA1100),y) OBJS += head-sa1100.o endif -ifeq ($(CONFIG_ARCH_VT8500),y) -OBJS += head-vt8500.o -endif - ifeq ($(CONFIG_CPU_XSCALE),y) OBJS += head-xscale.o endif
arch/arm/boot/compressed/head-vt8500.S deleted +0 -46
46 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 3/4 vt8500: Fix header in mach-vt8500/timer.c
In reply to Tony PriskCorrect filename reference in file header.
--- arch/arm/mach-vt8500/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-vt8500/timer.c +1 -1
@@ -1,5 +1,5 @@/* -* arch/arm/mach-vt8500/timer_dt.c +* arch/arm/mach-vt8500/timer.c * * Copyright (C) 2012 Tony Prisk <[email protected]> * Copyright (C) 2010 Alexey Charkov <[email protected]>
Signature · 1 line
1.7.9.5
PATCH 4/4 vt8500: Fix build warning when no framebuffer selected
In reply to Tony PriskCheck for framebuffer defines before declaring variables in vt8500.c Removes a compile-time warning about unused variables.
--- arch/arm/mach-vt8500/vt8500.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/mach-vt8500/vt8500.c +4 -1
@@ -75,8 +75,11 @@ static void vt8500_power_off(void)void __init vt8500_init (void ) { -struct device_node *np, *fb; +struct device_node *np; +#if defined(CONFIG_FB_VT8500 ) || defined(CONFIG_FB_WM8505 ) +struct device_node *fb;void __iomem *gpio_base; +#endif #ifdef CONFIG_FB_VT8500 fb =of_find_compatible_node (NULL ,NULL ,"via,vt8500-fb" );
Signature · 1 line
1.7.9.5
cover arm-soc: vt8500: Cleanup patches for 3.7
In reply to Tony PriskQuoted 7 lines · Tony Prisk
Minor cleanup patches for 3.7.
Tony Prisk (4):
vt8500: Remove unused headers frominclude/mach/
vt8500: Removearm/boot/compressed/head-vt8500.S
vt8500: Fix header inmach-vt8500/timer.c
vt8500: Fix build warning when no framebuffer selected
Hi Tony,
The patches all look good, but they are late for 3.7 now. I would still take the last one since that fixes a build warning, and the separate patch that adds the .dtb files to the Makefile, but leave the other ones for 3.8, unless there is a strong reason to still include them.
Arnd
cover arm-soc: vt8500: Cleanup patches for 3.7
Quoted 9 lines · Arnd Bergmann
Quoted 7 lines · Tony Prisk
Minor cleanup patches for 3.7.
Tony Prisk (4):
vt8500: Remove unused headers frominclude/mach/
vt8500: Removearm/boot/compressed/head-vt8500.S
vt8500: Fix header inmach-vt8500/timer.c
vt8500: Fix build warning when no framebuffer selected
Quoted 7 lines
Hi Tony,
The patches all look good, but they are late for 3.7 now. I would still take the last one since that fixes a build warning, and the separate patch that adds the .dtb files to the
Makefile, but leave the other ones for 3.8, unless there is a strong reason to still include them.
Yep, agreed. I applied the last one to fixes and will include it in the next pull. The rest we can bring in once -rc1 is out and we start staging branches for 3.8.
Thanks Tony!
-Olof
cover arm-soc: vt8500: Cleanup patches for 3.7
In reply to Arnd BergmannQuoted 17 lines · Arnd Bergmann
Quoted 7 lines · Tony Prisk
Minor cleanup patches for 3.7.
Tony Prisk (4):
vt8500: Remove unused headers frominclude/mach/
vt8500: Removearm/boot/compressed/head-vt8500.S
vt8500: Fix header inmach-vt8500/timer.c
vt8500: Fix build warning when no framebuffer selectedHi Tony,
The patches all look good, but they are late for 3.7 now. I would still take the last one since that fixes a build warning, and the separate patch that adds the .dtb files to the
Makefile, but leave the other ones for 3.8, unless there is a strong reason to still include them.
Quoted 6 lines
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Just to clarify,
Is it only bug-fixes, not cleanup that are being accepted during the merge-window?
Regards
Tony P
cover arm-soc: vt8500: Cleanup patches for 3.7
Quoted 25 lines · Tony Prisk
Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Tony Prisk
Minor cleanup patches for 3.7.
Tony Prisk (4):
vt8500: Remove unused headers frominclude/mach/
vt8500: Removearm/boot/compressed/head-vt8500.S
vt8500: Fix header inmach-vt8500/timer.c
vt8500: Fix build warning when no framebuffer selectedHi Tony,
The patches all look good, but they are late for 3.7 now. I would still take the last one since that fixes a build warning, and the separate patch that adds the .dtb files to the
Makefile, but leave the other ones for 3.8, unless there is a strong reason to still include them.Quoted 6 lines
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines
Just to clarify,
Is it only bug-fixes, not cleanup that are being accepted during the merge-window?
During the merge window, code goes in from the maintainer trees into Linus' tree. So code you want included in the next merge window should be in arm-soc before the window starts. So per definition, if you send _us_ code during the merge window then yes, it should be bugfixes.
Bugfixes can go in through the rest of the release cycle. As we go further down the -rcs, we will get pickier on what bugfixes we let in, but during the first rc or so, we're a bit more flexible. After that, mostly regression fixes, etc -- if something has been broken for two years, there's no urgent need to get it into the very last -rc in many cases, for example.
-Olof