package: Recommend virtual-locale-*, don't depend on it

PATCH In review Richard Purdie 2 participants 2 messages Oct 8, 2012 – Oct 10, 2012

Share & tools

Richard Purdie

author

2012-10-08 16:02 UTC #0 lore raw

PATCH 1/1 package: Recommend virtual-locale-*, don't depend on it

The virtual-locale-* packages are provided by libc which may or may not have a matching locale for any given recipes's provided locales. Certainly, we shouldn't get a failure if the locale package isn't available.

This patch therefore makes the dependency optional rather than required, allowing the locale packages in question to install. This resolves errors like:

virtual-locale-eo is needed by bash-locale-eo-4.2-r5.i586 virtual-locale-en+boldquot is needed by bash-locale-en+boldquot-4.2-r5.i586 virtual-locale-en+quot is needed by bash-locale-en+quot-4.2-r5.i586

Signed-off-by Richard Purdie <[email protected]>

---

meta/classes/package.bbclass +1 -1

index 73c4358..0300277 100644
@@ -451,7 +451,7 @@ python package_do_split_locales() {
         pkg = pn + '-locale-' + ln
         packages.append(pkg)
         d.setVar('FILES_' + pkg, os.path.join(datadir, 'locale', l))
-        d.setVar('RDEPENDS_' + pkg, '%s%svirtual-locale-%s' % (pndep, mlprefix, ln))
+        d.setVar('RRECOMMENDS_' + pkg, '%s%svirtual-locale-%s' % (pndep, mlprefix, ln))
         d.setVar('RPROVIDES_' + pkg, '%s-locale %s%s-translation' % (pn, mlprefix, ln))
         d.setVar('SUMMARY_' + pkg, '%s - %s translations' % (summary, l))
         d.setVar('DESCRIPTION_' + pkg, '%s  This package contains language translation files for the %s locale.' % (description, l))

Chris Larson

2012-10-10 14:58 UTC #1 lore raw

Quoted 9 lines · Richard Purdie

The virtual-locale-* packages are provided by libc which may or may not have a matching locale for any given recipes's provided locales. Certainly, we shouldn't get a failure if the locale package isn't available.
This patch therefore makes the dependency optional rather than required, allowing the locale packages in question to install. This resolves errors like:

Quoted 5 lines

virtual-locale-eo is needed by bash-locale-eo-4.2-r5.i586 virtual-locale-en+boldquot is needed by bash-locale-en+boldquot-4.2-r5.i586 virtual-locale-en+quot is needed by bash-locale-en+quot-4.2-r5.i586
Signed-off-by Richard Purdie <[email protected]>

This looks helpful -- I know of at least one person internal at Mentor being bit by this.

Signature · 1 line

Christopher Larson