Skip to contentSkip to conversation

ds3000: add module parameter to force firmware upload

git:v4l-dvb/for_v3.7 Rémi Cardona 2 participants 2 messages Oct 8, 2012 – Oct 9, 2012 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

There's indeed a conflict since (as far as I can tell) only patch #6 of a 7 patch series was applied.

The entire patch series is:
- http://patchwork.linuxtv.org/patch/14752/
- http://patchwork.linuxtv.org/patch/14749/
- http://patchwork.linuxtv.org/patch/14753/
- http://patchwork.linuxtv.org/patch/14750/
- http://patchwork.linuxtv.org/patch/14751/
- http://patchwork.linuxtv.org/patch/14747/ (which is somewhat applied)
- http://patchwork.linuxtv.org/patch/14748/

Maybe it would be safer to revert patch #6 to cleanly reapply the entire series?

As for the "force firmware load" patch, the reason for that patch was that some cards report already having a firmware (despite having been powered off for a while) when in fact they don't. Reloading the ds3000 module with this new option allows those cards to work properly. Out of the thousand S470/471 cards we have in production, only a tiny fraction require this option. That's why I didn't change the default behavior.

Cheers,

Rémi Cardona

#1 lore raw

Em Mon, 08 Oct 2012 21:23:44 +0200
Rémi Cardona <[email protected]> escreveu:

Quoted 14 lines

Hi Mauro,

There's indeed a conflict since (as far as I can tell) only patch #6 of a 7 patch series was applied.

The entire patch series is:
- http://patchwork.linuxtv.org/patch/14752/
- http://patchwork.linuxtv.org/patch/14749/
- http://patchwork.linuxtv.org/patch/14753/
- http://patchwork.linuxtv.org/patch/14750/
- http://patchwork.linuxtv.org/patch/14751/
- http://patchwork.linuxtv.org/patch/14747/ (which is somewhat applied)
- http://patchwork.linuxtv.org/patch/14748/

Quoted 2 lines

Maybe it would be safer to revert patch #6 to cleanly reapply the entire series?

This patch is independent of the other stuff. I don't see a good reason to revert it.

I'm keeping most of the patches for ds3000 in hold, as this driver should be broken into two separate drivers. I provided already a feedback on the patch series that splits this driver. So, I'm waiting for his new patchset. Only after that change, I'll be handling other patches for ds3000, as it will make easier to review and understand this driver.

Quoted 6 lines

As for the "force firmware load" patch, the reason for that patch was that some cards report already having a firmware (despite having been powered off for a while) when in fact they don't. Reloading the ds3000 module with this new option allows those cards to work properly. Out of the thousand S470/471 cards we have in production, only a tiny fraction require this option. That's why I didn't change the default behavior.

Wouldn't be better then to add it at the boards configuration, instead of using a modprobe parameter?

Regards,
Mauro