Skip to contentSkip to conversation

fix path in perl @INC

PATCH In review Kang Kai 3 participants 6 messages Oct 9, 2012 – Oct 10, 2012

lore
Share & tools
lore

Kang Kai

author
#0 lore raw

cover fix path in perl @INC

The following changes since commit eb8ac50d58575be3e04c4decc5b0e2d80381be9b:

documentation: dev-manual - mentioned SRC_URI in the kernel example (2012-10-07 13:15:37 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib kangkai/distro
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro

Kang Kai (1):
perl: fix @INC

 meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 1/1 perl: fix @INC

perl @INC path includes native perl modules path. When run "perl -V", the output at the end is something like:
@INC:

    /etc/perl
    /usr/lib/perl/site_perl/5.14.2/
    /usr/lib/perl/site_perl/5.14.2
    /usr/lib/perl/vendor_perl/5.14.2/
    /usr/lib/perl/vendor_perl/5.14.2
    /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
    /usr/lib/perl/5.14.2
    /usr/local/lib/site_perl
    /usr/lib/perl/5.14.2
    .

And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. Because the native path is compiled into libperl.so that sed in perl_package_preprocess() could NOT remove it. So revert the commit.

[Yocto #3099]

Signed-off-by Kang Kai <[email protected]>
---
 meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/perl/perl-5.14.2/config.sh +1 -1
index 0d4ca1c..dbfabb5 100644
@@ -68,7 +68,7 @@ api_version='14'
 api_versionstring='5.14.0'
 ar='ar'
 archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
-archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
+archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
 archname64=''
 archname='@ARCH@-thread-multi'
 archobjs=''
Signature · 1 line
1.7.5.4
#2 lore raw

Re: [PATCH 1/1] perl: fix @INC

Quoted 30 lines · Kang Kai

perl @INC path includes native perl modules path. When run "perl -V", the output at the end is something like:
@INC:

    /etc/perl
    /usr/lib/perl/site_perl/5.14.2/
    /usr/lib/perl/site_perl/5.14.2
    /usr/lib/perl/vendor_perl/5.14.2/
    /usr/lib/perl/vendor_perl/5.14.2
    /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
    /usr/lib/perl/5.14.2
    /usr/local/lib/site_perl
    /usr/lib/perl/5.14.2
    .

And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. Because the native path is compiled into libperl.so that sed in perl_package_preprocess() could NOT remove it. So revert the commit.

[Yocto #3099]

Signed-off-by Kang Kai <[email protected]>
---
 meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/perl/perl-5.14.2/config.sh +0 -0
index 0d4ca1c..dbfabb5 100644

meta/recipes-devtools/perl/perl-5.14.2/config.sh api_version='14' · line 74

Quoted 8 lines
meta/recipes-devtools/perl/perl-5.14.2/config.sh +1 -1
@@ -68,7 +68,7 @@ api_version='14'
 api_versionstring='5.14.0'
 ar='ar'
 archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
-archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
+archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
 archname64=''
 archname='@ARCH@-thread-multi'
 archobjs=''

I dislike fixing one bug at the expense of breaking another.

Tom,

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4

Any comments on this? How could we test the issue you originally fixed?

Cheers,

Richard

#3 lore raw

Re: [PATCH 1/1] perl: fix @INC

Quoted 42 lines · Richard Purdie
Quoted 30 lines · Kang Kai

perl @INC path includes native perl modules path. When run "perl -V", the output at the end is something like:
@INC:

    /etc/perl
    /usr/lib/perl/site_perl/5.14.2/
    /usr/lib/perl/site_perl/5.14.2
    /usr/lib/perl/vendor_perl/5.14.2/
    /usr/lib/perl/vendor_perl/5.14.2
    /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
    /usr/lib/perl/5.14.2
    /usr/local/lib/site_perl
    /usr/lib/perl/5.14.2
    .

And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. Because the native path is compiled into libperl.so that sed in perl_package_preprocess() could NOT remove it. So revert the commit.

[Yocto #3099]

Signed-off-by Kang Kai <[email protected]>
---
 meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/perl/perl-5.14.2/config.sh +0 -0
index 0d4ca1c..dbfabb5 100644

meta/recipes-devtools/perl/perl-5.14.2/config.sh api_version='14' · line 74

Quoted 8 lines
meta/recipes-devtools/perl/perl-5.14.2/config.sh +1 -1
@@ -68,7 +68,7 @@ api_version='14'
 api_versionstring='5.14.0'
 ar='ar'
 archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
-archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
+archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
 archname64=''
 archname='@ARCH@-thread-multi'
 archobjs=''

I dislike fixing one bug at the expense of breaking another.

Quoted 6 lines

Tom,

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4

Any comments on this? How could we test the issue you originally fixed?

The original purpose of that commit was to allow the perf build to use ExtUtils::Embed to build the Perl language bindings for 'perf script'.

perl_package_preprocess() was (I thought) supposed to prevent the settings in config.sh from making it to the target - I'll have to look into why they do for libperl.so.

Tom

Quoted 9 lines

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH 1/1] perl: fix @INC

Quoted 50 lines · Tom Zanussi
Quoted 42 lines · Richard Purdie
Quoted 30 lines · Kang Kai

perl @INC path includes native perl modules path. When run "perl -V", the output at the end is something like:
@INC:

    /etc/perl
    /usr/lib/perl/site_perl/5.14.2/
    /usr/lib/perl/site_perl/5.14.2
    /usr/lib/perl/vendor_perl/5.14.2/
    /usr/lib/perl/vendor_perl/5.14.2
    /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
    /usr/lib/perl/5.14.2
    /usr/local/lib/site_perl
    /usr/lib/perl/5.14.2
    .

And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. Because the native path is compiled into libperl.so that sed in perl_package_preprocess() could NOT remove it. So revert the commit.

[Yocto #3099]

Signed-off-by Kang Kai <[email protected]>
---
 meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/perl/perl-5.14.2/config.sh +0 -0
index 0d4ca1c..dbfabb5 100644

meta/recipes-devtools/perl/perl-5.14.2/config.sh api_version='14' · line 74

Quoted 8 lines
meta/recipes-devtools/perl/perl-5.14.2/config.sh +1 -1
@@ -68,7 +68,7 @@ api_version='14'
 api_versionstring='5.14.0'
 ar='ar'
 archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
-archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
+archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
 archname64=''
 archname='@ARCH@-thread-multi'
 archobjs=''

I dislike fixing one bug at the expense of breaking another.

Quoted 6 lines

Tom,

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4

Any comments on this? How could we test the issue you originally fixed?

Quoted 7 lines

The original purpose of that commit was to allow the perf build to use ExtUtils::Embed to build the Perl language bindings for 'perf script'.

perl_package_preprocess() was (I thought) supposed to prevent the settings in config.sh from making it to the target - I'll have to look into why they do for libperl.so.

I just submitted a patchset that gets rid of the @INC problem while still allowing perf scripting to work (rather than exiting with a 'scripting not supported' message).

Tom

Quoted 12 lines

Tom

Quoted 9 lines

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

author
#5 lore raw

Re: [PATCH 1/1] perl: fix @INC

Quoted 49 lines · Tom Zanussi
Quoted 48 lines · Tom Zanussi
Quoted 47 lines · Richard Purdie
Quoted 30 lines · Kang Kai

perl @INC path includes native perl modules path. When run "perl -V", the output at the end is something like:

   @INC:
     /etc/perl
     /usr/lib/perl/site_perl/5.14.2/
     /usr/lib/perl/site_perl/5.14.2
     /usr/lib/perl/vendor_perl/5.14.2/
     /usr/lib/perl/vendor_perl/5.14.2
     /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
     /usr/lib/perl/5.14.2
     /usr/local/lib/site_perl
     /usr/lib/perl/5.14.2
     .

And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. Because the native path is compiled into libperl.so that sed in perl_package_preprocess() could NOT remove it. So revert the commit.

[Yocto #3099]

Signed-off-by Kang Kai<[email protected]>
---
  meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/perl/perl-5.14.2/config.sh +0 -0
index 0d4ca1c..dbfabb5 100644

meta/recipes-devtools/perl/perl-5.14.2/config.sh api_version='14' · line 74

Quoted 8 lines
meta/recipes-devtools/perl/perl-5.14.2/config.sh +1 -1
@@ -68,7 +68,7 @@ api_version='14'
  api_versionstring='5.14.0'
  ar='ar'
  archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
-archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
+archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
  archname64=''
  archname='@ARCH@-thread-multi'
  archobjs=''

I dislike fixing one bug at the expense of breaking another.

Tom,

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4

Any comments on this? How could we test the issue you originally fixed?

Quoted 7 lines
Quoted 7 lines

The original purpose of that commit was to allow the perf build to use ExtUtils::Embed to build the Perl language bindings for 'perf script'.

perl_package_preprocess() was (I thought) supposed to prevent the settings in config.sh from making it to the target - I'll have to look into why they do for libperl.so.

Hi Tom,

Thanks.

Quoted 3 lines

I just submitted a patchset that gets rid of the @INC problem while still allowing perf scripting to work (rather than exiting with a 'scripting not supported' message).

I'll test perl with your patch.

Regards,
Kai

Quoted 16 lines

Tom

Quoted 11 lines

Tom

Quoted 9 lines

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core