Skip to contentSkip to conversation

backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths

PATCH In review Axel Lin 2 participants 2 messages Oct 11, 2012 – Oct 12, 2012

Subsystems (2)
Framebuffer layer Backlight class/subsystem
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths

Signed-off-by Axel Lin <[email protected]>
---
 drivers/video/backlight/lm3639_bl.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/lm3639_bl.c +2 -2
index c6915c6..585949b 100644
@@ -206,11 +206,11 @@ static ssize_t lm3639_bled_mode_store(struct device *dev,
 
 out:
 	dev_err(pchip->dev, "%s:i2c access fail to register\n", __func__);
-	return size;
+	return ret;
 
 out_input:
 	dev_err(pchip->dev, "%s:input conversion fail\n", __func__);
-	return size;
+	return ret;
 
 }
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw

2012년 10월 11일 14:11, Axel Lin 쓴 글:

Quoted 13 lines
Signed-off-by Axel Lin <[email protected]>
---
  drivers/video/backlight/lm3639_bl.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/lm3639_bl.c +0 -0
index c6915c6..585949b 100644
@@ -206,11 +206,11 @@ static ssize_t lm3639_bled_mode_store(struct device *dev,
 
  out:
  	dev_err(pchip->dev, "%s:i2c access fail to register\n", __func__);

drivers/video/backlight/lm3639_bl.c static ssize_t lm3639_bled_mode_store(struct device *dev, · line 216

Quoted 10 lines
drivers/video/backlight/lm3639_bl.c +2 -2
-	return size;
+	return ret;
 
  out_input:
  	dev_err(pchip->dev, "%s:input conversion fail\n", __func__);
-	return size;
+	return ret;
 
  }

Thank you Alex for fixing code.

Acked-by G.Shark Jeong<[email protected]>