Skip to contentSkip to conversation

dtb: fix interrupt assignment for ehci/uhci on wm8505

PATCH New Tony Prisk 2 participants 3 messages Oct 13, 2012 – Oct 16, 2012 Device tree bindings

lore
Share & tools
lore

Tony Prisk

author
#0 lore raw

PATCH 1/1 dtb: fix interrupt assignment for ehci/uhci on wm8505

EHCI and UHCI devices in wm8505.dtsi should use IRQ 0 & 1 respectively - not 43 as used on newer models.

Signed-off-by Tony Prisk <[email protected]>
---
 arch/arm/boot/dts/wm8505.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/wm8505.dtsi +2 -2
index b459691..330f833 100644
@@ -71,13 +71,13 @@
 		ehci at d8007100 {
 			compatible = "via,vt8500-ehci";
 			reg = <0xd8007100 0x200>;
-			interrupts = <43>;
+			interrupts = <1>;
 		};
 
 		uhci at d8007300 {
 			compatible = "platform-uhci";
 			reg = <0xd8007300 0x200>;
-			interrupts = <43>;
+			interrupts = <0>;
 		};
 
 		fb at d8050800 {
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 dtb: fix interrupt assignment for ehci/uhci on wm8505

Quoted 2 lines · Tony Prisk

EHCI and UHCI devices in wm8505.dtsi should use IRQ 0 & 1 respectively - not 43 as used on newer models.

Oops - should have been IRQ 1 & 0 - fixed locally.

Quoted 16 lines
Signed-off-by Tony Prisk <[email protected]>
---
 arch/arm/boot/dts/wm8505.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/wm8505.dtsi +1 -1
index b459691..330f833 100644
@@ -71,13 +71,13 @@
 		ehci at d8007100 {
 			compatible = "via,vt8500-ehci";
 			reg = <0xd8007100 0x200>;
-			interrupts = <43>;
+			interrupts = <1>;

arch/arm/boot/dts/wm8505.dtsi line 83

Quoted 10 lines
arch/arm/boot/dts/wm8505.dtsi +1 -1
 		};
 
 		uhci at d8007300 {
 			compatible = "platform-uhci";
 			reg = <0xd8007300 0x200>;
-			interrupts = <43>;
+			interrupts = <0>;
 		};
 
 		fb at d8050800 {

I assume the usb subsystem doesn't fault when IRQ's aren't recieved as this did give any error messages, it just made the USB extremely slow - like it was timing-out between requests.

Regards
Tony P

Applied
#2 lore raw

PATCH 1/1 dtb: fix interrupt assignment for ehci/uhci on wm8505

Quoted 7 lines · Tony Prisk
Quoted 2 lines · Tony Prisk

EHCI and UHCI devices in wm8505.dtsi should use IRQ 0 & 1 respectively - not 43 as used on newer models.

Oops - should have been IRQ 1 & 0 - fixed locally.

Quoted 2 lines
Signed-off-by Tony Prisk <[email protected]>

Applied to fixes with the commit message edited as above.

Thanks,

-Olof