Skip to contentSkip to conversation

ntp updates

PATCH In review Morgan Little 5 participants 27 messages Oct 23, 2012 – Nov 10, 2012

lore
Share & tools
lore
#0 lore raw

v2 cover ntp updates

are available in the git repository at:

[email protected]:morganlittle/meta-oe.git ntp

Morgan Little (3):
ntp: Move from meta-oe to meta-networking
ntp: Uprev from 4.2.6p3 to 4.2.6p5
ntp: Clean up recipes

 .../recipes-support/ntp/files/ntp                  |    0
 .../ntp/files/ntp-4.2.4_p6-nano.patch              |    0
 .../recipes-support/ntp/files/ntp.conf             |    0
 .../recipes-support/ntp/files/ntpd                 |    0
 .../recipes-support/ntp/files/ntpdate              |    0
 .../recipes-support/ntp/files/tickadj.c.patch      |    0
 .../recipes-support/ntp/ntp-ssl_4.2.6p5.bb         |   10 +++
 meta-networking/recipes-support/ntp/ntp.inc        |   74 ++++++++++++++++++++
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb |    4 +
 meta-oe/recipes-support/ntp/ntp-ssl_4.2.6p3.bb     |   11 ---
 meta-oe/recipes-support/ntp/ntp.inc                |   35 ---------
 meta-oe/recipes-support/ntp/ntp_4.2.6p3.bb         |   47 ------------
 12 files changed, 88 insertions(+), 93 deletions(-)
 rename {meta-oe => meta-networking}/recipes-support/ntp/files/ntp (100%)
 rename {meta-oe => meta-networking}/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch (100%)
 rename {meta-oe => meta-networking}/recipes-support/ntp/files/ntp.conf (100%)
 rename {meta-oe => meta-networking}/recipes-support/ntp/files/ntpd (100%)
 rename {meta-oe => meta-networking}/recipes-support/ntp/files/ntpdate (100%)
 rename {meta-oe => meta-networking}/recipes-support/ntp/files/tickadj.c.patch (100%)
 create mode 100644 meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p5.bb
 create mode 100644 meta-networking/recipes-support/ntp/ntp.inc
 create mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
 delete mode 100644 meta-oe/recipes-support/ntp/ntp-ssl_4.2.6p3.bb
 delete mode 100644 meta-oe/recipes-support/ntp/ntp.inc
 delete mode 100644 meta-oe/recipes-support/ntp/ntp_4.2.6p3.bb
#1 lore raw

PATCH v2 1/3 ntp: Move from meta-oe to meta-networking

---
 meta-networking/recipes-support/ntp/files/ntp      |   31 ++++++++++
 .../ntp/files/ntp-4.2.4_p6-nano.patch              |   17 +++++
 meta-networking/recipes-support/ntp/files/ntp.conf |   14 +++++
 meta-networking/recipes-support/ntp/files/ntpd     |   62 ++++++++++++++++++++
 meta-networking/recipes-support/ntp/files/ntpdate  |   49 +++++++++++++++
 .../recipes-support/ntp/files/tickadj.c.patch      |   32 ++++++++++
 .../recipes-support/ntp/ntp-ssl_4.2.6p3.bb         |   11 ++++
 meta-networking/recipes-support/ntp/ntp.inc        |   35 +++++++++++
 meta-networking/recipes-support/ntp/ntp_4.2.6p3.bb |   47 +++++++++++++++
 meta-oe/recipes-support/ntp/files/ntp              |   31 ----------
 .../ntp/files/ntp-4.2.4_p6-nano.patch              |   17 -----
 meta-oe/recipes-support/ntp/files/ntp.conf         |   14 -----
 meta-oe/recipes-support/ntp/files/ntpd             |   62 --------------------
 meta-oe/recipes-support/ntp/files/ntpdate          |   49 ---------------
 meta-oe/recipes-support/ntp/files/tickadj.c.patch  |   32 ----------
 meta-oe/recipes-support/ntp/ntp-ssl_4.2.6p3.bb     |   11 ----
 meta-oe/recipes-support/ntp/ntp.inc                |   35 -----------
 meta-oe/recipes-support/ntp/ntp_4.2.6p3.bb         |   47 ---------------
 18 files changed, 298 insertions(+), 298 deletions(-)
 create mode 100755 meta-networking/recipes-support/ntp/files/ntp
 create mode 100644 meta-networking/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch
 create mode 100644 meta-networking/recipes-support/ntp/files/ntp.conf
 create mode 100755 meta-networking/recipes-support/ntp/files/ntpd
 create mode 100755 meta-networking/recipes-support/ntp/files/ntpdate
 create mode 100644 meta-networking/recipes-support/ntp/files/tickadj.c.patch
 create mode 100644 meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p3.bb
 create mode 100644 meta-networking/recipes-support/ntp/ntp.inc
 create mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p3.bb
 delete mode 100755 meta-oe/recipes-support/ntp/files/ntp
 delete mode 100644 meta-oe/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch
 delete mode 100644 meta-oe/recipes-support/ntp/files/ntp.conf
 delete mode 100755 meta-oe/recipes-support/ntp/files/ntpd
 delete mode 100755 meta-oe/recipes-support/ntp/files/ntpdate
 delete mode 100644 meta-oe/recipes-support/ntp/files/tickadj.c.patch
 delete mode 100644 meta-oe/recipes-support/ntp/ntp-ssl_4.2.6p3.bb
 delete mode 100644 meta-oe/recipes-support/ntp/ntp.inc
 delete mode 100644 meta-oe/recipes-support/ntp/ntp_4.2.6p3.bb
meta-networking/recipes-support/ntp/files/ntp new file +31 -0
new file mode 100755
index 0000000..e91a528
@@ -0,0 +1,31 @@
+#! /bin/sh
+
+FLAGS="defaults 23"
+
+test -f /usr/bin/ntpd || exit 0
+
+case "$1" in
+	start)
+		echo -n "Starting NTP server: ntpd"
+  		start-stop-daemon --start --quiet --exec /usr/bin/ntpd
+		echo "."
+  		;;
+	stop)
+		echo -n "Stopping NTP server: ntpd"
+  		start-stop-daemon --stop --quiet --exec /usr/bin/ntpd
+		echo "."
+  		;;
+	restart|force-reload)
+		echo -n "Restarting NTP server: ntpd... "
+  		start-stop-daemon --stop --quiet --exec /usr/bin/ntpd
+  		sleep 2
+  		start-stop-daemon --start --quiet --exec /usr/bin/ntpd
+		echo "done."
+  		;;
+	*)
+  		echo "Usage: /etc/init.d/ntp {start|stop|restart|force-reload}"
+  		exit 1
+		;;
+esac
+
+exit 0
meta-networking/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch new file +17 -0
new file mode 100644
index 0000000..cb1e2f7
@@ -0,0 +1,17 @@
+--- a/include/ntp_syscall.h.orig	2009-05-19 16:44:55.048156467 -0400
++++ b/include/ntp_syscall.h	2009-05-19 16:46:19.293323686 -0400
+@@ -14,6 +14,14 @@
+ # include <sys/timex.h>
+ #endif
+ 
++#if defined(ADJ_NANO) && !defined(MOD_NANO)
++#define MOD_NANO ADJ_NANO
++#endif
++
++#if defined(ADJ_TAI) && !defined(MOD_TAI)
++#define MOD_TAI ADJ_TAI
++#endif
++
+ #ifndef NTP_SYSCALLS_LIBC
+ #ifdef NTP_SYSCALLS_STD
+ # define ntp_adjtime(t)		syscall(SYS_ntp_adjtime, (t))
meta-networking/recipes-support/ntp/files/ntp.conf new file +14 -0
new file mode 100644
index 0000000..bf52440
@@ -0,0 +1,14 @@
+# This is the most basic ntp configuration file
+# The driftfile must remain in a place specific to this
+# machine - it records the machine specific clock error
+driftfile /etc/ntp.drift
+# This obtains a random server which will be close
+# (in IP terms) to the machine.  Add other servers
+# as required, or change this.
+server pool.ntp.org
+# Using local hardware clock as fallback
+# Disable this when using ntpd -q -g -x as ntpdate or it will sync to itself
+server 127.127.1.0
+fudge 127.127.1.0 stratum 14
+# Defining a default security setting
+restrict default
meta-networking/recipes-support/ntp/files/ntpd new file +62 -0

62 lines not on this page · raw message

meta-networking/recipes-support/ntp/files/ntpdate new file +49 -0

49 lines not on this page · raw message

meta-networking/recipes-support/ntp/files/tickadj.c.patch new file +32 -0
new file mode 100644
index 0000000..9ef9de9
@@ -0,0 +1,32 @@
+Index: ntp-4.2.2p3-r0/ntp-4.2.2p3/util/tickadj.c
+===================================================================
+--- ntp-4.2.2p3/util/tickadj.c	2004-02-25 06:58:33.000000000 +0100
++++ ntp-4.2.2p3/util/tickadj.c	2007-07-07 01:00:54.000000000 +0200
+@@ -21,7 +21,8 @@
+ # include <unistd.h>
+ #endif /* HAVE_UNISTD_H */
+ 
+-#ifdef HAVE___ADJTIMEX		/* Linux */
++/* proper handling here has been moved to upstream ntp bugzilla */
++#ifdef linux
+ 
+ #include <sys/timex.h>
+ struct timex txc;
+@@ -91,7 +92,7 @@
+ 	}
+ 
+ 	if (!errflg) {
+-		if (__adjtimex(&txc) < 0)
++		if (adjtimex(&txc) < 0)
+ 			perror("adjtimex");
+ 		else if (!quiet)
+ 			printf("tick     = %ld\ntick_adj = %d\n",
+@@ -146,7 +147,7 @@
+ #endif
+ 	}
+     
+-	if (__adjtimex(&txc) < 0)
++	if (adjtimex(&txc) < 0)
+ 	{
+ 		perror("adjtimex");
+ 	}
meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p3.bb new file +11 -0
new file mode 100644
index 0000000..a158990
@@ -0,0 +1,11 @@
+require ntp_${PV}.bb
+DEPENDS = "openssl"
+
+S = "${WORKDIR}/ntp-${PV}"
+
+EXTRA_OECONF = "--with-openssl-libdir=${STAGING_LIBDIR} \
+	        --with-openssl-incdir=${STAGING_INCDIR}/openssl"
+
+
+SRC_URI[md5sum] = "98e16c7aa4ecd4c004b51bff18962e95"
+SRC_URI[sha256sum] = "9f4a5271a285d390c9225e3ea28f70049ea377d30fc6de4659007cfff278671a"
meta-networking/recipes-support/ntp/ntp.inc new file +35 -0
new file mode 100644
index 0000000..1d740f0
@@ -0,0 +1,35 @@
+DESCRIPTION = "The Network Time Protocol (NTP) is used to \
+synchronize the time of a computer client or server to \
+another server or reference time source, such as a radio \
+or satellite receiver or modem."
+HOMEPAGE = "http://ntp.isc.org/bin/view/Main/WebHome"
+SECTION = "console/network"
+LICENSE = "ntp"
+LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=fea4b50c33b18c2194b4b1c9ca512670"
+RSUGGESTS_${PN} = "iana-etc"
+
+SRC_URI = "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/${P}.tar.gz \
+	file://ipv6only-workaround.patch \
+	file://ntpd \
+	file://ntp.conf \
+	file://ntpdate \
+	file://ntpd.service \
+"
+
+inherit autotools update-rc.d
+
+INITSCRIPT_NAME = "ntpd"
+# No dependencies, so just go in at the standard level (20)
+INITSCRIPT_PARAMS = "defaults"
+
+# The ac_cv_header_readline_history is to stop ntpdc depending on either
+# readline or curses
+EXTRA_OECONF = "--without-openssl --without-crypto ac_cv_header_readline_history_h=no"
+CFLAGS_append = " -DPTYS_ARE_GETPT -DPTYS_ARE_SEARCHED"
+
+PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"
+# NOTE: you don't need ntpdate, use "ntpd -q -g -x"
+# or the ntpdate systemd service
+
+# This should use rc.update
+FILES_ntpdate = "${bindir}/ntpdate ${sysconfdir}/init.d/ntpdate"
meta-networking/recipes-support/ntp/ntp_4.2.6p3.bb new file +47 -0

47 lines not on this page · raw message

meta-oe/recipes-support/ntp/files/ntp deleted +0 -31
deleted file mode 100755
index e91a528..0000000
@@ -1,31 +0,0 @@
-#! /bin/sh
-
-FLAGS="defaults 23"
-
-test -f /usr/bin/ntpd || exit 0
-
-case "$1" in
-	start)
-		echo -n "Starting NTP server: ntpd"
-  		start-stop-daemon --start --quiet --exec /usr/bin/ntpd
-		echo "."
-  		;;
-	stop)
-		echo -n "Stopping NTP server: ntpd"
-  		start-stop-daemon --stop --quiet --exec /usr/bin/ntpd
-		echo "."
-  		;;
-	restart|force-reload)
-		echo -n "Restarting NTP server: ntpd... "
-  		start-stop-daemon --stop --quiet --exec /usr/bin/ntpd
-  		sleep 2
-  		start-stop-daemon --start --quiet --exec /usr/bin/ntpd
-		echo "done."
-  		;;
-	*)
-  		echo "Usage: /etc/init.d/ntp {start|stop|restart|force-reload}"
-  		exit 1
-		;;
-esac
-
-exit 0
meta-oe/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch deleted +0 -17
deleted file mode 100644
index cb1e2f7..0000000
@@ -1,17 +0,0 @@
---- a/include/ntp_syscall.h.orig	2009-05-19 16:44:55.048156467 -0400
-+++ b/include/ntp_syscall.h	2009-05-19 16:46:19.293323686 -0400
-@@ -14,6 +14,14 @@
- # include <sys/timex.h>
- #endif
- 
-+#if defined(ADJ_NANO) && !defined(MOD_NANO)
-+#define MOD_NANO ADJ_NANO
-+#endif
-+
-+#if defined(ADJ_TAI) && !defined(MOD_TAI)
-+#define MOD_TAI ADJ_TAI
-+#endif
-+
- #ifndef NTP_SYSCALLS_LIBC
- #ifdef NTP_SYSCALLS_STD
- # define ntp_adjtime(t)		syscall(SYS_ntp_adjtime, (t))
meta-oe/recipes-support/ntp/files/ntp.conf deleted +0 -14
deleted file mode 100644
index bf52440..0000000
@@ -1,14 +0,0 @@
-# This is the most basic ntp configuration file
-# The driftfile must remain in a place specific to this
-# machine - it records the machine specific clock error
-driftfile /etc/ntp.drift
-# This obtains a random server which will be close
-# (in IP terms) to the machine.  Add other servers
-# as required, or change this.
-server pool.ntp.org
-# Using local hardware clock as fallback
-# Disable this when using ntpd -q -g -x as ntpdate or it will sync to itself
-server 127.127.1.0
-fudge 127.127.1.0 stratum 14
-# Defining a default security setting
-restrict default
meta-oe/recipes-support/ntp/files/ntpd deleted +0 -62

62 lines not on this page · raw message

meta-oe/recipes-support/ntp/files/ntpdate deleted +0 -49

49 lines not on this page · raw message

meta-oe/recipes-support/ntp/files/tickadj.c.patch deleted +0 -32
deleted file mode 100644
index 9ef9de9..0000000
@@ -1,32 +0,0 @@
-Index: ntp-4.2.2p3-r0/ntp-4.2.2p3/util/tickadj.c
-===================================================================
---- ntp-4.2.2p3/util/tickadj.c	2004-02-25 06:58:33.000000000 +0100
-+++ ntp-4.2.2p3/util/tickadj.c	2007-07-07 01:00:54.000000000 +0200
-@@ -21,7 +21,8 @@
- # include <unistd.h>
- #endif /* HAVE_UNISTD_H */
- 
--#ifdef HAVE___ADJTIMEX		/* Linux */
-+/* proper handling here has been moved to upstream ntp bugzilla */
-+#ifdef linux
- 
- #include <sys/timex.h>
- struct timex txc;
-@@ -91,7 +92,7 @@
- 	}
- 
- 	if (!errflg) {
--		if (__adjtimex(&txc) < 0)
-+		if (adjtimex(&txc) < 0)
- 			perror("adjtimex");
- 		else if (!quiet)
- 			printf("tick     = %ld\ntick_adj = %d\n",
-@@ -146,7 +147,7 @@
- #endif
- 	}
-     
--	if (__adjtimex(&txc) < 0)
-+	if (adjtimex(&txc) < 0)
- 	{
- 		perror("adjtimex");
- 	}
meta-oe/recipes-support/ntp/ntp-ssl_4.2.6p3.bb deleted +0 -11
deleted file mode 100644
index a158990..0000000
@@ -1,11 +0,0 @@
-require ntp_${PV}.bb
-DEPENDS = "openssl"
-
-S = "${WORKDIR}/ntp-${PV}"
-
-EXTRA_OECONF = "--with-openssl-libdir=${STAGING_LIBDIR} \
-	        --with-openssl-incdir=${STAGING_INCDIR}/openssl"
-
-
-SRC_URI[md5sum] = "98e16c7aa4ecd4c004b51bff18962e95"
-SRC_URI[sha256sum] = "9f4a5271a285d390c9225e3ea28f70049ea377d30fc6de4659007cfff278671a"
meta-oe/recipes-support/ntp/ntp.inc deleted +0 -35
deleted file mode 100644
index 1d740f0..0000000
@@ -1,35 +0,0 @@
-DESCRIPTION = "The Network Time Protocol (NTP) is used to \
-synchronize the time of a computer client or server to \
-another server or reference time source, such as a radio \
-or satellite receiver or modem."
-HOMEPAGE = "http://ntp.isc.org/bin/view/Main/WebHome"
-SECTION = "console/network"
-LICENSE = "ntp"
-LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=fea4b50c33b18c2194b4b1c9ca512670"
-RSUGGESTS_${PN} = "iana-etc"
-
-SRC_URI = "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/${P}.tar.gz \
-	file://ipv6only-workaround.patch \
-	file://ntpd \
-	file://ntp.conf \
-	file://ntpdate \
-	file://ntpd.service \
-"
-
-inherit autotools update-rc.d
-
-INITSCRIPT_NAME = "ntpd"
-# No dependencies, so just go in at the standard level (20)
-INITSCRIPT_PARAMS = "defaults"
-
-# The ac_cv_header_readline_history is to stop ntpdc depending on either
-# readline or curses
-EXTRA_OECONF = "--without-openssl --without-crypto ac_cv_header_readline_history_h=no"
-CFLAGS_append = " -DPTYS_ARE_GETPT -DPTYS_ARE_SEARCHED"
-
-PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"
-# NOTE: you don't need ntpdate, use "ntpd -q -g -x"
-# or the ntpdate systemd service
-
-# This should use rc.update
-FILES_ntpdate = "${bindir}/ntpdate ${sysconfdir}/init.d/ntpdate"
meta-oe/recipes-support/ntp/ntp_4.2.6p3.bb deleted +0 -47

47 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#2 lore raw

PATCH v2 2/3 ntp: Uprev from 4.2.6p3 to 4.2.6p5

In reply to Morgan Little
---
 .../recipes-support/ntp/ntp-ssl_4.2.6p3.bb         |   11 -----
 .../recipes-support/ntp/ntp-ssl_4.2.6p5.bb         |   11 +++++
 meta-networking/recipes-support/ntp/ntp_4.2.6p3.bb |   47 --------------------
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb |   45 +++++++++++++++++++
 4 files changed, 56 insertions(+), 58 deletions(-)
 delete mode 100644 meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p3.bb
 create mode 100644 meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p5.bb
 delete mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p3.bb
 create mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p3.bb deleted +0 -11
deleted file mode 100644
index a158990..0000000
@@ -1,11 +0,0 @@
-require ntp_${PV}.bb
-DEPENDS = "openssl"
-
-S = "${WORKDIR}/ntp-${PV}"
-
-EXTRA_OECONF = "--with-openssl-libdir=${STAGING_LIBDIR} \
-	        --with-openssl-incdir=${STAGING_INCDIR}/openssl"
-
-
-SRC_URI[md5sum] = "98e16c7aa4ecd4c004b51bff18962e95"
-SRC_URI[sha256sum] = "9f4a5271a285d390c9225e3ea28f70049ea377d30fc6de4659007cfff278671a"
meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p5.bb new file +11 -0
new file mode 100644
index 0000000..a158990
@@ -0,0 +1,11 @@
+require ntp_${PV}.bb
+DEPENDS = "openssl"
+
+S = "${WORKDIR}/ntp-${PV}"
+
+EXTRA_OECONF = "--with-openssl-libdir=${STAGING_LIBDIR} \
+	        --with-openssl-incdir=${STAGING_INCDIR}/openssl"
+
+
+SRC_URI[md5sum] = "98e16c7aa4ecd4c004b51bff18962e95"
+SRC_URI[sha256sum] = "9f4a5271a285d390c9225e3ea28f70049ea377d30fc6de4659007cfff278671a"
meta-networking/recipes-support/ntp/ntp_4.2.6p3.bb deleted +0 -47

47 lines not on this page · raw message

meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb new file +45 -0

45 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#3 lore raw

PATCH v2 3/3 ntp: Clean up recipes

In reply to Morgan Little

Clean up recipes to make them easier to read and to allow ntp-ssl to build
* Move common portions to ntp.inc
* Update ntp-ssl to require ntp.inc oppose to ntp_${PV}.bb
* Change ntp-ssl EXTRA_OECONF to append so it won't try to configure snmp as
it will use local paths can cause a error while configuring

---
 .../recipes-support/ntp/ntp-ssl_4.2.6p5.bb         |   11 ++--
 meta-networking/recipes-support/ntp/ntp.inc        |   49 ++++++++++++++++++--
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb |   43 +-----------------
 3 files changed, 50 insertions(+), 53 deletions(-)
meta-networking/recipes-support/ntp/ntp-ssl_4.2.6p5.bb +5 -6
index a158990..e5851ae 100644
@@ -1,11 +1,10 @@
-require ntp_${PV}.bb
+require ntp.inc
 DEPENDS = "openssl"
 
 S = "${WORKDIR}/ntp-${PV}"
 
-EXTRA_OECONF = "--with-openssl-libdir=${STAGING_LIBDIR} \
-	        --with-openssl-incdir=${STAGING_INCDIR}/openssl"
+EXTRA_OECONF += "--with-openssl-libdir=${STAGING_LIBDIR} \
+		 --with-openssl-incdir=${STAGING_INCDIR}/openssl \
+		 --with-crypto"
 
-
-SRC_URI[md5sum] = "98e16c7aa4ecd4c004b51bff18962e95"
-SRC_URI[sha256sum] = "9f4a5271a285d390c9225e3ea28f70049ea377d30fc6de4659007cfff278671a"
+FILES_${PN} += "${bindir}/sntp ${bindir}/ntp-keygen"
meta-networking/recipes-support/ntp/ntp.inc +44 -5

70 lines not on this page · raw message

meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb +1 -42

46 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#4 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 1 line · On Tuesday 23 October 2012 12:20:20 Morgan Little wrote:

-PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"

...

Quoted 1 line

+PACKAGES += "${PN}-date ${PN}-bin ${PN}-tickadj ${PN}-utils"

I'm not particularly happy with this change. Apart from the fact that it wasn't mentioned in the commit message, it breaks any recipe that depends upon the previous ntpdate package. Could we go back to the old ntpdate name for the package or at the very least provide an RPROVIDES for the old name? I'm happy to submit a patch to do this once there is agreement either way.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#5 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 4 lines · Paul Eggleton
Quoted 1 line · On Tuesday 23 October 2012 12:20:20 Morgan Little wrote:

-PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"

...

Quoted 1 line

+PACKAGES += "${PN}-date ${PN}-bin ${PN}-tickadj ${PN}-utils"

Quoted 9 lines

I'm not particularly happy with this change. Apart from the fact that it wasn't mentioned in the commit message, it breaks any recipe that depends upon the previous ntpdate package. Could we go back to the old ntpdate name for the package or at the very least provide an RPROVIDES for the old name? I'm happy to submit a patch to do this once there is agreement either way.

Cheers,
Paul

I agree with you. Also find it kind of strange to change from ntpdate to ntp-date, as the universally known name of that module is ntpdate. Don't really see the rational of changing that to ntp-date in the recipe.

- Martin

#6 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 11 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 10 lines · Paul Eggleton
Quoted 1 line · On Tuesday 23 October 2012 12:20:20 Morgan Little wrote:

-PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"

...

Quoted 1 line

+PACKAGES += "${PN}-date ${PN}-bin ${PN}-tickadj ${PN}-utils"

I'm not particularly happy with this change. Apart from the fact that it wasn't mentioned in the commit message, it breaks any recipe that depends upon the previous ntpdate package. Could we go back to the old ntpdate name for the package or at the very least provide an RPROVIDES for the old name? I'm happy to submit a patch to do this once there is agreement either way.

Quoted 7 lines
Quoted 3 lines

Cheers,
Paul

I agree with you. Also find it kind of strange to change from ntpdate to ntp-date, as the universally known name of that module is ntpdate. Don't really see the rational of changing that to ntp-date in the recipe.

Agreed. Though if there's a good reason to rename in ntp-date, that's fine with me, so long as we go with Paul's suggestion of having an RPROVIDES for ntpdate. It's probably best to leave it as ntpdate, though.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#7 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 21 lines · Joe MacDonald
Quoted 11 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 10 lines · Paul Eggleton
Quoted 1 line · On Tuesday 23 October 2012 12:20:20 Morgan Little wrote:

-PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"

...

Quoted 1 line

+PACKAGES += "${PN}-date ${PN}-bin ${PN}-tickadj ${PN}-utils"

I'm not particularly happy with this change. Apart from the fact that it wasn't mentioned in the commit message, it breaks any recipe that depends upon the previous ntpdate package. Could we go back to the old ntpdate name for the package or at the very least provide an RPROVIDES for the old name? I'm happy to submit a patch to do this once there is agreement either way.

Quoted 7 lines
Quoted 3 lines

Cheers,
Paul

I agree with you. Also find it kind of strange to change from ntpdate to ntp-date, as the universally known name of that module is ntpdate. Don't really see the rational of changing that to ntp-date in the recipe.

Quoted 5 lines

Agreed. Though if there's a good reason to rename in ntp-date, that's fine with me, so long as we go with Paul's suggestion of having an RPROVIDES for ntpdate. It's probably best to leave it as ntpdate, though.

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

//Morgan

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#8 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 4 lines · Morgan

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side - rather they were mutually exclusive and the distro would make a choice as to which one was built.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#9 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 10 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 4 lines · Morgan

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side - rather they were mutually exclusive and the distro would make a choice as to which one was built.

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#10 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 25 lines · Joe MacDonald
Quoted 9 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 4 lines · Morgan

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side - rather they were mutually exclusive and the distro would make a choice as to which one was built.

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Are you thinking of ntp providing ntpdate then? In my mind at least, this makes sense, as ntp seems able to do whatever ntpdate does, so I don't really see the rational of having both on the same system.

- Martin

#11 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 25 lines · Joe MacDonald
Quoted 9 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 4 lines · Morgan

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side - rather they were mutually exclusive and the distro would make a choice as to which one was built.

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Quoted 7 lines
Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Are you thinking of ntp providing ntpdate then? In my mind at least, this makes sense, as ntp seems able to do whatever ntpdate does, so I don't really see the rational of having both on the same system.

Yeah, exactly. The only time I've ever wanted both ntp and ntpdate on the same system at the same time was when I had a system with a clock that was so badly damaged occasionally ntp couldn't recover it and I needed to just do a reset on the time. But I could have even accomplished that with ntp -q. In fact, a quick check of the ntp manpage on my system says:

-q Exit the ntpd just after the first time the clock is set.
This behavior mimics that of the ntpdate program, which is to be retired. The -g and -x options can be used with this option. Note: The kernel time discipline is disabled with this option.

So I'm thinking that ntpdate can be completely replaced with ntp if you're putting that on your system. The obvious fallout would be in any scripts specifically relying on something called 'ntpdate', but it looks to me like the ntp package is already providing an ntpdate binary. Seeing that, it seems to me that ntp/ntp-ssl and ntpdate actually conflict with each other.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#12 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 57 lines · Joe MacDonald
Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 25 lines · Joe MacDonald
Quoted 9 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 4 lines · Morgan

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side - rather they were mutually exclusive and the distro would make a choice as to which one was built.

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Quoted 7 lines
Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Are you thinking of ntp providing ntpdate then? In my mind at least, this makes sense, as ntp seems able to do whatever ntpdate does, so I don't really see the rational of having both on the same system.

Yeah, exactly. The only time I've ever wanted both ntp and ntpdate on the same system at the same time was when I had a system with a clock that was so badly damaged occasionally ntp couldn't recover it and I needed to just do a reset on the time. But I could have even accomplished that with ntp -q. In fact, a quick check of the ntp manpage on my system says:

-q Exit the ntpd just after the first time the clock is set.
This behavior mimics that of the ntpdate program, which is to be retired. The -g and -x options can be used with this option. Note: The kernel time discipline is disabled with this option.

So I'm thinking that ntpdate can be completely replaced with ntp if you're putting that on your system. The obvious fallout would be in any scripts specifically relying on something called 'ntpdate', but it looks to me like the ntp package is already providing an ntpdate binary. Seeing that, it seems to me that ntp/ntp-ssl and ntpdate actually conflict with each other.

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Then I agree, and think a nice solution to this would be that ntp provides ntpdate, as we don't want both. If you install ntp, you won't need ntpdate, and if you want ntpdate, you don't need all of ntp, and therefor just install ntpdate, and the same goes of course if what you want is ntp-ssl.

If ntp is actually providing a ntpdate binary, I agree that it should actually conflict, and not only provide ntpdate.

- Martin

#13 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 63 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 57 lines · Joe MacDonald
Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 25 lines · Joe MacDonald
Quoted 9 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 4 lines · Morgan

My rational behind splitting like that is if it is just ntpdate and you try to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side - rather they were mutually exclusive and the distro would make a choice as to which one was built.

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Quoted 7 lines
Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Are you thinking of ntp providing ntpdate then? In my mind at least, this makes sense, as ntp seems able to do whatever ntpdate does, so I don't really see the rational of having both on the same system.

Yeah, exactly. The only time I've ever wanted both ntp and ntpdate on the same system at the same time was when I had a system with a clock that was so badly damaged occasionally ntp couldn't recover it and I needed to just do a reset on the time. But I could have even accomplished that with ntp -q. In fact, a quick check of the ntp manpage on my system says:

-q Exit the ntpd just after the first time the clock is set.
This behavior mimics that of the ntpdate program, which is to be retired. The -g and -x options can be used with this option. Note: The kernel time discipline is disabled with this option.

So I'm thinking that ntpdate can be completely replaced with ntp if you're putting that on your system. The obvious fallout would be in any scripts specifically relying on something called 'ntpdate', but it looks to me like the ntp package is already providing an ntpdate binary. Seeing that, it seems to me that ntp/ntp-ssl and ntpdate actually conflict with each other.

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Quoted 8 lines

Then I agree, and think a nice solution to this would be that ntp provides ntpdate, as we don't want both. If you install ntp, you won't need ntpdate, and if you want ntpdate, you don't need all of ntp, and therefor just install ntpdate, and the same goes of course if what you want is ntp-ssl.

If ntp is actually providing a ntpdate binary, I agree that it should actually conflict, and not only provide ntpdate.

Yep, my thoughts exactly.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#14 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

In reply to Joe MacDonald
Quoted 1 line · On Thursday 01 November 2012 13:32:40 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 14 lines · 12.11.01 (Thu 17:19) Paul Eggleton wrote:
Quoted 8 lines · Morgan
Quoted 6 lines

My rational behind splitting like that is if it is just ntpdate and you try
to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be
change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

Quoted 5 lines

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side -
rather they were mutually exclusive and the distro would make a choice as to which one was built.

Quoted 8 lines

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

I'm not sure that it does. I think the split was made just to avoid bringing in OpenSSL on systems where it was not needed or desired. Phil Blundell (on CC) made the split quite a while ago in OE-Classic - Phil can you comment?

Quoted 2 lines

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Sorry, I don't quite understand what you mean here... ?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#15 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 1 line · On Thursday 01 November 2012 13:32:40 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 14 lines · 12.11.01 (Thu 17:19) Paul Eggleton wrote:
Quoted 8 lines · Morgan
Quoted 6 lines

My rational behind splitting like that is if it is just ntpdate and you try
to add ntp-ssl and ntpdate it will use ntp to provide ntpdate. It could be
change add RPROVIDES so ntp will provide ntpdate and ntp-ssl provides a uniquely named version.

Quoted 5 lines

The ssl version could be ntpdate-ssl if it needs to be unique. I think originally though these recipes weren't intended to be built side-by-side -
rather they were mutually exclusive and the distro would make a choice as to which one was built.

Quoted 8 lines

Hmm, good point.

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

Quoted 8 lines

I'm not sure that it does. I think the split was made just to avoid bringing in OpenSSL on systems where it was not needed or desired. Phil Blundell (on CC) made the split quite a while ago in OE-Classic - Phil can you comment?

Quoted 2 lines

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Sorry, I don't quite understand what you mean here... ?

Sorry about that, I've been interleaving writing and thinking, usually not a good recipe. :-)

It's been so long since I had to actually pay attention to what's in ntp that I'm just getting back clued up on it. I was thinking that it should be made explicit in the ntp recipe that it provides ntpdate and therefore you would never need to have ntpdate and ntp/ntp-ssl installed on the same system at the same time.

So going back to Morgan's thing, I think now that the case of "add ntp-ssl and ntpdate" is invalid, and the result should be using ntp-ssl to provide ntpdate. As long as that's what is happening with his recipe, I'm okay with it. If it's actually dragging in ntp in addition to ntp-ssl purely to provide ntpdate, I think we have a problem. And nothing should result in ntp[-ssl] and ntpdate (as in the things provided by two or more recipes) being on the same system at the same time, since ntp provides ntpdate anyway. At least it looks like it does on my test build.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#16 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 1 line · On Friday 02 November 2012 09:07:43 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 27 lines · 12.11.02 (Fri 09:59) Paul Eggleton wrote:
Quoted 13 lines · On Thursday 01 November 2012 13:32:40 Joe MacDonald wrote:
Quoted 6 lines

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

I'm not sure that it does. I think the split was made just to avoid bringing in OpenSSL on systems where it was not needed or desired. Phil Blundell (on CC) made the split quite a while ago in OE-Classic - Phil can you comment?

Quoted 4 lines
Quoted 2 lines

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Sorry, I don't quite understand what you mean here... ?

Sorry about that, I've been interleaving writing and thinking, usually not a good recipe. :-)

It's been so long since I had to actually pay attention to what's in ntp that I'm just getting back clued up on it. I was thinking that it should be made explicit in the ntp recipe that it provides ntpdate and therefore you would never need to have ntpdate and ntp/ntp-ssl installed on the same system at the same time.

Quoted 9 lines

So going back to Morgan's thing, I think now that the case of "add ntp-ssl and ntpdate" is invalid, and the result should be using ntp-ssl to provide ntpdate. As long as that's what is happening with his recipe, I'm okay with it. If it's actually dragging in ntp in addition to ntp-ssl purely to provide ntpdate, I think we have a problem. And nothing should result in ntp[-ssl] and ntpdate (as in the things provided by two or more recipes) being on the same system at the same time, since ntp provides ntpdate anyway. At least it looks like it does on my test build.

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#17 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 40 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 1 line · On Friday 02 November 2012 09:07:43 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 27 lines · 12.11.02 (Fri 09:59) Paul Eggleton wrote:
Quoted 13 lines · On Thursday 01 November 2012 13:32:40 Joe MacDonald wrote:
Quoted 6 lines

Does it make sense to have both on a system? That is, if you build ntp-ssl does that imply it will only use SSL for communications? If that's not the case (which I suspect it isn't, but I haven't checked myself) then there's not really a strong reason to install both on the same system. Which then seems fine to provide ntpdate-ssl as the alternative.

I'm not sure that it does. I think the split was made just to avoid bringing in OpenSSL on systems where it was not needed or desired. Phil Blundell (on CC) made the split quite a while ago in OE-Classic - Phil can you comment?

Quoted 4 lines
Quoted 2 lines

Now that I think about it a bit more, maybe a RPROVIDES is appropriate since ntp and ntpdate are overlapping in a lot of places.

Sorry, I don't quite understand what you mean here... ?

Sorry about that, I've been interleaving writing and thinking, usually not a good recipe. :-)

It's been so long since I had to actually pay attention to what's in ntp that I'm just getting back clued up on it. I was thinking that it should be made explicit in the ntp recipe that it provides ntpdate and therefore you would never need to have ntpdate and ntp/ntp-ssl installed on the same system at the same time.

Quoted 9 lines

So going back to Morgan's thing, I think now that the case of "add ntp-ssl and ntpdate" is invalid, and the result should be using ntp-ssl to provide ntpdate. As long as that's what is happening with his recipe, I'm okay with it. If it's actually dragging in ntp in addition to ntp-ssl purely to provide ntpdate, I think we have a problem. And nothing should result in ntp[-ssl] and ntpdate (as in the things provided by two or more recipes) being on the same system at the same time, since ntp provides ntpdate anyway. At least it looks like it does on my test build.

Quoted 6 lines

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

I'm fine with a single recipe and using PACKAGECONFIG to control the sslness of it.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#18 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 8 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 6 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 5 lines

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

The idea with PACKAGECONFIG is it allows per-recipe control over this kind of thing. The default would be for OpenSSL support to be disabled, but it could be enabled with a bbappend containing PACKAGECONFIG += "openssl"; alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the distro .conf file or even local.conf.

I'll send a patch.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#19 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 15 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 8 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 6 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 5 lines

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

Quoted 7 lines

The idea with PACKAGECONFIG is it allows per-recipe control over this kind of thing. The default would be for OpenSSL support to be disabled, but it could be enabled with a bbappend containing PACKAGECONFIG += "openssl"; alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the distro .conf file or even local.conf.

I'll send a patch.

Great. Thanks, Paul.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#20 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 1 line · On Friday 02 November 2012 10:14:02 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 21 lines · 12.11.02 (Fri 14:10) Paul Eggleton wrote:
Quoted 21 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 8 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:
Quoted 6 lines

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 5 lines

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

The idea with PACKAGECONFIG is it allows per-recipe control over this kind of thing. The default would be for OpenSSL support to be disabled, but it could be enabled with a bbappend containing PACKAGECONFIG += "openssl"; alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the distro .conf file or even local.conf.

Quoted 3 lines
Quoted 1 line

I'll send a patch.

Great. Thanks, Paul.

Unfortunately when I tested the OpenSSL part I found that it's not actually linking against the OpenSSL libraries (!) This is due to libssl and libcrypto being split between /usr/lib and /lib respectively instead of being in the same directory as the configure script expects. Also the OpenSSL include directory being specified does not match with what the configure script tests for (it's supposed to be the parent of the openssl directory, not the openssl directory itself).

I've also noticed that the ${PN}-utils package ends up empty and the ${PN}-bin directory contains a bunch of binaries I would have assumed belonged in that package. What should be in these packages? Should there just be one?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#21 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 1 line · On Friday 02 November 2012 10:14:02 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 23 lines · 12.11.02 (Fri 14:10) Paul Eggleton wrote:
Quoted 22 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 8 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:
Quoted 6 lines

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 5 lines

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

The idea with PACKAGECONFIG is it allows per-recipe control over this kind of thing. The default would be for OpenSSL support to be disabled, but it could be enabled with a bbappend containing PACKAGECONFIG += "openssl"; alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the distro .conf file or even local.conf.

I'll send a patch.

Quoted 7 lines
Quoted 1 line

Great. Thanks, Paul.

Unfortunately when I tested the OpenSSL part I found that it's not actually linking against the OpenSSL libraries (!) This is due to libssl and libcrypto being split between /usr/lib and /lib respectively instead of being in the same directory as the configure script expects.

Is that intentional? I mean is that a misconfiguration or something reasonably easily changed, or are there specific reasons for that split, do you know?

Quoted 3 lines

Also the OpenSSL include directory being specified does not match with what the configure script tests for (it's supposed to be the parent of the openssl directory, not the openssl directory itself).

Yeah, that's interesting. Present in the existing recipe as well, from what I can see, so I'm thinking that hasn't worked since at least the update to 4.2.6p5.

Morgan, can you confirm that you've got SSL support working in your updated recipe(s)?

Quoted 3 lines

I've also noticed that the ${PN}-utils package ends up empty and the ${PN}-bin directory contains a bunch of binaries I would have assumed belonged in that package. What should be in these packages? Should there just be one?

I think so. Given that ntpd lives in FILES_${PN}, I'm thinking everything listed in -bin looks appropriate for -utils. Or dumping -utils and leaving them in -bin. Looking at the recipe it seems like -utils was intended to be a housecleaning collection. Did you find other non-named binaries living in ${bindir} on some builds, Morgan?

Signature · 2 lines
-Joe MacDonald.
:wq
#22 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 44 lines · Joe MacDonald
Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 1 line · On Friday 02 November 2012 10:14:02 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 23 lines · 12.11.02 (Fri 14:10) Paul Eggleton wrote:
Quoted 22 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 8 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:
Quoted 6 lines

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 5 lines

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

The idea with PACKAGECONFIG is it allows per-recipe control over this kind of thing. The default would be for OpenSSL support to be disabled, but it could be enabled with a bbappend containing PACKAGECONFIG += "openssl"; alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the distro .conf file or even local.conf.

I'll send a patch.

Quoted 7 lines
Quoted 1 line

Great. Thanks, Paul.

Unfortunately when I tested the OpenSSL part I found that it's not actually linking against the OpenSSL libraries (!) This is due to libssl and libcrypto being split between /usr/lib and /lib respectively instead of being in the same directory as the configure script expects.

Is that intentional? I mean is that a misconfiguration or something reasonably easily changed, or are there specific reasons for that split, do you know?

Quoted 3 lines

Also the OpenSSL include directory being specified does not match with what the configure script tests for (it's supposed to be the parent of the openssl directory, not the openssl directory itself).

Quoted 6 lines

Yeah, that's interesting. Present in the existing recipe as well, from what I can see, so I'm thinking that hasn't worked since at least the update to 4.2.6p5.

Morgan, can you confirm that you've got SSL support working in your updated recipe(s)?

Looking at the configure output, it seems that my builds don't take ssl in either. I'm not sure if 4.2.6p3 worked since without changes the old recipe doesn't build.

Quoted 11 lines
Quoted 4 lines

I've also noticed that the ${PN}-utils package ends up empty and the ${PN}-bin directory contains a bunch of binaries I would have assumed belonged in that package. What should be in these packages? Should there just be one?

I think so. Given that ntpd lives in FILES_${PN}, I'm thinking everything listed in -bin looks appropriate for -utils. Or dumping

(quoted diff) +0 -2
-utils and leaving them in -bin.  Looking at the recipe it seems like
-utils was intended to be a housecleaning collection.  Did you find

other non-named binaries living in ${bindir} on some builds, Morgan?

I didn't find any non-named binaries living in ${bindir}.

//Morgan

#23 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 45 lines · Morgan
Quoted 44 lines · Joe MacDonald
Quoted 26 lines · [Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On…
Quoted 1 line · On Friday 02 November 2012 10:14:02 Joe MacDonald wrote:

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 23 lines · 12.11.02 (Fri 14:10) Paul Eggleton wrote:
Quoted 22 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 8 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:
Quoted 6 lines

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 5 lines

I'm also perfectly fine with that. Question, though. Do you mean that the presence of OpenSSL in the distro would then mean you get ntp-ssl all the time? That would be fine for me, but I wonder if anyone else might want OpenSSL on their system but a non-ssl-enabled ntp? Probably a silly case to be thinking about anyway.

The idea with PACKAGECONFIG is it allows per-recipe control over this kind of thing. The default would be for OpenSSL support to be disabled, but it could be enabled with a bbappend containing PACKAGECONFIG += "openssl"; alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the distro .conf file or even local.conf.

I'll send a patch.

Quoted 7 lines
Quoted 1 line

Great. Thanks, Paul.

Unfortunately when I tested the OpenSSL part I found that it's not actually linking against the OpenSSL libraries (!) This is due to libssl and libcrypto being split between /usr/lib and /lib respectively instead of being in the same directory as the configure script expects.

Is that intentional? I mean is that a misconfiguration or something reasonably easily changed, or are there specific reasons for that split, do you know?

Quoted 3 lines

Also the OpenSSL include directory being specified does not match with what the configure script tests for (it's supposed to be the parent of the openssl directory, not the openssl directory itself).

Quoted 8 lines
Quoted 6 lines

Yeah, that's interesting. Present in the existing recipe as well, from what I can see, so I'm thinking that hasn't worked since at least the update to 4.2.6p5.

Morgan, can you confirm that you've got SSL support working in your updated recipe(s)?

Looking at the configure output, it seems that my builds don't take ssl in either. I'm not sure if 4.2.6p3 worked since without changes the old recipe doesn't build.

Yeah, that's expected based on Paul's findings. I just meant could you ensure it's working in the next version of the recipe update you send out? At some point in the past it was supposed to work, we should probably try to get back there. :-)

Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

I've also noticed that the ${PN}-utils package ends up empty and the ${PN}-bin directory contains a bunch of binaries I would have assumed belonged in that package. What should be in these packages? Should there just be one?

I think so. Given that ntpd lives in FILES_${PN}, I'm thinking everything listed in -bin looks appropriate for -utils. Or dumping

(quoted diff) +0 -2
-utils and leaving them in -bin.  Looking at the recipe it seems like
-utils was intended to be a housecleaning collection.  Did you find

other non-named binaries living in ${bindir} on some builds, Morgan?

I didn't find any non-named binaries living in ${bindir}.

Okay, so dump one of -utils or -bin, I'm leaning toward keeping the former and dumping the latter, but that's really up to you.

Signature · 2 lines
Joe MacDonald, Sr. Member of Technical Staff, Linux Products Group, Wind River
direct 613.270.5750     mobile 613.291.7421     fax 613.592.2283
#24 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

Quoted 1 line · On Friday 09 November 2012 10:04:14 Joe MacDonald wrote:

[RE: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On

Quoted 2 lines · Morgan
Quoted 2 lines · Joe MacDonald
Quoted 1 line

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up

Quoted 79 lines · recipes] On 12.11.02 (Fri 17:26) Paul Eggleton wrote:
Quoted 56 lines
Quoted 56 lines
Quoted 36 lines · On Friday 02 November 2012 10:14:02 Joe MacDonald wrote:
Quoted 2 lines

[Re: [oe] [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes] On> >>

Quoted 32 lines · 12.11.02 (Fri 14:10) Paul Eggleton wrote:
Quoted 31 lines · On Friday 02 November 2012 10:02:23 Joe MacDonald wrote:
Quoted 9 lines · On 12.11.02 (Fri 13:38) Paul Eggleton wrote:
Quoted 7 lines

I have to say I think that these days this could be better implemented
as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Quoted 9 lines

I'm also perfectly fine with that. Question, though. Do you mean that
the presence of OpenSSL in the distro would then mean you get ntp-ssl
all the time? That would be fine for me, but I wonder if anyone else
might want OpenSSL on their system but a non-ssl-enabled ntp? Probably
a silly case to be thinking about anyway.

The idea with PACKAGECONFIG is it allows per-recipe control over this kind
of thing. The default would be for OpenSSL support to be disabled, but it
could be enabled with a bbappend containing PACKAGECONFIG += "openssl";
alternatively you could do PACKAGECONFIG_append_pn-ntp = " openssl" in the
distro .conf file or even local.conf.

I'll send a patch.

Quoted 7 lines
Quoted 1 line

Great. Thanks, Paul.

Unfortunately when I tested the OpenSSL part I found that it's not actually linking against the OpenSSL libraries (!) This is due to libssl and libcrypto being split between /usr/lib and /lib respectively instead of being in the same directory as the configure script expects.

Is that intentional? I mean is that a misconfiguration or something reasonably easily changed, or are there specific reasons for that split, do you know?

Quoted 3 lines

Also the OpenSSL include directory being specified does not match with what the configure script tests for (it's supposed to be the parent of the openssl directory, not the openssl directory itself).

Yeah, that's interesting. Present in the existing recipe as well, from what I can see, so I'm thinking that hasn't worked since at least the update to 4.2.6p5.

Quoted 6 lines
Quoted 2 lines

Morgan, can you confirm that you've got SSL support working in your updated recipe(s)?

Looking at the configure output, it seems that my builds don't take ssl in either. I'm not sure if 4.2.6p3 worked since without changes the old recipe doesn't build.

Yeah, that's expected based on Paul's findings. I just meant could you ensure it's working in the next version of the recipe update you send out? At some point in the past it was supposed to work, we should probably try to get back there. :-)

Quoted 11 lines
Quoted 9 lines
Quoted 4 lines

I've also noticed that the ${PN}-utils package ends up empty and the ${PN}-bin directory contains a bunch of binaries I would have assumed belonged in that package. What should be in these packages? Should there just be one?> >

I think so. Given that ntpd lives in FILES_${PN}, I'm thinking everything listed in -bin looks appropriate for -utils. Or dumping

(quoted diff) +0 -2
-utils and leaving them in -bin.  Looking at the recipe it seems like
-utils was intended to be a housecleaning collection.  Did you find

other non-named binaries living in ${bindir} on some builds, Morgan?

I didn't find any non-named binaries living in ${bindir}.

Quoted 2 lines

Okay, so dump one of -utils or -bin, I'm leaning toward keeping the former and dumping the latter, but that's really up to you.

FYI I am still working on a patch for the ntp recipes here but have yet to fix the SSL issue fully.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#25 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

In reply to Paul Eggleton
Quoted 5 lines · Paul Eggleton

I have to say I think that these days this could be better implemented as one ntp recipe with a PACKAGECONFIG that you can use to enable OpenSSL support if desired. (At the time the ntp/ntp-ssl split was done, PACKAGECONFIG did not exist). Then it becomes a distro-level choice as to whether this is enabled as I believe was originally intended.

Yes, agreed, that would be ideal.

p.

#26 lore raw

Re: [meta-oe][meta-networking][PATCH V2 3/3] ntp: Clean up recipes

In reply to Paul Eggleton
Quoted 3 lines · Paul Eggleton

I'm not sure that it does. I think the split was made just to avoid bringing in OpenSSL on systems where it was not needed or desired. Phil Blundell (on CC) made the split quite a while ago in OE-Classic - Phil can you comment?

Yes, exactly. If ntpdate is the only thing on the system that's linked with openssl then it ends up dragging in several times its own weight in dependencies. And, for most people, having SSL-secured time is not that much of a priority since the time server is typically on a trusted local network.

p.