hexagon: dma-mapping: support debug_dma_mapping_error

PATCH New Shuah Khan 2 participants 5 messages Oct 25, 2012 – Nov 15, 2012 Qualcomm hexagon architecture

Share & tools

Shuah Khan

author

2012-10-25 23:12 UTC #0 lore raw

PATCH 1/1 hexagon: dma-mapping: support debug_dma_mapping_error

Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.

Signed-off-by Shuah Khan <[email protected]>

---
 arch/hexagon/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)

arch/hexagon/include/asm/dma-mapping.h +1 -0

index 85e9935..1957c4c 100644
@@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
 	struct dma_map_ops *dma_ops = get_dma_ops(dev);
 
+	debug_dma_mapping_error(dev, dma_addr);
 	if (dma_ops->mapping_error)
 		return dma_ops->mapping_error(dev, dma_addr);

Signature · 1 line

1.7.9.5

Shuah Khan

author

2012-10-26 15:43 UTC #1 lore raw

PATCH 1/1 hexagon: dma-mapping: support debug_dma_mapping_error

Signed-off-by Shuah Khan <[email protected]>

---
 arch/hexagon/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)

arch/hexagon/include/asm/dma-mapping.h +1 -0

index 85e9935..1957c4c 100644
@@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
 	struct dma_map_ops *dma_ops = get_dma_ops(dev);
 
+	debug_dma_mapping_error(dev, dma_addr);
 	if (dma_ops->mapping_error)
 		return dma_ops->mapping_error(dev, dma_addr);

Signature · 1 line

1.7.9.5

Shuah Khan

author

2012-11-02 16:48 UTC #2 lore raw

Quoted 9 lines · Shuah Khan

Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
---
 arch/hexagon/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)

Would you like se this patch go through arch tree or linux-next? Please let me know your preference.

-- Shuah

Quoted 13 lines

arch/hexagon/include/asm/dma-mapping.h +1 -0

index 85e9935..1957c4c 100644
@@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
 	struct dma_map_ops *dma_ops = get_dma_ops(dev);
 
+	debug_dma_mapping_error(dev, dma_addr);
 	if (dma_ops->mapping_error)
 		return dma_ops->mapping_error(dev, dma_addr);

Richard Kuo

Acked-by

2012-11-05 01:08 UTC #3 lore raw

Quoted 24 lines · Shuah Khan

Quoted 9 lines · Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
---
 arch/hexagon/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)
Would you like se this patch go through arch tree or linux-next? Please let me know your preference.
-- Shuah
Quoted 9 lines
arch/hexagon/include/asm/dma-mapping.h +0 -0
index 85e9935..1957c4c 100644
@@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
 	struct dma_map_ops *dma_ops = get_dma_ops(dev);
 

Quoted 6 lines

arch/hexagon/include/asm/dma-mapping.h static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) · line 71
Quoted 4 lines
arch/hexagon/include/asm/dma-mapping.h +1 -0
+	debug_dma_mapping_error(dev, dma_addr);
 	if (dma_ops->mapping_error)
 		return dma_ops->mapping_error(dev, dma_addr);
 

This looks fine; I'm OK with this going through linux-next. Thanks!

Acked-by Richard Kuo <[email protected]>

Signature · 3 lines

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Shuah Khan

author

2012-11-15 17:57 UTC #4 lore raw

Quoted 32 lines · Richard Kuo

Quoted 24 lines · Shuah Khan
Quoted 9 lines · Shuah Khan
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
---
 arch/hexagon/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)
Would you like se this patch go through arch tree or linux-next? Please let me know your preference.
-- Shuah
Quoted 9 lines
arch/hexagon/include/asm/dma-mapping.h +0 -0
index 85e9935..1957c4c 100644
@@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
 	struct dma_map_ops *dma_ops = get_dma_ops(dev);
 
Quoted 6 lines
arch/hexagon/include/asm/dma-mapping.h static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) · line 71
Quoted 4 lines
arch/hexagon/include/asm/dma-mapping.h +1 -0
+	debug_dma_mapping_error(dev, dma_addr);
 	if (dma_ops->mapping_error)
 		return dma_ops->mapping_error(dev, dma_addr);
 

Quoted 4 lines

This looks fine; I'm OK with this going through linux-next. Thanks!
Acked-by Richard Kuo <[email protected]>

Marek,

This one is for hexagon to go through your tree with the other arch patches for debug_dma_mapping_error().

Thanks,
-- Shuah