Skip to contentSkip to conversation

x86: remove dummy long from EFI stub

PATCH In review Cesar Eduardo Barros 3 participants 4 messages Oct 27, 2012 – Nov 19, 2012 x86

lore
Share & tools
lore

Cesar Eduardo Barros

author
#0 lore raw

PATCH 1/1 x86: remove dummy long from EFI stub

Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI boot stub support), but forgot to remove the dummy long used by that reloc.

Cc Jordan Justen <[email protected]>
Cc Matt Fleming <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Signed-off-by Cesar Eduardo Barros <[email protected]>
---
 arch/x86/boot/header.S | 3 ---
 1 file changed, 3 deletions(-)
arch/x86/boot/header.S +0 -3
index 2a01744..8c132a6 100644
@@ -476,6 +476,3 @@ die:
 setup_corrupt:
 	.byte	7
 	.string	"No setup signature found...\n"
-
-	.data
-dummy:	.long	0
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 20 lines · Cesar Eduardo Barros

Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI boot stub support), but forgot to remove the dummy long used by that reloc.

Cc Jordan Justen <[email protected]>
Cc Matt Fleming <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Signed-off-by Cesar Eduardo Barros <[email protected]>
---
 arch/x86/boot/header.S | 3 ---
 1 file changed, 3 deletions(-)
arch/x86/boot/header.S +0 -0
index 2a01744..8c132a6 100644

arch/x86/boot/header.S die: · line 481

Quoted 6 lines
arch/x86/boot/header.S +0 -3
@@ -476,6 +476,3 @@ die:
 setup_corrupt:
 	.byte	7
 	.string	"No setup signature found...\n"
-
-	.data
-dummy:	.long	0

This change seems fine to me. Jordan, would you mind ACKing this if you're OK with it?

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center
Reviewed-by on v1 1/1
#2 lore raw
In reply to Cesar Eduardo Barros
Reviewed-by Jordan Justen <[email protected]>

Lee also tested with Secure Boot. (Thanks Lee)

-Jordan

Quoted 26 lines · Cesar Eduardo Barros

Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI boot stub support), but forgot to remove the dummy long used by that reloc.

Cc Jordan Justen <[email protected]>
Cc Matt Fleming <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Signed-off-by Cesar Eduardo Barros <[email protected]>
---
 arch/x86/boot/header.S | 3 ---
 1 file changed, 3 deletions(-)
arch/x86/boot/header.S +0 -3
index 2a01744..8c132a6 100644
@@ -476,6 +476,3 @@ die:
 setup_corrupt:
 	.byte	7
 	.string	"No setup signature found...\n"
-
-	.data
-dummy:	.long	0