Skip to contentSkip to conversation

staging: dgrp: fix potential NULL defereference issue

PATCH New Yuanhan Liu 1 participant 1 message Oct 29, 2012 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgrp: fix potential NULL defereference issue

Fix a coccinelle warning catched by Fengguang's 0-DAY system:
+ drivers/staging/dgrp/dgrp_net_ops.c:1061:11-27: ERROR: nd is NULL but dereferenced.

Put the "done:" label a bit down would solve this issue.

Cc Fengguang Wu <[email protected]>
Cc Julia Lawall <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/dgrp/dgrp_net_ops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/dgrp/dgrp_net_ops.c +1 -1
index ab839ea..1ad674f1 100644
@@ -1057,13 +1057,13 @@ static int dgrp_net_release(struct inode *inode, struct file *file)
 
 	spin_unlock_irqrestore(&dgrp_poll_data.poll_lock, lock_flags);
 
-done:
 	down(&nd->nd_net_semaphore);
 
 	dgrp_monitor_message(nd, "Net Close");
 
 	up(&nd->nd_net_semaphore);
 
+done:
 	module_put(THIS_MODULE);
 	file->private_data = NULL;
 	return 0;
Signature · 1 line
1.7.7.6