hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting

PATCH Applied Axel Lin 3 participants 4 messages Oct 29, 2012 – Oct 30, 2012

Subsystems (2)

Hardware monitoring Dialog semiconductor drivers

lore

Share & tools

lore

Axel Lin

author

2012-10-29 08:34 UTC #0 lore raw

PATCH 1/1 hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting

Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.

Signed-off-by Axel Lin <[email protected]>

---
Hi,
This looks like a typo, but I don't have a hardware to test it.
Axel

 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/hwmon/da9055-hwmon.c +1 -1

index 0b41f2c..3a3377c 100644
@@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
 	[DA9055_ADC_VSYS]	= DA9055_ADC_MUX_VSYS,
 	[DA9055_ADC_ADCIN1]	= DA9055_ADC_MUX_ADCIN1,
 	[DA9055_ADC_ADCIN2]	= DA9055_ADC_MUX_ADCIN2,
-	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN1,
+	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN3,
 	[DA9055_ADC_TJUNC]	= DA9055_ADC_MUX_T_SENSE,
 };

Signature · 9 lines

1.7.9.5




_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Guenter Roeck

maintainer

2012-10-30 00:52 UTC #1 lore raw

Quoted 15 lines · Axel Lin

Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
Signed-off-by Axel Lin <[email protected]>
---
Hi,
This looks like a typo, but I don't have a hardware to test it.
Axel
 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/da9055-hwmon.c +0 -0
index 0b41f2c..3a3377c 100644

drivers/hwmon/da9055-hwmon.c static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = { · line 59

Quoted 7 lines

drivers/hwmon/da9055-hwmon.c +1 -1

@@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
 	[DA9055_ADC_VSYS]	= DA9055_ADC_MUX_VSYS,
 	[DA9055_ADC_ADCIN1]	= DA9055_ADC_MUX_ADCIN1,
 	[DA9055_ADC_ADCIN2]	= DA9055_ADC_MUX_ADCIN2,
-	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN1,
+	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN3,
 	[DA9055_ADC_TJUNC]	= DA9055_ADC_MUX_T_SENSE,
 };

Very much loks like a typo.

David, Ashish, any comments ? I would like to get your Ack before applying it.

Thanks,
Guenter

Ashish Jangam

2012-10-30 04:22 UTC #2 lore raw

Quoted 26 lines · Guenter Roeck

Quoted 15 lines · Axel Lin
Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
Signed-off-by Axel Lin <[email protected]>
---
Hi,
This looks like a typo, but I don't have a hardware to test it.
Axel
 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/da9055-hwmon.c +0 -0
index 0b41f2c..3a3377c 100644
drivers/hwmon/da9055-hwmon.c static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = { · line 59
Quoted 7 lines
drivers/hwmon/da9055-hwmon.c +1 -1
@@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
 	[DA9055_ADC_VSYS]	= DA9055_ADC_MUX_VSYS,
 	[DA9055_ADC_ADCIN1]	= DA9055_ADC_MUX_ADCIN1,
 	[DA9055_ADC_ADCIN2]	= DA9055_ADC_MUX_ADCIN2,
-	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN1,
+	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN3,
 	[DA9055_ADC_TJUNC]	= DA9055_ADC_MUX_T_SENSE,
 };
Very much loks like a typo.

Quoted 5 lines

David, Ashish, any comments ? I would like to get your Ack before applying it.
Thanks,
Guenter

Yes, its typo so you can apply the patch.

Guenter Roeck

maintainer Applied

2012-10-30 05:49 UTC #3 lore raw

In reply to Axel Lin

Quoted 15 lines · Axel Lin

Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
Signed-off-by Axel Lin <[email protected]>
---
Hi,
This looks like a typo, but I don't have a hardware to test it.
Axel
 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/da9055-hwmon.c +0 -0
index 0b41f2c..3a3377c 100644

drivers/hwmon/da9055-hwmon.c static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = { · line 60

Quoted 8 lines

drivers/hwmon/da9055-hwmon.c +1 -1

@@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
 	[DA9055_ADC_VSYS]	= DA9055_ADC_MUX_VSYS,
 	[DA9055_ADC_ADCIN1]	= DA9055_ADC_MUX_ADCIN1,
 	[DA9055_ADC_ADCIN2]	= DA9055_ADC_MUX_ADCIN2,
-	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN1,
+	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN3,
 	[DA9055_ADC_TJUNC]	= DA9055_ADC_MUX_T_SENSE,
 };

Applied.

Thanks,
Guenter