Skip to contentSkip to conversation

maliit-plugins: Clean up recipe and add missing RDEPENDS

PATCH In review Samuel Stirtzel 2 participants 4 messages Oct 30, 2012 – Dec 3, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maliit-plugins: Clean up recipe and add missing RDEPENDS

The following errors are only shown when started from console, also there are no visible errors during execution.
Error fixed: QML Image: Error decoding: file:///usr/share/maliit/plugins/org/nemomobile/icon-m-input-methods-shift-lowercase.svg: Unsupported image format

This is unaffected from whether libqtsvg4 is installed or not.

---
 .../recipes-support/maliit/maliit-plugins_git.bb   |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +4 -6
index 932c0ae..2fb52c7 100644
@@ -8,6 +8,8 @@ inherit autotools qt4x11
 
 DEPENDS = "maliit-framework"
 
+RDEPENDS_${PN} += "qt4-plugin-iconengine-svgicon qt4-plugin-imageformat-svg"
+
 SRC_URI = "git://gitorious.org/maliit/maliit-plugins.git;branch=master"
 
 SRCREV = "0760e585df494b394df1b887e5138ffef19c481f"
@@ -23,12 +25,8 @@ FILES_${PN} += "\
     ${datadir} \
     "
 
-FILES_${PN}-dbg += "\
-    ${libdir}/maliit/plugins-*/.debug \
-    "
+FILES_${PN}-dbg += "${libdir}/maliit/plugins-*/.debug"
 
 S= "${WORKDIR}/git"
 
-do_install() {
-  cd ${S} && (INSTALL_ROOT=${D} oe_runmake install)
-}
\ No newline at end of file
+EXTRA_OEMAKE += "INSTALL_ROOT=${D}"
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 30 lines · Samuel Stirtzel

The following errors are only shown when started from console, also there are no visible errors during execution.
Error fixed: QML Image: Error decoding: file:///usr/share/maliit/plugins/org/nemomobile/icon-m-input-methods-shift-lowercase.svg: Unsupported image format

This is unaffected from whether libqtsvg4 is installed or not.

---
 .../recipes-support/maliit/maliit-plugins_git.bb   |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +2 -3
index 932c0ae..2fb52c7 100644
@@ -8,6 +8,8 @@ inherit autotools qt4x11
 
 DEPENDS = "maliit-framework"
 
+RDEPENDS_${PN} += "qt4-plugin-iconengine-svgicon qt4-plugin-imageformat-svg"
+
 SRC_URI = "git://gitorious.org/maliit/maliit-plugins.git;branch=master"
 
 SRCREV = "0760e585df494b394df1b887e5138ffef19c481f"
@@ -23,12 +25,8 @@ FILES_${PN} += "\
     ${datadir} \
     "
 
-FILES_${PN}-dbg += "\
-    ${libdir}/maliit/plugins-*/.debug \
-    "

meta-oe/recipes-support/maliit/maliit-plugins_git.bb FILES_${PN} += "\

Quoted 10 lines
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +2 -4
+FILES_${PN}-dbg += "${libdir}/maliit/plugins-*/.debug"
 
 S= "${WORKDIR}/git"
 
-do_install() {
-  cd ${S} && (INSTALL_ROOT=${D} oe_runmake install)
-}
\ No newline at end of file
+EXTRA_OEMAKE += "INSTALL_ROOT=${D}"
--

It fails to build docs on hosts without doxygen, can we disable docs?

| make[1]: Entering directory `/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc' | sed -e "s;@VERSION@;0.92.3;g" -e "s;@IN_PWD@;/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc;g" doxyfile.conf.in > /OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc/doxyfile.conf && doxygen /OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc/doxyfile.conf

| /bin/sh: doxygen: command not found
| make[1]: *** [html/index.html] Error 127
| make[1]: Leaving directory

`/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc'

Cheers,

#2 lore raw

2012/12/3 Martin Jansa <[email protected]>:

Quoted 36 lines
Quoted 34 lines · Samuel Stirtzel

The following errors are only shown when started from console, also there are no visible errors during execution.
Error fixed: QML Image: Error decoding: file:///usr/share/maliit/plugins/org/nemomobile/icon-m-input-methods-shift-lowercase.svg: Unsupported image format

This is unaffected from whether libqtsvg4 is installed or not.

---
 .../recipes-support/maliit/maliit-plugins_git.bb   |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +3 -3
index 932c0ae..2fb52c7 100644
@@ -8,6 +8,8 @@ inherit autotools qt4x11
 
 DEPENDS = "maliit-framework"
 
+RDEPENDS_${PN} += "qt4-plugin-iconengine-svgicon qt4-plugin-imageformat-svg"
+
 SRC_URI = "git://gitorious.org/maliit/maliit-plugins.git;branch=master"
 
 SRCREV = "0760e585df494b394df1b887e5138ffef19c481f"
@@ -23,12 +25,8 @@ FILES_${PN} += "\
     ${datadir} \
     "
 
-FILES_${PN}-dbg += "\
-    ${libdir}/maliit/plugins-*/.debug \
-    "
+FILES_${PN}-dbg += "${libdir}/maliit/plugins-*/.debug"
 
 S= "${WORKDIR}/git"
 
Quoted 8 lines

meta-oe/recipes-support/maliit/maliit-plugins_git.bb FILES_${PN} += "\

Quoted 6 lines
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +1 -4
-do_install() {
-  cd ${S} && (INSTALL_ROOT=${D} oe_runmake install)
-}
\ No newline at end of file
+EXTRA_OEMAKE += "INSTALL_ROOT=${D}"
--

It fails to build docs on hosts without doxygen, can we disable docs?

Seems like I was careless, this hasn't been noticed as doxygen is installed on all my build machines.

However I'll send a follow-up patch, do you want me to disable docs for the framework as well? The Framework uses gtk-doc.

Quoted 19 lines

| make[1]: Entering directory `/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc' | sed -e "s;@VERSION@;0.92.3;g" -e "s;@IN_PWD@;/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc;g" doxyfile.conf.in > /OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc/doxyfile.conf && doxygen /OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc/doxyfile.conf

| /bin/sh: doxygen: command not found
| make[1]: *** [html/index.html] Error 127
| make[1]: Leaving directory

`/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc'

Cheers,

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 2 lines
Regards
Samuel
#3 lore raw
Quoted 46 lines · Samuel Stirtzel

2012/12/3 Martin Jansa <[email protected]>:

Quoted 36 lines
Quoted 34 lines · Samuel Stirtzel

The following errors are only shown when started from console, also there are no visible errors during execution.
Error fixed: QML Image: Error decoding: file:///usr/share/maliit/plugins/org/nemomobile/icon-m-input-methods-shift-lowercase.svg: Unsupported image format

This is unaffected from whether libqtsvg4 is installed or not.

---
 .../recipes-support/maliit/maliit-plugins_git.bb   |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +3 -3
index 932c0ae..2fb52c7 100644
@@ -8,6 +8,8 @@ inherit autotools qt4x11
 
 DEPENDS = "maliit-framework"
 
+RDEPENDS_${PN} += "qt4-plugin-iconengine-svgicon qt4-plugin-imageformat-svg"
+
 SRC_URI = "git://gitorious.org/maliit/maliit-plugins.git;branch=master"
 
 SRCREV = "0760e585df494b394df1b887e5138ffef19c481f"
@@ -23,12 +25,8 @@ FILES_${PN} += "\
     ${datadir} \
     "
 
-FILES_${PN}-dbg += "\
-    ${libdir}/maliit/plugins-*/.debug \
-    "
+FILES_${PN}-dbg += "${libdir}/maliit/plugins-*/.debug"
 
 S= "${WORKDIR}/git"
 
Quoted 8 lines

meta-oe/recipes-support/maliit/maliit-plugins_git.bb FILES_${PN} += "\

Quoted 6 lines
meta-oe/recipes-support/maliit/maliit-plugins_git.bb +1 -4
-do_install() {
-  cd ${S} && (INSTALL_ROOT=${D} oe_runmake install)
-}
\ No newline at end of file
+EXTRA_OEMAKE += "INSTALL_ROOT=${D}"
--

It fails to build docs on hosts without doxygen, can we disable docs?

Quoted 2 lines

Seems like I was careless, this hasn't been noticed as doxygen is installed on all my build machines.

No problem, it's hard to notice such issues unless you're building in minimal chroot like I do.

Quoted 2 lines

However I'll send a follow-up patch, do you want me to disable docs for the framework as well? The Framework uses gtk-doc.

It doesn't fail in framework, bbclass takes care of that IIRC, but fix those QA Errors there, please.

Cheers,

Quoted 30 lines
Quoted 19 lines

| make[1]: Entering directory `/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc' | sed -e "s;@VERSION@;0.92.3;g" -e "s;@IN_PWD@;/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc;g" doxyfile.conf.in > /OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc/doxyfile.conf && doxygen /OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc/doxyfile.conf

| /bin/sh: doxygen: command not found
| make[1]: *** [html/index.html] Error 127
| make[1]: Leaving directory

`/OE/jansa-test/shr-core/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/maliit-plugins/0.92.3+git1+0760e585df494b394df1b887e5138ffef19c481f-r0/git/doc'

Cheers,

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 7 lines
Regards
Samuel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]