Skip to contentSkip to conversation

meta-systemd: Move ntp recipes to 'meta-networking' sublayer

PATCH In review Otavio Salvador 6 participants 19 messages Oct 31, 2012 – Nov 22, 2012

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 meta-systemd: Move ntp recipes to 'meta-networking' sublayer

---
 .../recipes-support/ntp/ntp/ntpd.service           |    0
 .../recipes-support/ntp/ntp/ntpdate.service        |    0
 .../recipes-support/ntp/ntp_4.2.6p3.bbappend       |    0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp/ntpd.service (100%)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp/ntpdate.service (100%)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp_4.2.6p3.bbappend (100%)
meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpd.service renamed from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpd.service +0 -0
similarity index 100%
rename from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpd.service
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpd.service
meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpdate.service renamed from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpdate.service +0 -0
similarity index 100%
rename from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpdate.service
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpdate.service
meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p3.bbappend renamed from meta-systemd/meta-oe/recipes-support/ntp/ntp_4.2.6p3.bbappend +0 -0
similarity index 100%
rename from meta-systemd/meta-oe/recipes-support/ntp/ntp_4.2.6p3.bbappend
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p3.bbappend
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH v2 2/3 meta-systemd: meta-networking: ntp: Update bbappend to 4.2.6p5

---
 .../{ntp_4.2.6p3.bbappend => ntp_4.2.6p5.bbappend} |    0
 1 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-systemd/meta-networking/recipes-support/ntp/{ntp_4.2.6p3.bbappend => ntp_4.2.6p5.bbappend} (100%)
meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bbappend renamed from meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p3.bbappend +0 -0
similarity index 100%
rename from meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p3.bbappend
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bbappend
Signature · 1 line
1.7.2.5
#2 lore raw

Re: [meta-oe][PATCH v2 2/3] meta-systemd: meta-networking: ntp: Update bbappend to 4.2.6p5

Quoted 5 lines · Otavio Salvador
---
 .../{ntp_4.2.6p3.bbappend => ntp_4.2.6p5.bbappend} |    0
 1 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-systemd/meta-networking/recipes-support/ntp/{ntp_4.2.6p3.bbappend => ntp_4.2.6p5.bbappend} (100%)

Ping?

Could we have this patch (and the 1/3, which moved systemd-support to meta-systemd/meta-networking/....) applied?

meta-systemd has been unparsable for quite some time now, as meta-networking has ntp 4.2.6p5, and the bbappend in meta-systemd is for 4.2.6p3...

/Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#3 lore raw

Re: [meta-oe][PATCH v2 2/3] meta-systemd: meta-networking: ntp: Update bbappend to 4.2.6p5

Quoted 9 lines · On Thursday 22 November 2012 07:22:25 Anders Darander wrote:
Quoted 8 lines · Otavio Salvador

---

 .../{ntp_4.2.6p3.bbappend => ntp_4.2.6p5.bbappend} |    0
 1 files changed, 0 insertions(+), 0 deletions(-)

rename meta-systemd/meta-networking/recipes-support/ntp/{ntp_4.2.6p3.bbappend => ntp_4.2.6p5.bbappend} (100%)

Quoted 8 lines

Ping?

Could we have this patch (and the 1/3, which moved systemd-support to meta-systemd/meta-networking/....) applied?

meta-systemd has been unparsable for quite some time now, as meta-networking has ntp 4.2.6p5, and the bbappend in meta-systemd is for 4.2.6p3...

I'm not sure why this had to be delayed - it could have been applied immediately. Assuming it doesn't get applied this morning I will include it in my ntp patch series since I apparently need to update the systemd service anyway.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw

PATCH v2 3/3 freerdp: Bump SRCREV to 1.0.2 snapshot of 2012-10-30

In reply to Otavio Salvador
---
 meta-oe/recipes-support/freerdp/freerdp_git.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta-oe/recipes-support/freerdp/freerdp_git.bb +1 -1
index 01ab390..35228ad 100644
@@ -9,7 +9,7 @@ PV = "gitr${SRCPV}"
 PKGV = "${GITPKGVTAG}"
 PR = "${INC_PR}.0"
 
-SRCREV = "19d4a4276869ec40ee1eef066ac460615734c043"
+SRCREV = "e0f2b3ccc986a165d9c289a569b60eab66153792"
 SRC_URI = "git://github.com/FreeRDP/FreeRDP.git"
 
 S = "${WORKDIR}/git"
Signature · 1 line
1.7.2.5
#5 lore raw
In reply to Otavio Salvador

For this you should also have a look at the ntpdate.service and ntp.service files. There was a discussion about this earlier:
http://patches.openembedded.org/patch/38575/

Also, what is not on that discussion, is that pool.ntp.org is not really the way to do it. What we would like is to register something like pool.yocto.ntp.org, but for
now I guess we can just use pool.ntp.org and then change it when someone have registered it. Kind of feel someone officially related to the project should register it.

- Martin

Quoted 22 lines · Otavio Salvador
---
 .../recipes-support/ntp/ntp/ntpd.service           |    0
 .../recipes-support/ntp/ntp/ntpdate.service        |    0
 .../recipes-support/ntp/ntp_4.2.6p3.bbappend       |    0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp/ntpd.service (100%)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp/ntpdate.service (100%)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp_4.2.6p3.bbappend (100%)
meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpd.service renamed from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpd.service +0 -0
similarity index 100%
rename from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpd.service
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpd.service
meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpdate.service renamed from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpdate.service +0 -0
similarity index 100%
rename from meta-systemd/meta-oe/recipes-support/ntp/ntp/ntpdate.service
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp/ntpdate.service
meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p3.bbappend renamed from meta-systemd/meta-oe/recipes-support/ntp/ntp_4.2.6p3.bbappend +0 -0
similarity index 100%
rename from meta-systemd/meta-oe/recipes-support/ntp/ntp_4.2.6p3.bbappend
rename to meta-systemd/meta-networking/recipes-support/ntp/ntp_4.2.6p3.bbappend
#6 lore raw
Quoted 3 lines · Martin Ertsås

For this you should also have a look at the ntpdate.service and ntp.service files. There was a discussion about this earlier:
http://patches.openembedded.org/patch/38575/

Sure, that patch is also nice to have. However, it's more important to get Otavio's update in, as currently meta-oe (meta-networkig) doesn't build together with meta-systemd... As there is a version conflict between the bb and bbappend.

Quoted 6 lines

Also, what is not on that discussion, is that pool.ntp.org is not really the way to do it. What we would like is to register something like pool.yocto.ntp.org, but for
now I guess we can just use pool.ntp.org and then change it when someone have registered it. Kind of feel someone officially related to the project should register it.

The same reasoning apply here. Hopefully, someone in the Yocto Project can register a pool, after which we can update the recipe again.

Cheers,
Anders

Quoted 11 lines · Otavio Salvador
Quoted 10 lines
---
 .../recipes-support/ntp/ntp/ntpd.service           |    0
 .../recipes-support/ntp/ntp/ntpdate.service        |    0
 .../recipes-support/ntp/ntp_4.2.6p3.bbappend       |    0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp/ntpd.service (100%)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp/ntpdate.service (100%)
 rename meta-systemd/{meta-oe => meta-networking}/recipes-support/ntp/ntp_4.2.6p3.bbappend (100%)
Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#7 lore raw
In reply to Martin Ertsås
Quoted 10 lines · Martin Ertsås

For this you should also have a look at the ntpdate.service and ntp.service files. There was a discussion about this earlier:
http://patches.openembedded.org/patch/38575/

Also, what is not on that discussion, is that pool.ntp.org is not really the way to do it. What we would like is to register something like pool.yocto.ntp.org, but for
now I guess we can just use pool.ntp.org and then change it when someone have registered it. Kind of feel someone officially related to the project should register it.

I did it but in a new patch.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#8 lore raw
In reply to Martin Ertsås
Quoted 1 line · Martin Ertsås

for now I guess we can just use pool.ntp.org

I'm not sure that this is a very good idea. The pool.ntp.org documentation is fairly explicit that they don't want this:

You must absolutely not use the default pool.ntp.org zone names as the default configuration in your application or appliance.

p.

#9 lore raw
Quoted 12 lines · Phil Blundell
Quoted 1 line · Martin Ertsås

for now I guess we can just use pool.ntp.org

I'm not sure that this is a very good idea. The pool.ntp.org documentation is fairly explicit that they don't want this:

You must absolutely not use the default pool.ntp.org zone names as the default configuration in your application or appliance.

Quoted 6 lines

p.

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Should we just leave the .service files broken then, until someone registers a pool? Or are we allowed to use someone else's pool?

- Martin

#10 lore raw
Quoted 2 lines · Martin Ertsås

Should we just leave the .service files broken then, until someone registers a pool? Or are we allowed to use someone else's pool?

I don't think just using someone else's pool without asking them would be a terribly polite way to proceed.

It seems like your options are:

a) Make it be a DISTRO setting, punt this problem to the distribution, and let them figure out what to do about it.

b) Make the service files take the NTP server from DHCP rather than having it be hard-coded.

c) Approach ntp.org to get a vendor zone for OE and have it be the default.

d) Use your own NTP server, or one provided by a Yocto-affiliated organisation.

e) Leave the files alone.

p.

#11 lore raw
Quoted 15 lines · Phil Blundell
Quoted 2 lines · Martin Ertsås

Should we just leave the .service files broken then, until someone registers a pool? Or are we allowed to use someone else's pool?

I don't think just using someone else's pool without asking them would be a terribly polite way to proceed.

It seems like your options are:

a) Make it be a DISTRO setting, punt this problem to the distribution, and let them figure out what to do about it.

b) Make the service files take the NTP server from DHCP rather than having it be hard-coded.

Quoted 7 lines

c) Approach ntp.org to get a vendor zone for OE and have it be the default.

d) Use your own NTP server, or one provided by a Yocto-affiliated organisation.

e) Leave the files alone.

Well, I cannot ask for a pool zone for OE or Yocto; it'd be good but it is not yet done and I prefer to have it merged and changed once it happens.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#12 lore raw
Quoted 3 lines · Otavio Salvador

Well, I cannot ask for a pool zone for OE or Yocto; it'd be good but it is not yet done and I prefer to have it merged and changed once it happens.

The obvious problem with that approach is that "it" may never happen (especially if you're relying on some as-yet-unidentified third party to do the work) and, even if it does, arbitrarily many people might ship the broken configuration in the meantime. Merging a change that we know is wrong seems like a bad plan.

p.

#13 lore raw
Quoted 10 lines · Phil Blundell
Quoted 3 lines · Otavio Salvador

Well, I cannot ask for a pool zone for OE or Yocto; it'd be good but it is not yet done and I prefer to have it merged and changed once it happens.

The obvious problem with that approach is that "it" may never happen (especially if you're relying on some as-yet-unidentified third party to do the work) and, even if it does, arbitrarily many people might ship the broken configuration in the meantime. Merging a change that we know is wrong seems like a bad plan.

It is better then a broken .service file IMO ;-)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#14 lore raw
Quoted 6 lines · Otavio Salvador
Quoted 5 lines · Phil Blundell
Quoted 3 lines · Otavio Salvador

Well, I cannot ask for a pool zone for OE or Yocto; it'd be good but it is not yet done and I prefer to have it merged and changed once it happens.

Quoted 7 lines
Quoted 5 lines

The obvious problem with that approach is that "it" may never happen (especially if you're relying on some as-yet-unidentified third party to do the work) and, even if it does, arbitrarily many people might ship the broken configuration in the meantime. Merging a change that we know is wrong seems like a bad plan.

It is better then a broken .service file IMO ;-)

Well, I guess that's where we disagree. Can you elaborate on why having no default NTP server in the metadata is such a crisis, and why none of the other options I mentioned before is a suitable way to deal with the problem?

p.

#15 lore raw
Quoted 13 lines · Phil Blundell
Quoted 12 lines · Otavio Salvador
Quoted 10 lines · Phil Blundell
Quoted 3 lines · Otavio Salvador

Well, I cannot ask for a pool zone for OE or Yocto; it'd be good but it is not yet done and I prefer to have it merged and changed once it happens.

The obvious problem with that approach is that "it" may never happen (especially if you're relying on some as-yet-unidentified third party to do the work) and, even if it does, arbitrarily many people might ship the broken configuration in the meantime. Merging a change that we know is wrong seems like a bad plan.

Quoted 6 lines
Quoted 1 line

It is better then a broken .service file IMO ;-)

Well, I guess that's where we disagree. Can you elaborate on why having no default NTP server in the metadata is such a crisis, and why none of the other options I mentioned before is a suitable way to deal with the problem?

It is not a problem to have no default NTP server but a broken .service file.

Your alternatives are all good just I used too much time for something I am not using ... the proposed alternatives are good but someone needs to work on them. Just it.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#16 lore raw
In reply to Phil Blundell
Quoted 2 lines · Phil Blundell

a) Make it be a DISTRO setting, punt this problem to the distribution, and let them figure out what to do about it.

IMHO, that's the best idea. Distributions can easily register vendor zones, which is fairly trivial (eg Guacamayo has a zone registered[1] already).

If we created a Yocto-wide zone it would be for non-commercial use only, which might get tricky to convey to everyone using Yocto. By punting this to the distributions, the people who created the zone are in closer communication with the people who might be using the zone commercially.

Ross

[1] https://github.com/Guacamayo/meta-guacamayo/blob/master/meta-guacamayo/recipes-connectivity/connman/guacamayo/settings

#17 lore raw
In reply to Phil Blundell
Quoted 11 lines · Phil Blundell
Quoted 1 line · Martin Ertsås

for now I guess we can just use pool.ntp.org

I'm not sure that this is a very good idea. The pool.ntp.org documentation is fairly explicit that they don't want this:

You must absolutely not use the default pool.ntp.org zone names as the default configuration in your application or appliance.

So how we'll fix it? We need to fix it somehow. So give us an alternative to us.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#18 lore raw
Quoted 6 lines · Otavio Salvador
Quoted 5 lines · Phil Blundell
Quoted 1 line · Martin Ertsås

for now I guess we can just use pool.ntp.org

Quoted 8 lines
Quoted 6 lines

I'm not sure that this is a very good idea. The pool.ntp.org documentation is fairly explicit that they don't want this:

You must absolutely not use the default pool.ntp.org zone names as the default configuration in your application or appliance.

So how we'll fix it? We need to fix it somehow. So give us an alternative to us.

It's not entirely obvious to me that it really does need to be fixed all that urgently, at least not in the default metadata. The sky is probably not going to fall in if you ship a service file which doesn't sync with NTP by default.

In particular, if it's been broken in meta-oe for however long up to this point, I don't entirely understand why moving the recipe to meta-networking suddenly means that fixing this issue is super-important or why the two things need to be done at the same time.

But, anyway, see other email I just sent for a handful of alternatives.

p.