IRQ CORE: irq_work_queue function return value not used.
PATCH 1/1 IRQ CORE: irq_work_queue function return value not used.
From: anish kumar <[email protected]>
As no one is using the return value of irq_work_queue function it is better to just make it void.
--- kernel/irq_work.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
kernel/irq_work.c +2 -3
@@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)* * Can be re-enqueued while the callback is still in progress. */ -bool irq_work_queue (struct irq_work *work) +void irq_work_queue (struct irq_work *work) {if (!irq_work_claim (work)) {/* * Already enqueued, can't do! */ -return false; +return ; }__irq_work_queue (work); -return true; }EXPORT_SYMBOL_GPL (irq_work_queue);
Signature · 1 line
1.7.1
2012/11/3 anish kumar <[email protected]>:
Quoted 16 lines
From: anish kumar <[email protected]>
As no one is using the return value of
irq_work_queuefunction it is better to just make it void.Acked-by Steven Rostedt <[email protected]>Signed-off-by anish kumar <[email protected]>--- kernel/irq_work.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)kernel/irq_work.c +0
-0
kernel/irq_work.c static void __irq_work_queue(struct irq_work *work) · line 82
Quoted 5 lines
kernel/irq_work.c +1
-1@@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)* * Can be re-enqueued while the callback is still in progress. */ -bool irq_work_queue (struct irq_work *work) +void irq_work_queue (struct irq_work *work)
Please also update the headers in include/linux/irq_work.h accordingly.
Thanks.
Quoted 17 lines
kernel/irq_work.c +1
-3{if (!irq_work_claim (work)) {/* * Already enqueued, can't do! */ -return false; +return ; }__irq_work_queue (work); -return true; }EXPORT_SYMBOL_GPL (irq_work_queue); --1.7.1
Quoted 12 lines · Frederic Weisbecker
2012/11/3 anish kumar <[email protected]>:
Quoted 11 lines
From: anish kumar <[email protected]>
As no one is using the return value of
irq_work_queuefunction it is better to just make it void.Acked-by Steven Rostedt <[email protected]>Signed-off-by anish kumar <[email protected]>--- kernel/irq_work.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
Quoted 12 lines
kernel/irq_work.c static void __irq_work_queue(struct irq_work *work) · line 82
Quoted 10 lines
kernel/irq_work.c +1
-1@@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)* * Can be re-enqueued while the callback is still in progress. */ -bool irq_work_queue (struct irq_work *work) +void irq_work_queue (struct irq_work *work)Please also update the headers in
include/linux/irq_work.haccordingly.
I have sent the patch again(some time back).Is it picked up?
http://www.gossamer-threads.com/lists/linux/kernel/1667796
Quoted 20 lines
Thanks.
Quoted 17 lines
kernel/irq_work.c +1
-3{if (!irq_work_claim (work)) {/* * Already enqueued, can't do! */ -return false; +return ; }__irq_work_queue (work); -return true; }EXPORT_SYMBOL_GPL (irq_work_queue); --1.7.1
2013/2/2 anish kumar <[email protected]>:
Quoted 25 lines · Frederic Weisbecker
Quoted 12 lines
2012/11/3 anish kumar <[email protected]>:
Quoted 11 lines
From: anish kumar <[email protected]>
As no one is using the return value of
irq_work_queuefunction it is better to just make it void.Acked-by Steven Rostedt <[email protected]>Signed-off-by anish kumar <[email protected]>--- kernel/irq_work.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)Quoted 12 lines
kernel/irq_work.c static void __irq_work_queue(struct irq_work *work) · line 82
Quoted 10 lines
kernel/irq_work.c +1
-1@@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)* * Can be re-enqueued while the callback is still in progress. */ -bool irq_work_queue (struct irq_work *work) +void irq_work_queue (struct irq_work *work)Please also update the headers in
include/linux/irq_work.haccordingly.
Quoted 2 lines
I have sent the patch again(some time back).Is it picked up?
http://www.gossamer-threads.com/lists/linux/kernel/1667796
Yep, I'm applying it and if it passes basic tests I'll relay it to Ingo.
Thanks.