serial: ifx6x60: Add module parameters to manage the modem status through sysfs.

PATCH In review Jun Chen 3 participants 4 messages Nov 7, 2012 – Nov 16, 2012 TTY layer and serial drivers

Share & tools

Jun Chen

author

2012-11-07 03:04 UTC #0 lore raw

PATCH 1/1 serial: ifx6x60: Add module parameters to manage the modem status through sysfs.

The Medfield Platform implements a recovery procedure consisting in an escalation from simple and light recovery procedures to stronger ones with increased visibility and impact to end-user.After platform find some problem from Modem,such as no response, platform will try do modem warm reset.If several tries failed, platform will try to do modem cold boot procedure.For Modem Cold Boot, AP is responsible to generate blob (binary object containing PIN code and other necessary information). Blob is stored in AP volatile memory. AP decides to read PIN code from cache instead of prompting end-user, and sends it to modem as if end-user had entered it.

This patch add module parameters to manage the modem status through sysfs. Reset_modem can be read and write by user space.When read the reset_modem,user space will get the mdm_reset_state which used to avoid to run twice at once.When set the reset_modem to IFX_COLD_RESET_REQ,modem will do cold reset, other val value will trigger modem reset.

Hangup_reasons used to give one interface to user space to know and clear the modem reset reasons. Now there are four reasons:SPI timeout, modem initiative reset,modem coredump,spi tranfer error.

Cc Bi Chao <[email protected]>

Cc Liu chuansheng <[email protected]>

Signed-off-by Chen Jun <[email protected]>

---
 drivers/tty/serial/Kconfig   |    2 +-
 drivers/tty/serial/ifx6x60.c |  194 +++++++++++++++++++++++++++++++++++++++++-
 drivers/tty/serial/ifx6x60.h |    8 ++
 3 files changed, 202 insertions(+), 2 deletions(-)

drivers/tty/serial/Kconfig +1 -1

index 233fbaa..5ddff34 100644
@@ -1323,7 +1323,7 @@ config SERIAL_ALTERA_UART_CONSOLE
 
 config SERIAL_IFX6X60
         tristate "SPI protocol driver for Infineon 6x60 modem (EXPERIMENTAL)"
-	depends on GPIOLIB && SPI
+	depends on GPIOLIB && SPI && X86_INTEL_MID && INTEL_SCU_IPC
 	help
 	  Support for the IFX6x60 modem devices on Intel MID platforms.

drivers/tty/serial/ifx6x60.c +193 -1

236 lines not on this page · raw message

drivers/tty/serial/ifx6x60.h +8 -0

index e8464ba..ae48d28 100644
@@ -66,6 +66,13 @@
 #define IFX_SPI_POWER_DATA_PENDING	1
 #define IFX_SPI_POWER_SRDY		2
 
+
+/* reasons for hanging up */
+#define	HU_TIMEOUT		1	/* spi timer out */
+#define	HU_RESET			2	/* modem initiative reset */
+#define	HU_COREDUMP		4	/* modem crash coredump */
+#define	HU_RORTUR			8	/* spi transfer error:ROR or TUR */
+
 struct ifx_spi_device {
 	/* Our SPI device */
 	struct spi_device *spi_dev;

@@ -120,6 +127,7 @@ struct ifx_spi_device {
 
 	/* modem reset */
 	unsigned long mdm_reset_state;
+	unsigned long hangup_reasons;
 #define MR_START	0
 #define MR_INPROGRESS	1
 #define MR_COMPLETE	2

Signature · 1 line

1.7.4.1

Alan Cox

Acked-by on v1 1/1

2012-11-07 08:42 UTC #1 lore raw

Quoted 7 lines

Hangup_reasons used to give one interface to user space to know and clear the modem reset reasons. Now there are four reasons:SPI timeout, modem initiative reset,modem coredump,spi tranfer error.
Cc Bi Chao <[email protected]>
Cc Liu chuansheng <[email protected]>
Signed-off-by Chen Jun <[email protected]>

Acked-by Alan Cox <[email protected]>

Greg KH

maintainer

2012-11-16 00:52 UTC #2 lore raw

In reply to Jun Chen

Quoted 22 lines · Jun Chen

The Medfield Platform implements a recovery procedure consisting in an escalation from simple and light recovery procedures to stronger ones with increased visibility and impact to end-user.After platform find some problem from Modem,such as no response, platform will try do modem warm reset.If several tries failed, platform will try to do modem cold boot procedure.For Modem Cold Boot, AP is responsible to generate blob (binary object containing PIN code and other necessary information). Blob is stored in AP volatile memory. AP decides to read PIN code from cache instead of prompting end-user, and sends it to modem as if end-user had entered it.
This patch add module parameters to manage the modem status through sysfs. Reset_modem can be read and write by user space.When read the reset_modem,user space will get the mdm_reset_state which used to avoid to run twice at once.When set the reset_modem to IFX_COLD_RESET_REQ,modem will do cold reset, other val value will trigger modem reset.
Hangup_reasons used to give one interface to user space to know and clear the modem reset reasons. Now there are four reasons:SPI timeout, modem initiative reset,modem coredump,spi tranfer error.
Cc Bi Chao <[email protected]>
Cc Liu chuansheng <[email protected]>
Signed-off-by Chen Jun <[email protected]>
Acked-by Alan Cox <[email protected]>

Quoted 5 lines

---
 drivers/tty/serial/Kconfig   |    2 +-
 drivers/tty/serial/ifx6x60.c |  194 +++++++++++++++++++++++++++++++++++++++++-
 drivers/tty/serial/ifx6x60.h |    8 ++
 3 files changed, 202 insertions(+), 2 deletions(-)

This patch fails to apply, can you please refresh it against my tty-next branch and resend it, keeping Alan's ack on it, so I remember it's there?

thanks,

greg k-h

Chen, Jun D

author

2012-11-16 01:55 UTC #3 lore raw

Hi,Greg,
Got it, I will resend the new patch based on the tty-next branch to Alan again. Thanks!

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Friday, November 16, 2012 8:52 AM
To: Chen, Jun D
Cc: Alan Cox; serial; Gorby, Russ; Liu, Chuansheng; Bi, Chao
Subject: Re: [PATCH] serial: ifx6x60: Add module parameters to manage the modem status through sysfs.

Quoted 22 lines · Jun Chen

The Medfield Platform implements a recovery procedure consisting in an
escalation from simple and light recovery procedures to stronger ones
with increased visibility and impact to end-user.After platform find
some problem from Modem,such as no response, platform will try do
modem warm reset.If several tries failed, platform will try to do
modem cold boot procedure.For Modem Cold Boot, AP is responsible to generate blob (binary object containing PIN code and other necessary information). Blob is stored in AP volatile memory. AP decides to read PIN code from
cache instead of prompting end-user, and sends it to modem as if end-user had entered it.
This patch add module parameters to manage the modem status through sysfs.
Reset_modem can be read and write by user space.When read the
reset_modem,user space will get the mdm_reset_state which used to
avoid to run twice at once.When set the reset_modem to IFX_COLD_RESET_REQ,modem will do cold reset, other val value will trigger modem reset.
Hangup_reasons used to give one interface to user space to know and clear the modem reset reasons. Now there are four reasons:SPI timeout, modem initiative reset,modem coredump,spi tranfer error.
Cc Bi Chao <[email protected]>
Cc Liu chuansheng <[email protected]>
Signed-off-by Chen Jun <[email protected]>
Acked-by Alan Cox <[email protected]>

Quoted 5 lines

---
 drivers/tty/serial/Kconfig   |    2 +-
 drivers/tty/serial/ifx6x60.c |  194 +++++++++++++++++++++++++++++++++++++++++-
 drivers/tty/serial/ifx6x60.h |    8 ++
 3 files changed, 202 insertions(+), 2 deletions(-)

This patch fails to apply, can you please refresh it against my tty-next branch and resend it, keeping Alan's ack on it, so I remember it's there?

thanks,

greg k-h