Skip to contentSkip to conversation

treewide: Kconfig Make EARLY_PRINTK and TTY_PRINTK "depends on" PRINTK

PATCH In review Joe Perches 2 participants 2 messages Nov 13, 2012 – Nov 15, 2012

Subsystems (10)
Arm (32-bit) x86 PowerPC MIPS +6 more subsystems
lore
Share & tools
lore

Joe Perches

author
#0 lore raw

PATCH 1/1 treewide: Kconfig Make EARLY_PRINTK and TTY_PRINTK "depends on" PRINTK

Add a dependency on PRINTK for these 2 CONFIG options

Signed-off-by Joe Perches <[email protected]>

---
Add bcc's for the affected arch maintainers to avoid long recipient list

 arch/alpha/Kconfig.debug      |    2 +-
 arch/arm/Kconfig.debug        |    2 +-
 arch/blackfin/Kconfig.debug   |    1 +
 arch/hexagon/Kconfig          |    1 +
 arch/m68k/Kconfig.debug       |    2 +-
 arch/microblaze/Kconfig.debug |    2 +-
 arch/mips/Kconfig.debug       |    2 +-
 arch/powerpc/Kconfig          |    1 +
 arch/tile/Kconfig.debug       |    1 +
 arch/um/Kconfig.debug         |    1 +
 arch/unicore32/Kconfig.debug  |    1 +
 arch/x86/Kconfig.debug        |    1 +
 drivers/char/Kconfig          |    2 +-
 13 files changed, 13 insertions(+), 6 deletions(-)
arch/alpha/Kconfig.debug +1 -1
index 3f6265f..499d414 100644
@@ -4,7 +4,7 @@ source "lib/Kconfig.debug"
 
 config EARLY_PRINTK
 	bool
-	depends on ALPHA_GENERIC || ALPHA_SRM
+	depends on PRINTK && (ALPHA_GENERIC || ALPHA_SRM)
 	default y
 
 config ALPHA_LEGACY_START_ADDRESS
arch/arm/Kconfig.debug +1 -1
index b0f3857..7decd48 100644
@@ -422,7 +422,7 @@ config DEBUG_LL_INCLUDE
 
 config EARLY_PRINTK
 	bool "Early printk"
-	depends on DEBUG_LL
+	depends on PRINTK && DEBUG_LL
 	help
 	  Say Y here if you want to have an early console using the
 	  kernel low-level debugging functions. Add earlyprintk to your
arch/blackfin/Kconfig.debug +1 -0
index 7959469..2b30f15 100644
@@ -203,6 +203,7 @@ config DEBUG_BFIN_NO_KERN_HWTRACE
 config EARLY_PRINTK
 	bool "Early printk" 
 	default n
+	depends on PRINTK
 	select SERIAL_CORE_CONSOLE
 	help
 	  This option enables special console drivers which allow the kernel
arch/hexagon/Kconfig +1 -0
index 0744f7d..5dabc6d 100644
@@ -58,6 +58,7 @@ config PCI
 
 config EARLY_PRINTK
 	def_bool y
+	depends on PRINTK
 
 config MMU
 	def_bool y
arch/m68k/Kconfig.debug +1 -1
index 87233ac..4188fff 100644
@@ -12,7 +12,7 @@ config BOOTPARAM_STRING
 
 config EARLY_PRINTK
 	bool "Early printk" if EMBEDDED
-	depends on MVME16x || MAC
+	depends on PRINTK && (MVME16x || MAC)
 	default y
 	help
           Write kernel log output directly to a serial port.
arch/microblaze/Kconfig.debug +1 -1
index 012e377..60c4dc5 100644
@@ -10,7 +10,7 @@ source "lib/Kconfig.debug"
 
 config EARLY_PRINTK
 	bool "Early printk function for kernel"
-	depends on SERIAL_UARTLITE_CONSOLE || SERIAL_8250_CONSOLE
+	depends on PRINTK && (SERIAL_UARTLITE_CONSOLE || SERIAL_8250_CONSOLE)
 	default n
 	help
 	  This option turns on/off early printk messages to console.
arch/mips/Kconfig.debug +1 -1
index 5a43aa0..3d783b3 100644
@@ -8,7 +8,7 @@ source "lib/Kconfig.debug"
 
 config EARLY_PRINTK
 	bool "Early printk" if EXPERT
-	depends on SYS_HAS_EARLY_PRINTK
+	depends on PRINTK && SYS_HAS_EARLY_PRINTK
 	default y
 	help
 	  This option enables special console drivers which allow the kernel
arch/powerpc/Kconfig +1 -0
index a902a5c..8e7bf97 100644
@@ -148,6 +148,7 @@ config PPC
 config EARLY_PRINTK
 	bool
 	default y
+	depends on PRINTK
 
 config COMPAT
 	bool
arch/tile/Kconfig.debug +1 -0
index ddbfc33..5d6d3f4 100644
@@ -5,6 +5,7 @@ source "lib/Kconfig.debug"
 config EARLY_PRINTK
 	bool "Early printk" if EXPERT && DEBUG_KERNEL
 	default y
+	depends on PRINTK
 	help
 	  Write kernel log output directly via the hypervisor console.
arch/um/Kconfig.debug +1 -0
index 68205fd..3c9d82d 100644
@@ -31,6 +31,7 @@ config GCOV
 config EARLY_PRINTK
 	bool "Early printk"
 	default y
+	depends on PRINTK
 	---help---
 	  Write kernel log output directly to stdout.
arch/unicore32/Kconfig.debug +1 -0
index 1a36262..98f644c 100644
@@ -18,6 +18,7 @@ config STRICT_DEVMEM
 
 config EARLY_PRINTK
 	def_bool DEBUG_OCD
+	depends on PRINTK
 	help
 	  Write kernel log output directly into the ocd or to a serial port.
arch/x86/Kconfig.debug +1 -0
index b322f12..989e572 100644
@@ -33,6 +33,7 @@ config X86_VERBOSE_BOOTUP
 config EARLY_PRINTK
 	bool "Early printk" if EXPERT
 	default y
+	depends on PRINTK
 	---help---
 	  Write kernel log output directly into the VGA buffer or to a serial
 	  port.
drivers/char/Kconfig +1 -1
index 72bedad..1e91c26 100644
@@ -53,7 +53,7 @@ source "drivers/tty/serial/Kconfig"
 
 config TTY_PRINTK
 	bool "TTY driver to output user messages via printk"
-	depends on EXPERT
+	depends on EXPERT && PRINTK
 	default n
 	---help---
 	  If you say Y here, the support for writing user messages (i.e.
#1 lore raw
Quoted 1 line · Joe Perches

Add a dependency on PRINTK for these 2 CONFIG options

Hmm ... could you please make the changelog more verbose? What exactly implies the hard dependency, please? What can break?

Signature · 2 lines
Jiri Kosina
SUSE Labs