scsi: Sparse fixes
PATCH 1/1 scsi: Sparse fixes
Reduce the number of complaints reported by sparse on the SCSI midlayer.
Signed-off-by Bart Van Assche <[email protected]>
--- drivers/scsi/libiscsi.c | 4 +++- drivers/scsi/scsi_lib.c | 2 ++ drivers/scsi/scsi_sysfs.c | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-)
drivers/scsi/libiscsi.c +3 -1
@@ -1762,6 +1762,8 @@ static void iscsi_tmf_timedout(unsigned long data)static int iscsi_exec_task_mgmt_fn (struct iscsi_conn *conn,struct iscsi_tm *hdr,int age,int timeout) + __releases(&conn->session->lock) + __acquires(&conn->session->lock) {struct iscsi_session *session = conn->session;struct iscsi_task *task;
@@ -2384,7 +2386,7 @@ static void iscsi_prep_tgt_reset_pdu(struct scsi_cmnd *sc, struct iscsi_tm *hdr)* * This will attempt to send a warm target reset. */ -int iscsi_eh_target_reset (struct scsi_cmnd *sc) +static int iscsi_eh_target_reset (struct scsi_cmnd *sc) {struct iscsi_cls_session *cls_session;struct iscsi_session *session;
drivers/scsi/scsi_lib.c +2 -0
@@ -1485,6 +1485,8 @@ static void scsi_softirq_done(struct request *rq)* Lock status: IO request lock assumed to be held when called. */ static void scsi_request_fn (struct request_queue *q) + __releases(q->queue_lock) + __acquires(q->queue_lock) {struct scsi_device *sdev = q->queuedata;struct Scsi_Host *shost;
drivers/scsi/scsi_sysfs.c +2 -2
@@ -197,7 +197,7 @@ show_shost_state(struct device *dev, struct device_attribute *attr, char *buf) }/* DEVICE_ATTR(state) clashes with dev_attr_state for sdev */ -struct device_attribute dev_attr_hstate = +static struct device_attribute dev_attr_hstate =__ATTR (state,S_IRUGO |S_IWUSR , show_shost_state, store_shost_state); static ssize_t
@@ -313,7 +313,7 @@ static struct attribute *scsi_sysfs_shost_attrs[] = { NULL }; -struct attribute_group scsi_shost_attr_group = { +static struct attribute_group scsi_shost_attr_group = { .attrs = scsi_sysfs_shost_attrs, };
Signature · 1 line
1.7.7