Skip to contentSkip to conversation

misc: apds9802als: Fix the logic checking timeout in als_wait_for_data_ready()

PATCH RESEND New Axel Lin 1 participant 1 message Nov 16, 2012 Char and misc drivers

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 misc: apds9802als: Fix the logic checking timeout in als_wait_for_data_ready()

In the case of timeout waiting for data ready, the retry variable is -1. This also fixes a bug: current code returns -ETIMEDOUT if latest retry success ( which means retry is 0 when exiting the while loop ).

---
Resend to Greg's correct email address.

 drivers/misc/apds9802als.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/apds9802als.c +1 -1
index 0314773..94923d2 100644
@@ -68,7 +68,7 @@ static int als_wait_for_data_ready(struct device *dev)
 		ret = i2c_smbus_read_byte_data(client, 0x86);
 	} while (!(ret & 0x80) && retry--);
 
-	if (!retry) {
+	if (retry < 0) {
 		dev_warn(dev, "timeout waiting for data ready\n");
 		return -ETIMEDOUT;
 	}
Signature · 1 line
1.7.9.5