ARM: imx: ehci-imx35: fix host power mask bit
Subsystems (3)
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX35 Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.
--- arch/arm/mach-imx/ehci-imx35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/ehci-imx35.c +1 -1
@@ -30,7 +30,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)
Signature · 1 line
1.7.10.4
Eric Bénard
Acked-byHi Christoph,
Le Fri, 16 Nov 2012 11:53:17 +0100, Christoph Fritz <[email protected]> a ?crit :
Quoted 7 lines
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX35 Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.
Reported-by Michael Burkey <[email protected]>Cc Stable <[email protected]>Signed-off-by Christoph Fritz <[email protected]>
the same problem exists in arch/arm/mach-imx/ehci-imx25.c may you please also fix it in your patch at the same time ?
Thanks
Eric
Quoted 17 lines
--- arch/arm/mach-imx/ehci-imx35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-imx/ehci-imx35.c +1
-1@@ -30,7 +30,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)
PATCH 1/1 ARM: imx: ehci: fix host power mask bit
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.
--- arch/arm/mach-imx/ehci-imx25.c | 2 +- arch/arm/mach-imx/ehci-imx35.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/ehci-imx25.c +1 -1
@@ -30,7 +30,7 @@#define MX25_H1_SIC_SHIFT 21#define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)#define MX25_H1_PP_BIT (1 << 18) -#define MX25_H1_PM_BIT (1 << 8) +#define MX25_H1_PM_BIT (1 << 16)#define MX25_H1_IPPUE_UP_BIT (1 << 7)#define MX25_H1_IPPUE_DOWN_BIT (1 << 6)#define MX25_H1_TLL_BIT (1 << 5)
arch/arm/mach-imx/ehci-imx35.c +1 -1
@@ -30,7 +30,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)
Signature · 1 line
1.7.10.4
PATCH 1/1 ARM: imx: ehci: fix host power mask bit
Quoted 8 lines · Christoph Fritz
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.
Reported-by Michael Burkey <[email protected]>Cc Stable <[email protected]>Signed-off-by Christoph Fritz <[email protected]>Acked-by Eric B?nard <[email protected]>
Applied, thanks
Sascha
Quoted 37 lines
--- arch/arm/mach-imx/ehci-imx25.c | 2 +- arch/arm/mach-imx/ehci-imx35.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-imx/ehci-imx25.c +1
-1@@ -30,7 +30,7 @@#define MX25_H1_SIC_SHIFT 21#define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)#define MX25_H1_PP_BIT (1 << 18) -#define MX25_H1_PM_BIT (1 << 8) +#define MX25_H1_PM_BIT (1 << 16)#define MX25_H1_IPPUE_UP_BIT (1 << 7)#define MX25_H1_IPPUE_DOWN_BIT (1 << 6)#define MX25_H1_TLL_BIT (1 << 5)arch/arm/mach-imx/ehci-imx35.c +1
-1@@ -30,7 +30,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)Signature · 1 line
1.7.10.4
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 ARM: imx: ehci: fix host power mask bit
Great!
Also, be aware that this bug/fix needs to be applied to both the Linux kernel and to BareBox as well.
Thanks,
Michael Burkey
----- Original Message -----
From: "Sascha Hauer" <[email protected]>
To: "Christoph Fritz" <[email protected]>
Cc: "Eric B?nard" <[email protected]>; "Sascha Hauer" <[email protected]>; "Fabio Estevam" <[email protected]>; "Michael Burkey" <[email protected]>; "Greg Kroah-Hartman" <[email protected]>; "Stable" <[email protected]>; "Hans J. Koch" <[email protected]>; "Daniel Mack" <[email protected]>; "Christian Hemp" <[email protected]>; <[email protected]>
Sent: Friday, November 16, 2012 9:55 AM
Subject: Re: [PATCH] ARM: imx: ehci: fix host power mask bit
Quoted 59 lines · Christoph Fritz
Quoted 8 lines
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.
Reported-by Michael Burkey <[email protected]>Cc Stable <[email protected]>Signed-off-by Christoph Fritz <[email protected]>Acked-by Eric B?nard <[email protected]>Applied, thanks
Sascha
Quoted 39 lines
--- arch/arm/mach-imx/ehci-imx25.c | 2 +- arch/arm/mach-imx/ehci-imx35.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-imx/ehci-imx25.c +1
-1@@ -30,7 +30,7 @@#define MX25_H1_SIC_SHIFT 21#define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)#define MX25_H1_PP_BIT (1 << 18) -#define MX25_H1_PM_BIT (1 << 8) +#define MX25_H1_PM_BIT (1 << 16)#define MX25_H1_IPPUE_UP_BIT (1 << 7)#define MX25_H1_IPPUE_DOWN_BIT (1 << 6)#define MX25_H1_TLL_BIT (1 << 5)arch/arm/mach-imx/ehci-imx35.c +1
-1@@ -30,7 +30,7 @@#define MX35_H1_SIC_SHIFT 21#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)#define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16)#define MX35_H1_IPPUE_UP_BIT (1 << 7)#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)#define MX35_H1_TLL_BIT (1 << 5)Signature · 1 line
1.7.10.4Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |