mx28evk: Configure CONFIG_BOOTDELAY to one second

PATCH New Fabio Estevam 6 participants 20 messages Nov 16, 2012 – Nov 21, 2012

lore

Share & tools

lore

Fabio Estevam

author

2012-11-16 15:09 UTC #0 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx28evk.h +1 -1

index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
  */
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 #define CONFIG_BOOTFILE	"uImage"
 #define CONFIG_LOADADDR	0x42000000
 #define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR

Signature · 1 line

1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #1 lore raw

PATCH 2/8 mx53loco: Configure CONFIG_BOOTDELAY to one second

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx53loco.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx53loco.h +1 -1

index a62ea78..37f9d69 100644
@@ -108,7 +108,7 @@
 
 #undef CONFIG_CMD_IMLS
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 
 #define CONFIG_ETHPRIME		"FEC0"

Signature · 1 line

1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #2 lore raw

PATCH 3/8 mx6qsabrelite: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx6qsabrelite.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx6qsabrelite.h +1 -1

index 318f857..759275a 100644
@@ -144,7 +144,7 @@
 
 #undef CONFIG_CMD_IMLS
 
-#define CONFIG_BOOTDELAY	       3
+#define CONFIG_BOOTDELAY	       1
 
 #define CONFIG_PREBOOT                 ""

Signature · 1 line

1.7.9.5

Liu Hui-R64343

2012-11-19 03:28 UTC #3 lore raw

PATCH 3/8 mx6qsabrelite: Configure CONFIG_BOOTDELAY to one second

Quoted 8 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: Friday, November 16, 2012 11:09 PM
To: sbabic at denx.de
Cc: Liu Hui-R64343; u-boot at lists.denx.de; Estevam Fabio-R49496
Subject: [PATCH 3/8] mx6qsabrelite: Configure CONFIG_BOOTDELAY to one second

Quoted 6 lines

From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>

Acked-by Jason Liu <[email protected]>

Quoted 20 lines

---
include/configs/mx6qsabrelite.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/include/configs/mx6qsabrelite.h index 318f857..759275a 100644
include/configs/mx6qsabrelite.h +1 -2
@@ -144,7 +144,7 @@
 
 #undef CONFIG_CMD_IMLS
 
-#define CONFIG_BOOTDELAY	       3
+#define CONFIG_BOOTDELAY	       1
 
 #define CONFIG_PREBOOT                 ""
 
--
1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #4 lore raw

PATCH 4/8 mx6qsabre_common: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx6qsabre_common.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx6qsabre_common.h +1 -1

index 50f3b01..b8621b8 100644
@@ -76,7 +76,7 @@
 #define CONFIG_CMD_BOOTZ
 #undef CONFIG_CMD_IMLS
 
-#define CONFIG_BOOTDELAY               3
+#define CONFIG_BOOTDELAY               1
 
 #define CONFIG_LOADADDR                        0x10800000
 #define CONFIG_SYS_TEXT_BASE           0x17800000

Signature · 1 line

1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #6 lore raw

PATCH 5/8 mx51evk: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx51evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx51evk.h +1 -1

index 89feaed..e8c6618 100644
@@ -149,7 +149,7 @@
 
 #define CONFIG_CMD_DATE
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 
 #define CONFIG_ETHPRIME		"FEC0"

Signature · 1 line

1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #7 lore raw

PATCH 6/8 mx25pdk: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx25pdk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx25pdk.h +1 -1

index a4bd8b0..b5338a0 100644
@@ -130,7 +130,7 @@
 #define CONFIG_CMD_MII
 #define CONFIG_CMD_NET
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 
 #define CONFIG_LOADADDR		0x81000000	/* loadaddr env var */
 #define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR

Signature · 1 line

1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #8 lore raw

PATCH 7/8 mx31pdk: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx31pdk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx31pdk.h +1 -1

index 223b5b0..6572676 100644
@@ -106,7 +106,7 @@
 
 #define CONFIG_BOARD_LATE_INIT
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 
 #define	CONFIG_EXTRA_ENV_SETTINGS					\
 	"bootargs_base=setenv bootargs console=ttymxc0,115200\0"	\

Signature · 1 line

1.7.9.5

Fabio Estevam

author

2012-11-16 15:09 UTC #9 lore raw

PATCH 8/8 mx35pdk: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

One second is enough time for users to react in case they want to stop the booting process.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx35pdk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/mx35pdk.h +1 -1

index d89db7a..44fb1cd 100644
@@ -118,7 +118,7 @@
 #define CONFIG_CMD_EXT2
 #define CONFIG_CMD_FAT
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 
 #define CONFIG_LOADADDR		0x80800000	/* loadaddr env var */

Signature · 1 line

1.7.9.5

Stefano Babic

2012-11-19 07:51 UTC #10 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

In reply to Fabio Estevam

Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +0 -0
index 2916c71..8b89b25 100644

include/configs/mx28evk.h line 244

Quoted 8 lines

include/configs/mx28evk.h +1 -1

@@ -238,7 +238,7 @@
  */
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
 #define CONFIG_BOOTFILE	"uImage"
 #define CONFIG_LOADADDR	0x42000000
 #define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR

Applied (whole series) to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Marek Vasut

2012-11-19 23:52 UTC #11 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Dear Stefano Babic,

Quoted 23 lines · Fabio Estevam

Quoted 22 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +0 -0
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 

Quoted 8 lines

Quoted 6 lines
include/configs/mx28evk.h +1 -1
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.

What about making some generic ... config-mx28.h AND config-fsl.h ... and including those in board-specific configs?

Best regards,
Marek Vasut

Stefano Babic

2012-11-20 15:44 UTC #12 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Quoted 28 lines · Marek Vasut

Dear Stefano Babic,
Quoted 26 lines · Fabio Estevam
Quoted 25 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +1 -1
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1

Quoted 8 lines

Quoted 5 lines
Quoted 3 lines
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.
What about making some generic ... config-mx28.h AND config-fsl.h ... and including those in board-specific configs?

Any clean-up is welcome. Then maybe (and this is not related to i.MX only) we could have a cpu-config, a vendor config and on the top a board config.

#include <cpu-config.h>
#include <vendor-config.h>
#include <board-config.h>

The main problem is that an exception can breaks our castle, and we are constrained to add #undef in board configuration file.

Best regards,
Stefano

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Otavio Salvador

2012-11-20 17:50 UTC #13 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Quoted 42 lines · Stefano Babic

Quoted 28 lines · Marek Vasut
Dear Stefano Babic,
Quoted 26 lines · Fabio Estevam
Quoted 25 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +1 -1
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
-#define CONFIG_BOOTDELAY   3
+#define CONFIG_BOOTDELAY   1
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.
What about making some generic ... config-mx28.h AND config-fsl.h ... and including those in board-specific configs?
Any clean-up is welcome. Then maybe (and this is not related to i.MX only) we could have a cpu-config, a vendor config and on the top a board config.

Quoted 6 lines

#include <cpu-config.h>
#include <vendor-config.h>
#include <board-config.h>
The main problem is that an exception can breaks our castle, and we are constrained to add #undef in board configuration file.

I support this idea; currently I think we ought to have as much as common code by vendor so it is easy to document things and avoid duplication.

Currently we cannot expect a board to have same (or near the same) set of features. Some provide a good default environment, others doesn't.

Signature · 3 lines

Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Marek Vasut

2012-11-20 18:09 UTC #14 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Dear Otavio Salvador,

Quoted 47 lines · Stefano Babic

Quoted 46 lines · Marek Vasut
Quoted 28 lines
Dear Stefano Babic,
Quoted 26 lines · Fabio Estevam
Quoted 25 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +1 -1
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
-#define CONFIG_BOOTDELAY   3
+#define CONFIG_BOOTDELAY   1
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.
What about making some generic ... config-mx28.h AND config-fsl.h ... and including those in board-specific configs?
Any clean-up is welcome. Then maybe (and this is not related to i.MX only) we could have a cpu-config, a vendor config and on the top a board config.
#include <cpu-config.h>
#include <vendor-config.h>
#include <board-config.h>

Quoted 6 lines

Quoted 2 lines
The main problem is that an exception can breaks our castle, and we are constrained to add #undef in board configuration file.
I support this idea; currently I think we ought to have as much as common code by vendor so it is easy to document things and avoid duplication.

WFM

Quoted 2 lines

Currently we cannot expect a board to have same (or near the same) set of features. Some provide a good default environment, others doesn't.

Let's leave ENV out of this discussion. Moreover, this needs to be done in proper incremental steps.

Furthermore, new thread should be started.

Just an idea, to avoid undef in board-files, we can have #ifdef CONFIG... #define CONFIG... #endif constructions in the CPU-specific files. This will allow simple overriding (of course, these files would have to be included at the bottom of the board config file then).

Otavio, any plans to finish u-boot/mx23 soon?

Best regards,
Marek Vasut

Otavio Salvador

2012-11-20 18:19 UTC #15 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Quoted 56 lines · Marek Vasut

Dear Otavio Salvador,
Quoted 47 lines · Stefano Babic
Quoted 46 lines · Marek Vasut
Quoted 28 lines
Dear Stefano Babic,
Quoted 26 lines · Fabio Estevam
Quoted 25 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +1 -1
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
-#define CONFIG_BOOTDELAY   3
+#define CONFIG_BOOTDELAY   1
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.
What about making some generic ... config-mx28.h AND config-fsl.h ... and including those in board-specific configs?
Any clean-up is welcome. Then maybe (and this is not related to i.MX only) we could have a cpu-config, a vendor config and on the top a board config.
#include <cpu-config.h>
#include <vendor-config.h>
#include <board-config.h>
Quoted 6 lines
Quoted 2 lines
The main problem is that an exception can breaks our castle, and we are constrained to add #undef in board configuration file.
I support this idea; currently I think we ought to have as much as common code by vendor so it is easy to document things and avoid duplication.

Quoted 7 lines

WFM
Quoted 2 lines
Currently we cannot expect a board to have same (or near the same) set of features. Some provide a good default environment, others doesn't.
Let's leave ENV out of this discussion. Moreover, this needs to be done in proper incremental steps.

So you prefer it to manage features only, at least for now?

Quoted 1 line

Furthermore, new thread should be started.

Agreed.

Quoted 4 lines

Just an idea, to avoid undef in board-files, we can have #ifdef CONFIG... #define CONFIG... #endif constructions in the CPU-specific files. This will allow simple overriding (of course, these files would have to be included at the bottom of the board config file then).

So basically a global feature-aware setting file.

Quoted 1 line

Otavio, any plans to finish u-boot/mx23 soon?

No reply yet from the guy who got it further. I am almost getting onto it without his patches ...

Signature · 3 lines

Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Marek Vasut

2012-11-20 18:43 UTC #16 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Dear Otavio Salvador,

Quoted 59 lines · Marek Vasut

Quoted 58 lines
Dear Otavio Salvador,
Quoted 47 lines · Stefano Babic
Quoted 46 lines · Marek Vasut
Quoted 28 lines
Dear Stefano Babic,
Quoted 26 lines · Fabio Estevam
Quoted 25 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to stop the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +1 -1
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
-#define CONFIG_BOOTDELAY   3
+#define CONFIG_BOOTDELAY   1
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.
What about making some generic ... config-mx28.h AND config-fsl.h ... and including those in board-specific configs?
Any clean-up is welcome. Then maybe (and this is not related to i.MX only) we could have a cpu-config, a vendor config and on the top a board config.
#include <cpu-config.h>
#include <vendor-config.h>
#include <board-config.h>
Quoted 6 lines
Quoted 2 lines
The main problem is that an exception can breaks our castle, and we are constrained to add #undef in board configuration file.
I support this idea; currently I think we ought to have as much as common code by vendor so it is easy to document things and avoid duplication.
WFM

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Currently we cannot expect a board to have same (or near the same) set of features. Some provide a good default environment, others doesn't.
Let's leave ENV out of this discussion. Moreover, this needs to be done in proper incremental steps.
So you prefer it to manage features only, at least for now?

For now, yes. And let's not do it all in one massive swipe, but rather slowly. First pull out CPU-specific goo, then sep-out manufacturer stuff etc.

Quoted 10 lines

Quoted 1 line
Furthermore, new thread should be started.
Agreed.
Quoted 4 lines
Just an idea, to avoid undef in board-files, we can have #ifdef CONFIG... #define CONFIG... #endif constructions in the CPU-specific files. This will allow simple overriding (of course, these files would have to be included at the bottom of the board config file then).
So basically a global feature-aware setting file.

More or less, yes.

Quoted 4 lines

Quoted 1 line
Otavio, any plans to finish u-boot/mx23 soon?
No reply yet from the guy who got it further. I am almost getting onto it without his patches ...

Yes, I suspect we might have lost him :(

Best regards,
Marek Vasut

Scott Wood

2012-11-20 23:00 UTC #17 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

In reply to Marek Vasut

Quoted 35 lines · Marek Vasut

Dear Stefano Babic,
Quoted 4 lines · Fabio Estevam
Quoted 3 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to
stop
Quoted 19 lines
Quoted 19 lines
the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +0 -0
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
Quoted 8 lines
Quoted 6 lines
include/configs/mx28evk.h +1 -1
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.

Quoted 3 lines

What about making some generic ... config-mx28.h AND config-fsl.h ... and
including those in board-specific configs?

What configuration subset would be applicable to every "fsl" target, including i.MX, mpc83xx, mpc85xx, mpc5xxx, m68k, etc?

-Scott

Marek Vasut

2012-11-21 00:15 UTC #18 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Dear Scott Wood,

Quoted 38 lines · Marek Vasut

Quoted 37 lines
Dear Stefano Babic,
Quoted 4 lines · Fabio Estevam
Quoted 3 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they want to
stop
Quoted 27 lines
Quoted 22 lines
the booting process.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx28evk.h +1 -1
index 2916c71..8b89b25 100644
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
Quoted 3 lines
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.

Quoted 6 lines

Quoted 3 lines
What about making some generic ... config-mx28.h AND config-fsl.h ... and
including those in board-specific configs?
What configuration subset would be applicable to every "fsl" target, including i.MX, mpc83xx, mpc85xx, mpc5xxx, m68k, etc?

That's up to you to think about ... anyway, move it to a separate thread please.

Best regards,
Marek Vasut

Scott Wood

2012-11-21 00:20 UTC #19 lore raw

PATCH 1/8 mx28evk: Configure CONFIG_BOOTDELAY to one second

Quoted 44 lines · Marek Vasut

Dear Scott Wood,
Quoted 7 lines · Marek Vasut
Quoted 6 lines
Dear Stefano Babic,
Quoted 4 lines · Fabio Estevam
Quoted 3 lines
From: Fabio Estevam <[email protected]>
One second is enough time for users to react in case they
want to
Quoted 5 lines
Quoted 5 lines
stop
Quoted 2 lines
Quoted 2 lines
the booting process.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/include/configs/mx28evk.h
Quoted 20 lines
Quoted 20 lines
Quoted 10 lines
Quoted 10 lines
index 2916c71..8b89b25 100644
include/configs/mx28evk.h +0 -0
@@ -238,7 +238,7 @@
 
  */
 
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
 
Quoted 8 lines
Quoted 6 lines
include/configs/mx28evk.h +1 -1
-#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTDELAY	1
#define CONFIG_BOOTFILE "uImage"
#define CONFIG_LOADADDR 0x42000000
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Applied (whole series) to u-boot-imx, thanks.
What about making some generic ... config-mx28.h AND config-fsl.h
...

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
and
including those in board-specific configs?
What configuration subset would be applicable to every "fsl" target, including i.MX, mpc83xx, mpc85xx, mpc5xxx, m68k, etc?
That's up to you to think about ... anyway, move it to a separate thread please.

I think the answer to that question is "nothing" -- and you can change the thread title at any time you wish; I'm not going to go create some unrelated thread to respond to a point that you raised in this thread.

-Scott