Skip to contentSkip to conversation

i.MX25 & 35 usb config bits : fix host power bit

PATCH Applied Christoph Fritz 2 participants 2 messages Nov 16, 2012 – Nov 19, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Christoph Fritz

author
#0 lore raw

PATCH 1/1 i.MX25 & 35 usb config bits : fix host power bit

This patch sets HPM (Host power mask bit) to bit 16 according to i.MX Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.

Reported-by Michael Burkey <[email protected]>
Signed-off-by Christoph Fritz <[email protected]>
---
 arch/arm/mach-imx/include/mach/usb.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/include/mach/usb.h +1 -1
index 9244989..0a88e7f 100644
@@ -4,7 +4,7 @@
 /* configuration bits for i.MX25 and i.MX35 */
 #define MX35_H1_SIC_SHIFT	21
 #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
-#define MX35_H1_PM_BIT		(1 << 8)
+#define MX35_H1_PM_BIT		(1 << 16)
 #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
 #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
 #define MX35_H1_TLL_BIT		(1 << 5)
Signature · 9 lines
1.7.10.4




_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
maintainer Applied
#1 lore raw
Quoted 6 lines · Christoph Fritz

This patch sets HPM (Host power mask bit) to bit 16 according to i.MX Reference Manual. Falsely it was set to bit 8, but this controls pull-up Impedance.

Reported-by Michael Burkey <[email protected]>
Signed-off-by Christoph Fritz <[email protected]>

Applied, thanks

Sascha

Quoted 23 lines
---
 arch/arm/mach-imx/include/mach/usb.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/include/mach/usb.h +1 -1
index 9244989..0a88e7f 100644
@@ -4,7 +4,7 @@
 /* configuration bits for i.MX25 and i.MX35 */
 #define MX35_H1_SIC_SHIFT	21
 #define MX35_H1_SIC_MASK	(0x3 << MX35_H1_SIC_SHIFT)
-#define MX35_H1_PM_BIT		(1 << 8)
+#define MX35_H1_PM_BIT		(1 << 16)
 #define MX35_H1_IPPUE_UP_BIT	(1 << 7)
 #define MX35_H1_IPPUE_DOWN_BIT	(1 << 6)
 #define MX35_H1_TLL_BIT		(1 << 5)
Signature · 1 line
1.7.10.4
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox