build-appliance-image: Simplify fetch/unpack execution
PATCH 1/1 build-appliance-image: Simplify fetch/unpack execution
This provides a slightly neater way of ensuring fetch/unpack get executed (image.bbclass marks them as noexec) since I found the current approach harder to understand at first glance.
---
meta/recipes-core/images/build-appliance-image.bb +4 -4
@@ -68,11 +68,11 @@ fakeroot do_populate_poky_src () { IMAGE_PREPROCESS_COMMAND += "do_populate_poky_src; " -python do_get_poky_src () { - bb.build.exec_func('base_do_fetch', d) - bb.build.exec_func('base_do_unpack', d) +python () { + # Ensure we run these usually noexec tasks + d.delVarFlag("do_fetch", "noexec") + d.delVarFlag("do_unpack", "noexec") } -addtask do_get_poky_src before do_rootfs create_bundle_files () { cd ${WORKDIR}
Quoted 6 lines · Richard Purdie
This provides a slightly neater way of ensuring fetch/unpack get executed (image.bbclass marks them as noexec) since I found the current approach harder to understand at first glance.
Signed-off-by Richard Purdie <[email protected]>
Agreed.
Quoted 10 lines
---
(quoted diff) +0
-0build-appliance-image.bb
index 59ccb98..bf1e585 100644meta/recipes-core/images/build-appliance-image.bb +0
-0@@ -68,11 +68,11 @@ fakeroot do_populate_poky_src () { IMAGE_PREPROCESS_COMMAND += "do_populate_poky_src; "
meta/recipes-core/images/build-appliance-image.bb fakeroot do_populate_poky_src () { · line 76
Quoted 10 lines
meta/recipes-core/images/build-appliance-image.bb +4
-4-python do_get_poky_src () { - bb.build.exec_func('base_do_fetch', d) - bb.build.exec_func('base_do_unpack', d) +python () { + # Ensure we run these usually noexec tasks + d.delVarFlag("do_fetch", "noexec") + d.delVarFlag("do_unpack", "noexec") } -addtask do_get_poky_src before do_rootfs
I'd say for include a comment in code so it is easy to understand why you're drpping the flag.
Quoted 10 lines
meta/recipes-core/images/build-appliance-image.bb +0
-0create_bundle_files () { cd ${WORKDIR}_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br