Skip to contentSkip to conversation

dma_debug: add debug_dma_mapping_error support to architectures that support DMA_DEBUG_API

PATCH In review Shuah Khan 3 participants 7 messages Nov 23, 2012 – Dec 3, 2012

Subsystems (2)
lore
Share & tools
lore

Shuah Khan

author
#0 lore raw

cover dma_debug: add debug_dma_mapping_error support to architectures that support DMA_DEBUG_API

An earlier patch added dma mapping error debug feature to dma_debug infrastructure. References:

https://lkml.org/lkml/2012/10/8/296
https://lkml.org/lkml/2012/11/3/219

The following series of patches adds the call to debug_dma_mapping_error() to architecture specific dma_mapping_error() interfaces on the following architectures that support CONFIG_DMA_API_DEBUG.

arm64
c6x
ia64
microblaze
mips
powerpc
sh
sparc
tile

arm - Change is already in Marek's dma-mapping tree[1]
https://patchwork.kernel.org/patch/1625601/

microblaze - Change is already in linux-next. Including it for completeness linux-next commit f229605441030bcd315c21d97b25889d63ed0130

x86 - done in the first patch that added the feature.

ARM64: dma_debug: add debug_dma_mapping_error support
c6x: dma_debug: add debug_dma_mapping_error support
ia64: dma_debug: add debug_dma_mapping_error support
microblaze: dma-mapping: support debug_dma_mapping_error
mips: dma_debug: add debug_dma_mapping_error support
powerpc: dma_debug: add debug_dma_mapping_error support
sh: dma_debug: add debug_dma_mapping_error support
sparc: dma_debug: add debug_dma_mapping_error support
tile: dma_debug: add debug_dma_mapping_error support

Thanks,
-- Shuah

#1 lore raw

Hello,

Quoted 9 lines · Shuah Khan

An earlier patch added dma mapping error debug feature to dma_debug infrastructure. References:

https://lkml.org/lkml/2012/10/8/296
https://lkml.org/lkml/2012/11/3/219

The following series of patches adds the call to debug_dma_mapping_error() to architecture specific dma_mapping_error() interfaces on the following architectures that support CONFIG_DMA_API_DEBUG.

I've took all the patches to the next-dma-debug branch in my tree, I sorry that You have to wait so long for it. My branch is based on Joerg's dma-debug branch and I've included it for testing in linux-next branch.

Joerg: would You mind if I handle pushing the whole branch to v3.8 via my kernel tree? Those changes should be kept close together to avoid build breaks for bisecting.

Best regards

Signature · 2 lines
Marek Szyprowski
Samsung Poland R&D Center
#2 lore raw
Quoted 7 lines · Marek Szyprowski

I've took all the patches to the next-dma-debug branch in my tree, I sorry that You have to wait so long for it. My branch is based on Joerg's dma-debug branch and I've included it for testing in linux-next branch.

Joerg: would You mind if I handle pushing the whole branch to v3.8 via my kernel tree? Those changes should be kept close together to avoid build breaks for bisecting.

I'll apply the patches to my tree soon enough. But before that I'll wait a little bit longer to give the arch maintainers the chance to add the missing Acked-bys.

Joerg

#3 lore raw
In reply to Marek Szyprowski

Hi Marek,

Quoted 3 lines · Marek Szyprowski

I've took all the patches to the next-dma-debug branch in my tree, I sorry that You have to wait so long for it. My branch is based on Joerg's dma-debug branch and I've included it for testing in linux-next branch.

The patches are now two times in next. One version from my tree and one from yours. Please remove the version from your tree, the patches should go upstream via my dma-debug branch.

Joerg

#4 lore raw
Quoted 11 lines · Joerg Roedel

Hi Marek,

Quoted 3 lines · Marek Szyprowski

I've took all the patches to the next-dma-debug branch in my tree, I sorry that You have to wait so long for it. My branch is based on Joerg's dma-debug branch and I've included it for testing in linux-next branch.

The patches are now two times in next. One version from my tree and one from yours. Please remove the version from your tree, the patches should go upstream via my dma-debug branch.

Ok, I've removed them from my dma-mapping-next tree. Please add/cherry-pick the missing patch for ARM architecture, which I've accidentally already pushed to mainline some time ago and then reverted. See commit 871ae57adc5ed092 (and 697575896670ba).

Best regards

Signature · 2 lines
Marek Szyprowski
Samsung Poland R&D Center
#5 lore raw
In reply to Shuah Khan

Hi Shuah,

Quoted 11 lines · Shuah Khan

x86 - done in the first patch that added the feature.

ARM64: dma_debug: add debug_dma_mapping_error support
c6x: dma_debug: add debug_dma_mapping_error support
ia64: dma_debug: add debug_dma_mapping_error support
microblaze: dma-mapping: support debug_dma_mapping_error
mips: dma_debug: add debug_dma_mapping_error support
powerpc: dma_debug: add debug_dma_mapping_error support
sh: dma_debug: add debug_dma_mapping_error support
sparc: dma_debug: add debug_dma_mapping_error support
tile: dma_debug: add debug_dma_mapping_error support

Have you compile-tested the invididual archs you are changing here?

Joerg

author
#6 lore raw
Quoted 15 lines · Joerg Roedel

Hi Shuah,

Quoted 11 lines · Shuah Khan

x86 - done in the first patch that added the feature.

ARM64: dma_debug: add debug_dma_mapping_error support
c6x: dma_debug: add debug_dma_mapping_error support
ia64: dma_debug: add debug_dma_mapping_error support
microblaze: dma-mapping: support debug_dma_mapping_error
mips: dma_debug: add debug_dma_mapping_error support
powerpc: dma_debug: add debug_dma_mapping_error support
sh: dma_debug: add debug_dma_mapping_error support
sparc: dma_debug: add debug_dma_mapping_error support
tile: dma_debug: add debug_dma_mapping_error support

Quoted 2 lines

Have you compile-tested the invididual archs you are changing here?

Joerg,

Yes I compile tested all of them (except microblaze) on Nov 20th linux_next git. The patch for microblaze is already in linux_next when I tried to apply the patch to Nov 20th linux-next and figured that is already covered and skipped that one.

-- Shuah