Skip to contentSkip to conversation

linux-next: build failure after merge of the powerpc tree

PATCH In review Stephen Rothwell 3 participants 4 messages Nov 28, 2012 – Nov 29, 2012

Subsystems (2)
Linux-next tree Device tree
lore
Share & tools
lore

Stephen Rothwell

author
#0 lore raw

Hi all,

After merging the powerpc tree, next-20121115's build (powerpc allmodconfig) failed like this:

ERROR: ".of_reconfig_notifier_register" [drivers/crypto/nx/nx-compress.ko] undefined!
ERROR: ".of_reconfig_notifier_unregister" [drivers/crypto/nx/nx-compress.ko] undefined!

Caused by commit 1cf3d8b3d24c ("powerpc+of: Add of node/property notification chain for adds and removes").

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#1 lore raw
Quoted 10 lines · Stephen Rothwell

Hi all,

After merging the powerpc tree, next-20121115's build (powerpc allmodconfig) failed like this:

ERROR: ".of_reconfig_notifier_register" [drivers/crypto/nx/nx-compress.ko] undefined!
ERROR: ".of_reconfig_notifier_unregister" [drivers/crypto/nx/nx-compress.ko] undefined!

Caused by commit 1cf3d8b3d24c ("powerpc+of: Add of node/property notification chain for adds and removes").

That nx stuff should just have gone through the powerpc tree... that's not the first time it trips on generic changes because we miss it being in the crypto tree...

Ashley, Nathan, who owns that ? Can you come up with a fixup patch ?

Ben.

#2 lore raw

PATCH 1/1 export of_reconfig_notifier_[register,unregister]

In reply to Stephen Rothwell

The of reconfiguration notification chains should be exported for use by modules.

Signed-off-by Nathan Fontenot <[email protected]>

---

drivers/of/base.c +2 -0
Index: linux-next/drivers/of/base.c
===================================================================
@@ -1282,11 +1282,13 @@
 {
 	return blocking_notifier_chain_register(&of_reconfig_chain, nb);
 }
+EXPORT_SYMBOL_GPL(of_reconfig_notifier_register);
 
 int of_reconfig_notifier_unregister(struct notifier_block *nb)
 {
 	return blocking_notifier_chain_unregister(&of_reconfig_chain, nb);
 }
+EXPORT_SYMBOL_GPL(of_reconfig_notifier_unregister);
 
 int of_reconfig_notify(unsigned long action, void *p)
 {
#3 lore raw

Re: [PATCH] export of_reconfig_notifier_[register,unregister]

Quoted 4 lines · Nathan Fontenot

The of reconfiguration notification chains should be exported for use by modules.

Signed-off-by Nathan Fontenot <[email protected]>

Grant, I'm applying that into the powerpc tree (with a slightly modified subject line). You don't need to add it to your tree at this stage I suspect.

Cheers,
Ben.

Quoted 25 lines

---
Index: linux-next/drivers/of/base.c
===================================================================

drivers/of/base.c +2 -1
@@ -1282,11 +1282,13 @@
 {
 	return blocking_notifier_chain_register(&of_reconfig_chain, nb);
 }
+EXPORT_SYMBOL_GPL(of_reconfig_notifier_register);
 
 int of_reconfig_notifier_unregister(struct notifier_block *nb)
 {
 	return blocking_notifier_chain_unregister(&of_reconfig_chain, nb);
 }
+EXPORT_SYMBOL_GPL(of_reconfig_notifier_unregister);
 
 int of_reconfig_notify(unsigned long action, void *p)
 {
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/