Skip to contentSkip to conversation

staging: echo: remove unused variable

PATCH In review Cong Ding 2 participants 3 messages Dec 4, 2012 – Dec 10, 2012 Staging

lore
Share & tools
lore

Cong Ding

author
#0 lore raw

PATCH 1/1 staging: echo: remove unused variable

the variable j isn't used in the loop

---
 drivers/staging/echo/echo.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/staging/echo/echo.c +1 -2
index ca87ce9..14dfd91 100644
@@ -119,7 +119,6 @@
 static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
 {
 	int i;
-	int j;
 	int offset1;
 	int offset2;
 	int factor;
@@ -142,7 +141,7 @@ static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
 
 	/* asm("st:"); */
 	n = ec->taps;
-	for (i = 0, j = offset2; i < n; i++, j++) {
+	for (i = 0; i < n; i++) {
 		exp = *phist++ * factor;
 		ec->fir_taps16[1][i] += (int16_t) ((exp + (1 << 14)) >> 15);
 	}
Signature · 1 line
1.7.4.5
author
#1 lore raw

ping!

- cong

Quoted 31 lines · Cong Ding

the variable j isn't used in the loop

---
 drivers/staging/echo/echo.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/staging/echo/echo.c +1 -2
index ca87ce9..14dfd91 100644
@@ -119,7 +119,6 @@
 static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
 {
 	int i;
-	int j;
 	int offset1;
 	int offset2;
 	int factor;
@@ -142,7 +141,7 @@ static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
 
 	/* asm("st:"); */
 	n = ec->taps;
-	for (i = 0, j = offset2; i < n; i++, j++) {
+	for (i = 0; i < n; i++) {
 		exp = *phist++ * factor;
 		ec->fir_taps16[1][i] += (int16_t) ((exp + (1 << 14)) >> 15);
 	}
Signature · 1 line
1.7.4.5
#2 lore raw
Quoted 2 lines · Cong Ding

ping!

Calm your buns. :P If you don't hear back from anyone, it probably means that your patch is going to be merged. But you've caught us at a bad moment because the 3.8 merge window is about to open. It could take over a month before someone looks at this. Wait for two weeks after the 3.8-rc1 kernel has been released and then check back on this.

regards,
dan carpenter