Skip to contentSkip to conversation

3com: make 3c59x depend on HAS_IOPORT

PATCH In review Jan Glauber 2 participants 4 messages Dec 5, 2012

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jan Glauber

author
#0 lore raw

PATCH 1/1 3com: make 3c59x depend on HAS_IOPORT

From: Jan Glauber <[email protected]>

The 3com driver for 3c59x requires ioport_map. Since not all architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.

Signed-off-by Jan Glauber <[email protected]>
---
 drivers/net/ethernet/3com/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/3com/Kconfig +1 -1
index bad4fa6..eb56174 100644
@@ -80,7 +80,7 @@ config PCMCIA_3C589
 
 config VORTEX
 	tristate "3c590/3c900 series (592/595/597) \"Vortex/Boomerang\" support"
-	depends on (PCI || EISA)
+	depends on (PCI || EISA) && HAS_IOPORT
 	select NET_CORE
 	select MII
 	---help---
author
#2 lore raw
Quoted 12 lines · David Miller

From: Jan Glauber <[email protected]>
Date: Wed, 05 Dec 2012 15:04:40 +0100

Quoted 6 lines

From: Jan Glauber <[email protected]>

The 3com driver for 3c59x requires ioport_map. Since not all architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.

Signed-off-by Jan Glauber <[email protected]>

Which platforms support PCI or EISA yet do not set HAS_IOPORT?

s390. We wont get support for port I/O in the PCI hardware/firmware layer. (The patches for PCI on s390 are currently in linux-next).

--Jan

maintainer
#3 lore raw

From: Jan Glauber <[email protected]>
Date: Wed, 05 Dec 2012 20:44:26 +0100

Quoted 9 lines · David Miller
Quoted 8 lines

From: Jan Glauber <[email protected]>
Date: Wed, 05 Dec 2012 15:04:40 +0100

Quoted 5 lines

From: Jan Glauber <[email protected]>

The 3com driver for 3c59x requires ioport_map. Since not all architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Jan Glauber <[email protected]>

Which platforms support PCI or EISA yet do not set HAS_IOPORT?

s390. We wont get support for port I/O in the PCI hardware/firmware layer. (The patches for PCI on s390 are currently in linux-next).

Ok, I'll apply this to net-next, thanks.