Skip to contentSkip to conversation

drm/i915: Remove duplicate and unused register #defines in i915_reg.h

PATCH Applied Dexuan Cui 3 participants 3 messages Dec 5, 2012

Subsystems (2)
lore
Share & tools
lore

Dexuan Cui

author
#0 lore raw

PATCH v2 1/1 drm/i915: Remove duplicate and unused register #defines in i915_reg.h

TRANS_DP_VIDEO_AUDIO is not used at all.
The other 3 has duplicated #defines.

---
 drivers/gpu/drm/i915/i915_reg.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +0 -4
index 97fbd9d..e53c58c 100644
@@ -1891,8 +1891,6 @@
 #define   PFIT_SCALING_PILLAR	(2 << 26)
 #define   PFIT_SCALING_LETTER	(3 << 26)
 #define PFIT_PGM_RATIOS	0x61234
-#define   PFIT_VERT_SCALE_MASK			0xfff00000
-#define   PFIT_HORIZ_SCALE_MASK			0x0000fff0
 /* Pre-965 */
 #define		PFIT_VERT_SCALE_SHIFT		20
 #define		PFIT_VERT_SCALE_MASK		0xfff00000
@@ -3815,8 +3813,6 @@
 #define  TRANS_FSYNC_DELAY_HB2  (1<<27)
 #define  TRANS_FSYNC_DELAY_HB3  (2<<27)
 #define  TRANS_FSYNC_DELAY_HB4  (3<<27)
-#define  TRANS_DP_AUDIO_ONLY    (1<<26)
-#define  TRANS_DP_VIDEO_AUDIO   (0<<26)
 #define  TRANS_INTERLACE_MASK   (7<<21)
 #define  TRANS_PROGRESSIVE      (0<<21)
 #define  TRANS_INTERLACED       (3<<21)
Signature · 1 line
1.7.6
Reviewed-by on v2 1/1
#1 lore raw
Quoted 1 line · Dexuan Cui

TRANS_DP_VIDEO_AUDIO is not used at all.

Now you are just opening a can of worms, as none of them are actually used other than as documentation.

Quoted 3 lines

The other 3 has duplicated #defines.

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw
Quoted 10 lines · Chris Wilson
Quoted 1 line · Dexuan Cui

TRANS_DP_VIDEO_AUDIO is not used at all.

Now you are just opening a can of worms, as none of them are actually used other than as documentation.

Quoted 3 lines

The other 3 has duplicated #defines.

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch