Skip to contentSkip to conversation

python-smartpm: Fix build error

PATCH In review Saul Wold 3 participants 5 messages Dec 5, 2012

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 python-smartpm: Fix build error

datadir is normally /usr/share so we don't need to add /share to it.

---
 meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +1 -1
index 254318c..3617fde 100644
@@ -44,7 +44,7 @@ inherit distutils
 
 do_install_append() {
    # Cleanup unused item...
-   rmdir ${D}${datadir}/share
+   rmdir ${D}${datadir}
 
    # We don't support the following items
    rm -rf ${D}${libdir}/python*/site-packages/smart/backends/slack
Signature · 1 line
1.8.0.1
#1 lore raw
Quoted 12 lines · Saul Wold

datadir is normally /usr/share so we don't need to add /share to it.

---
  meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
index 254318c..3617fde 100644

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils · line 47

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +1 -1
@@ -44,7 +44,7 @@ inherit distutils
 
  do_install_append() {
     # Cleanup unused item...
-   rmdir ${D}${datadir}/share
+   rmdir ${D}${datadir}

I believe this is wrong. There are things in /usr/share that we want from smart.

There are docs and locales and associated files...

I believe that was there because an errant "/usr/share/share" directory was generated and that caused problems.

Quoted 4 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
     # We don't support the following items
     rm -rf ${D}${libdir}/python*/site-packages/smart/backends/slack
 
#2 lore raw
Quoted 21 lines · Mark Hatle
Quoted 12 lines · Saul Wold

datadir is normally /usr/share so we don't need to add /share to it.

---
  meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
index 254318c..3617fde 100644

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils · line 47

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +1 -1
@@ -44,7 +44,7 @@ inherit distutils
 
  do_install_append() {
     # Cleanup unused item...
-   rmdir ${D}${datadir}/share
+   rmdir ${D}${datadir}

I believe this is wrong. There are things in /usr/share that we want from smart.

Quoted 4 lines

There are docs and locales and associated files...

I believe that was there because an errant "/usr/share/share" directory was generated and that caused problems.

It really was in /usr/share/share and I've moved this fix to distutils.bbclass in
http://git.openembedded.org/openembedded-core/commit/?id=10457e343b27e63b35e0278b00e9c25106b0cc1b

So rmdir in python-smartpm should be dropped completely... I've fix for that too, but still testing it together with other changes, but will submit that pull-request today.

Cheers,

Quoted 11 lines

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
     # We don't support the following items
     rm -rf ${D}${libdir}/python*/site-packages/smart/backends/slack
 

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 27 lines · Martin Jansa
Quoted 21 lines · Mark Hatle
Quoted 12 lines · Saul Wold

datadir is normally /usr/share so we don't need to add /share to it.

---
   meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
index 254318c..3617fde 100644

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils · line 47

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +1 -1
@@ -44,7 +44,7 @@ inherit distutils
 
   do_install_append() {
      # Cleanup unused item...
-   rmdir ${D}${datadir}/share
+   rmdir ${D}${datadir}

I believe this is wrong. There are things in /usr/share that we want from smart.

Quoted 4 lines

There are docs and locales and associated files...

I believe that was there because an errant "/usr/share/share" directory was generated and that caused problems.

Quoted 7 lines

It really was in /usr/share/share and I've moved this fix to distutils.bbclass in
http://git.openembedded.org/openembedded-core/commit/?id=10457e343b27e63b35e0278b00e9c25106b0cc1b

So rmdir in python-smartpm should be dropped completely... I've fix for that too, but still testing it together with other changes, but will submit that pull-request today.

Ahh, I see.. So yes, the rmdir is simply not needed then and can be removed.

--Mark

Quoted 14 lines

Cheers,

Quoted 11 lines

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
      # We don't support the following items
      rm -rf ${D}${libdir}/python*/site-packages/smart/backends/slack
 

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

author
#4 lore raw
Quoted 36 lines · Mark Hatle
Quoted 35 lines · Martin Jansa
Quoted 23 lines · Mark Hatle
Quoted 13 lines · Saul Wold

datadir is normally /usr/share so we don't need to add /share to it.

---
   meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
index 254318c..3617fde 100644

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils · line 47

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +1 -1
@@ -44,7 +44,7 @@ inherit distutils
 
   do_install_append() {
      # Cleanup unused item...
-   rmdir ${D}${datadir}/share
+   rmdir ${D}${datadir}

I believe this is wrong. There are things in /usr/share that we want from smart.

Quoted 5 lines

There are docs and locales and associated files...

I believe that was there because an errant "/usr/share/share" directory was
generated and that caused problems.

It really was in /usr/share/share and I've moved this fix to distutils.bbclass in
http://git.openembedded.org/openembedded-core/commit/?id=10457e343b27e63b35e0278b00e9c25106b0cc1b

Quoted 7 lines
Quoted 3 lines

So rmdir in python-smartpm should be dropped completely... I've fix for that too, but still testing it together with other changes, but will submit that pull-request today.

Ahh, I see.. So yes, the rmdir is simply not needed then and can be removed.

Ok, great, so I guess a patch from Martin shortly will resolved this, I want to get a clean build with MUT for RP to pull this stuff.

Thanks
Sau!

Quoted 24 lines

--Mark

Quoted 14 lines

Cheers,

Quoted 11 lines

meta/recipes-devtools/python/python-smartpm_1.4.1.bb inherit distutils

Quoted 5 lines
meta/recipes-devtools/python/python-smartpm_1.4.1.bb +0 -0
      # We don't support the following items
      rm -rf ${D}${libdir}/python*/site-packages/smart/backends/slack
 

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core