Skip to contentSkip to conversation

fix initializer entry defined twice issue

PATCH In review Cong Ding 2 participants 4 messages Dec 6, 2012 – Dec 7, 2012

Subsystems (3)
lore
Share & tools
lore

Cong Ding

author
#0 lore raw

PATCH 1/1 fix initializer entry defined twice issue

the ".config_intr" is defined twice in both line 208 and 212.

---
 drivers/net/phy/smsc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/phy/smsc.c +0 -1
index 16dceed..5cee6bd 100644
@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
 	/* basic functions */
 	.config_aneg	= genphy_config_aneg,
 	.read_status	= lan87xx_read_status,
-	.config_intr	= smsc_phy_config_intr,
 
 	/* IRQ related */
 	.ack_interrupt	= smsc_phy_ack_interrupt,
Signature · 1 line
1.7.4.5
#1 lore raw
Quoted 12 lines · Cong Ding

the ".config_intr" is defined twice in both line 208 and 212.

---
  drivers/net/phy/smsc.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/phy/smsc.c +0 -0
index 16dceed..5cee6bd 100644

drivers/net/phy/smsc.c static struct phy_driver smsc_phy_driver[] = { · line 210

Quoted 7 lines
drivers/net/phy/smsc.c +0 -1
@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
  	/* basic functions */
  	.config_aneg	= genphy_config_aneg,
  	.read_status	= lan87xx_read_status,
-	.config_intr	= smsc_phy_config_intr,
 
  	/* IRQ related */
  	.ack_interrupt	= smsc_phy_ack_interrupt,

Hi Cong,

That looks like a mistake from my previous patch to that file. Copy and paste fail.

The line should read:
.config_init = smsc_phy_config_init,

I can submit a patch once I get off work unless you beat me to it.

regards,
Patrick

author
#2 lore raw
Quoted 22 lines · Patrick Trantham
Quoted 12 lines · Cong Ding

the ".config_intr" is defined twice in both line 208 and 212.

---
 drivers/net/phy/smsc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/phy/smsc.c +0 -0
index 16dceed..5cee6bd 100644

drivers/net/phy/smsc.c static struct phy_driver smsc_phy_driver[] = { · line 209

Quoted 6 lines
drivers/net/phy/smsc.c +0 -1
@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
 	/* basic functions */
 	.config_aneg	= genphy_config_aneg,
 	.read_status	= lan87xx_read_status,
-	.config_intr	= smsc_phy_config_intr,
 	/* IRQ related */
 	.ack_interrupt	= smsc_phy_ack_interrupt,

Hi Cong,

Quoted 7 lines

That looks like a mistake from my previous patch to that file. Copy and paste fail.

The line should read:
.config_init = smsc_phy_config_init,

I can submit a patch once I get off work unless you beat me to it.

Thanks for the note. It's better that you submit a patch together with your code.

- cong

#3 lore raw
Quoted 25 lines · Cong Ding
Quoted 24 lines · Patrick Trantham
Quoted 12 lines · Cong Ding

the ".config_intr" is defined twice in both line 208 and 212.

---
  drivers/net/phy/smsc.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/phy/smsc.c +0 -0
index 16dceed..5cee6bd 100644

drivers/net/phy/smsc.c static struct phy_driver smsc_phy_driver[] = { · line 209

Quoted 6 lines
drivers/net/phy/smsc.c +0 -1
@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
  	/* basic functions */
  	.config_aneg	= genphy_config_aneg,
  	.read_status	= lan87xx_read_status,
-	.config_intr	= smsc_phy_config_intr,
  	/* IRQ related */
  	.ack_interrupt	= smsc_phy_ack_interrupt,

Hi Cong,

That looks like a mistake from my previous patch to that file. Copy and paste fail.

Quoted 8 lines
Quoted 4 lines

The line should read:
.config_init = smsc_phy_config_init,

I can submit a patch once I get off work unless you beat me to it.

Thanks for the note. It's better that you submit a patch together with your code.

- cong

Patch submitted, thanks for pointing this out!

- Patrick