lib/parser.c: Fix up comments for valid return values from match_number

PATCH New Namjae Jeon 1 participant 1 message Dec 8, 2012 Library code

lore

Share & tools

lore

Namjae Jeon

author

2012-12-08 05:59 UTC #0 lore raw

PATCH 1/1 lib/parser.c: Fix up comments for valid return values from match_number

From: Namjae Jeon <[email protected]>

Since, match_number as valid return values as -ENOMEM, -EINVAL and -ERANGE. So, for all the functions calling match_number, the return value should include these values. Fix up the comments to reflect the correct values.

Signed-off-by Namjae Jeon <[email protected]>

Signed-off-by Amit Sahrawat <[email protected]>

---
 lib/parser.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

lib/parser.c +3 -3

index 52cfa69..807b2aa 100644
@@ -157,7 +157,7 @@ static int match_number(substring_t *s, int *result, int base)
  *
  * Description: Attempts to parse the &substring_t @s as a decimal integer. On
  * success, sets @result to the integer represented by the string and returns 0.
- * Returns either -ENOMEM or -EINVAL on failure.
+ * Returns -ENOMEM, -EINVAL, or -ERANGE on failure.
  */
 int match_int(substring_t *s, int *result)
 {

@@ -171,7 +171,7 @@ int match_int(substring_t *s, int *result)
  *
  * Description: Attempts to parse the &substring_t @s as an octal integer. On
  * success, sets @result to the integer represented by the string and returns
- * 0. Returns either -ENOMEM or -EINVAL on failure.
+ * 0. Returns -ENOMEM, -EINVAL, or -ERANGE on failure.
  */
 int match_octal(substring_t *s, int *result)
 {

@@ -185,7 +185,7 @@ int match_octal(substring_t *s, int *result)
  *
  * Description: Attempts to parse the &substring_t @s as a hexadecimal integer.
  * On success, sets @result to the integer represented by the string and
- * returns 0. Returns either -ENOMEM or -EINVAL on failure.
+ * returns 0. Returns -ENOMEM, -EINVAL, or -ERANGE on failure.
  */
 int match_hex(substring_t *s, int *result)
 {

Signature · 1 line

1.7.9.5