regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel
PATCH 1/1 regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel
BUCK2 has the update_bit setting, but current code does not set update_bit in pm8607_set_voltage_sel.
Signed-off-by Axel Lin <[email protected]>
---
Hi Haojian,
I don't have the datasheet, can you check if this patch is correct or not? Thanks,
Axel
drivers/regulator/88pm8607.c | 1 + 1 file changed, 1 insertion(+)
drivers/regulator/88pm8607.c +1 -0
@@ -236,6 +236,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)return ret;switch (info->desc.id) {case PM8607_ID_BUCK1 : +case PM8607_ID_BUCK2 :case PM8607_ID_BUCK3 : ret = pm860x_set_bits(info->i2c, info->update_reg, 1 << info->update_bit,
Signature · 1 line
1.7.9.5
Quoted 25 lines · Axel Lin
BUCK2 has the
update_bitsetting, but current code does not setupdate_bitinpm8607_set_voltage_sel.Signed-off-by Axel Lin <[email protected]>---
Hi Haojian,
I don't have the datasheet, can you check if this patch is correct or not? Thanks,
Axeldrivers/regulator/88pm8607.c | 1 + 1 file changed, 1 insertion(+)drivers/regulator/88pm8607.c +1
-1@@ -236,6 +236,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)return ret;switch (info->desc.id) {case PM8607_ID_BUCK1 : +case PM8607_ID_BUCK2 :case PM8607_ID_BUCK3 : ret = pm860x_set_bits(info->i2c, info->update_reg, 1 << info->update_bit, --
Quoted 4 lines
1.7.9.5
It's unnecessary since BUCK2 is designed to control voltage of CP domain. If CP wants to scale frequency,
it could change BUCK2. Linux won't run in CP side. It only runs in AP side. So we don't need to control
BUCK2 in AP side.