m28evk/mx28evk: fix nand_update_full

- commit 418396e212b59bf907dbccad997ff50f7eb61b16 chenged the behaviour of nand write.raw which now takes a pagecount as a parameter and no more the size to be written so update the default environment of these boards to fix the problem.
- tested on a mx28evk with a 4k page NAND and on a custom board with a 2k page NAND.

Signed-off-by Eric B?nard <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Fabio Estevam <[email protected]>

- commit 418396e212b59bf907dbccad997ff50f7eb61b16 chenged the behaviour
of nand write.raw which now takes a pagecount as a parameter and no more
the size to be written so update the default environment of these boards
to fix the problem.

Quoted 7 lines

- commit 418396e212b59bf907dbccad997ff50f7eb61b16 chenged the behaviour
of nand write.raw which now takes a pagecount as a parameter and no more
the size to be written so update the default environment of these boards
to fix the problem.

It never really took the size to be written -- the size was implicitly one page before. It looks like there may have been a bug in the old code, where common code expected a size to be there anyway, even though it was ignored other than for error checking.

Hi Scott,

Le Mon, 10 Dec 2012 16:59:23 -0600,
Scott Wood <[email protected]> a ?crit :

Quoted 4 lines · Eric B?nard

Quoted 3 lines

- commit 418396e212b59bf907dbccad997ff50f7eb61b16 chenged the behaviour
of nand write.raw which now takes a pagecount as a parameter and

no

Quoted 6 lines

Quoted 4 lines

more
the size to be written so update the default environment of these boards
to fix the problem.

It never really took the size to be written -- the size was

implicitly

Quoted 2 lines

one page before. It looks like there may have been a bug in the old code, where common code expected a size to be there anyway, even

though

Quoted 2 lines

it was ignored other than for error checking.

true, before the size was forced to one page :
rwsize = nand->writesize + nand->oobsize;
now it's rwsize = pagecount * (nand->writesize + nand->oobsize); so the size parameter in this script was ignored and now leads to a wrong rwsize calculation.

Do you want me to rephrase the commit log or will you take it as is ?

- since commit 418396e212b59bf907dbccad997ff50f7eb61b16 nand write.raw can take the number of page to be written as an argument. nand_update_full
is passing the size (in bytes) to nand write.raw. This value was previously
ignored but now breaks the write.
- this patch updates the default environment of these boards to provide a
pagecount instead of a size to nand write.raw.
- tested on a mx28evk with a 4k page NAND and on a custom board with a 2k page NAND.

Signed-off-by Eric B?nard <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Fabio Estevam <[email protected]>

---
 include/configs/m28evk.h  |    2 +-
 include/configs/mx28evk.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Quoted 12 lines

- since commit 418396e212b59bf907dbccad997ff50f7eb61b16 nand write.raw can take the number of page to be written as an argument. nand_update_full
is passing the size (in bytes) to nand write.raw. This value was previously
ignored but now breaks the write.
- this patch updates the default environment of these boards to provide a
pagecount instead of a size to nand write.raw.
- tested on a mx28evk with a 4k page NAND and on a custom board with a 2k page NAND.

Quoted 8 lines

Signed-off-by Eric B?nard <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Fabio Estevam <[email protected]>

---

 include/configs/m28evk.h  |    2 +-
 include/configs/mx28evk.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Marek, can you ack this?

There is still a change in behavior in that before 418396e212b59bf907dbccad997ff50f7eb61b16 it only wrote one page (since that's all the write.raw command ever did) but with this patch it will write ${fcb_sz} pages. I assume the new behavior is correct?