Skip to contentSkip to conversation

A few fixes for Reatek codecs

PATCH New Takashi Iwai 1 participant 3 messages Dec 17, 2012 Sound

lore
Share & tools
lore
#0 lore raw

cover A few fixes for Reatek codecs

Hi,

here is a patch series for fixing some obvious errors I've overseen for Realtek codecs. It'll be queued for 3.8-rc1.

Takashi

#1 lore raw

PATCH 1/2 ALSA: hda - Set codec->single_adc_amp flag for Realtek codecs

It turned out that Realtek codecs (ALC260, etc) with input amps in audio-input widgets don't handle the multiple individual input amps. Thus we need to set codec->single_adc_amp flag for them in general.

---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
index 7743775..16d210a 100644
@@ -4373,6 +4373,7 @@ static int alc_alloc_spec(struct hda_codec *codec, hda_nid_t mixer_nid)
 	if (!spec)
 		return -ENOMEM;
 	codec->spec = spec;
+	codec->single_adc_amp = 1;
 	spec->mixer_nid = mixer_nid;
 	snd_hda_gen_init(&spec->gen);
 	snd_array_init(&spec->kctls, sizeof(struct snd_kcontrol_new), 32);
Signature · 1 line
1.8.0.1
#2 lore raw

PATCH 2/2 ALSA: hda - Fix the wrong pincaps set in ALC861VD dallas/hp fixup

In reply to Takashi Iwai

The workaround to force VREF50 for dallas/hp model with ALC861VD was introduced in commit 8fdcb6fe4204bdb4c6991652717ab5063751414e, but it contained wrong pincap override bits.

This patch fixes to exclude VREF80 pincap bit correctly.

---
 sound/pci/hda/patch_realtek.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/patch_realtek.c +2 -2
index 16d210a..6ee3459 100644
@@ -6570,8 +6570,8 @@ static void alc861vd_fixup_dallas(struct hda_codec *codec,
 				  const struct alc_fixup *fix, int action)
 {
 	if (action == ALC_FIXUP_ACT_PRE_PROBE) {
-		snd_hda_override_pin_caps(codec, 0x18, 0x00001714);
-		snd_hda_override_pin_caps(codec, 0x19, 0x0000171c);
+		snd_hda_override_pin_caps(codec, 0x18, 0x00000734);
+		snd_hda_override_pin_caps(codec, 0x19, 0x0000073c);
 	}
 }
 
Signature · 1 line
1.8.0.1