Skip to contentSkip to conversation

n_gsm.c: add tx_lock in gsm_send

PATCH In review Xiao Jin 2 participants 2 messages Dec 20, 2012 TTY layer and serial drivers

lore
Share & tools
lore

Xiao Jin

author
#0 lore raw

PATCH 1/1 n_gsm.c: add tx_lock in gsm_send

From: xiaojin <[email protected]>
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send

All the call to gsm->output should be in the tx_lock, that could avoid potential race from MUX level. But we have no tx_lock in gsm_send.

This patch is to add tx_lock in gsm_send.

---
 drivers/tty/n_gsm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/tty/n_gsm.c +0 -0
index dcc0430..4572117 100644
@@ -573,6 +573,7 @@ static void gsm_send(struct gsm_mux *gsm, int addr,

int cr, int control)
int len;
u8 cbuf[10];
u8 ibuf[3];
+ unsigned long flags;

switch (gsm->encoding) {
case 0:
@@ -602,7 +603,9 @@ static void gsm_send(struct gsm_mux *gsm, int addr, int cr, int control)
WARN_ON(1);
return;
}
+ spin_lock_irqsave(&gsm->tx_lock, flags);
gsm->output(gsm, cbuf, len);
+ spin_unlock_irqrestore(&gsm->tx_lock, flags);
gsm_print_packet("-->", addr, cr, control, NULL, 0);
}

Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · On Wed, 19 Dec 2012 13:16:10 +0800 Xiao Jin <[email protected]> wrote:

From: xiaojin <[email protected]>
Date: Wed, 19 Dec 2012 11:53:43 +0800
Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send

All the call to gsm->output should be in the tx_lock, that could avoid potential race from MUX level. But we have no tx_lock in gsm_send.

This patch is to add tx_lock in gsm_send.