Skip to contentSkip to conversation

drm/i915: fix flags in dma buf exporting

PATCH Applied Dave Airlie 5 participants 6 messages Dec 20, 2012 – Dec 21, 2012

Subsystems (5)
DRM drivers Staging Intel i915 Arm Samsung Exynos +1 more subsystems
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: fix flags in dma buf exporting

From: Dave Airlie <[email protected]>

As pointed out by Seung-Woo Kim this should have been passing flags like nouveau/radeon have.

Cc [email protected]
Signed-off-by Dave Airlie <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem_dmabuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_dmabuf.c +1 -1
index 773ef77..7be4241 100644
@@ -226,7 +226,7 @@ struct dma_buf *i915_gem_prime_export(struct drm_device *dev,
 {
 	struct drm_i915_gem_object *obj = to_intel_bo(gem_obj);
 
-	return dma_buf_export(obj, &i915_dmabuf_ops, obj->base.size, 0600);
+	return dma_buf_export(obj, &i915_dmabuf_ops, obj->base.size, flags);
 }
 
 static int i915_gem_object_get_pages_dmabuf(struct drm_i915_gem_object *obj)
Signature · 1 line
1.8.0.2
maintainer
#1 lore raw

PATCH 1/2 drm/exynos: fix flags in dma buf exporting

This patch fixes flags passed to dma buf exporting.

Signed-off-by Seung-Woo Kim <[email protected]>
Signed-off-by Kyungmin.park <[email protected]>

---
I found exynos drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch.

 drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c +1 -1
index fae1f2e..8cb8c56 100644
@@ -185,7 +185,7 @@ struct dma_buf *exynos_dmabuf_prime_export(struct drm_device *drm_dev,
 	struct exynos_drm_gem_obj *exynos_gem_obj = to_exynos_gem_obj(obj);
 
 	return dma_buf_export(exynos_gem_obj, &exynos_dmabuf_ops,
-				exynos_gem_obj->base.size, 0600);
+				exynos_gem_obj->base.size, flags);
 }
 
 struct drm_gem_object *exynos_dmabuf_prime_import(struct drm_device *drm_dev,
Signature · 1 line
1.7.4.1
maintainer Applied
#2 lore raw

Re: [PATCH 1/2] drm/exynos: fix flags in dma buf exporting

Applied.

Thanks,
Inki Dae

2012/12/20 Seung-Woo Kim <[email protected]>

Quoted 31 lines

This patch fixes flags passed to dma buf exporting.

Signed-off-by Seung-Woo Kim <[email protected]>
Signed-off-by Kyungmin.park <[email protected]>

---
I found exynos drm also sends wrong flag for dma buf exporting. So I send this
based on drm-fixes branch.

 drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c +1 -1
index fae1f2e..8cb8c56 100644
@@ -185,7 +185,7 @@ struct dma_buf *exynos_dmabuf_prime_export(struct
 drm_device *drm_dev,
        struct exynos_drm_gem_obj *exynos_gem_obj = to_exynos_gem_obj(obj);
 
        return dma_buf_export(exynos_gem_obj, &exynos_dmabuf_ops,
-                               exynos_gem_obj->base.size, 0600);
+                               exynos_gem_obj->base.size, flags);
 }

struct drm_gem_object *exynos_dmabuf_prime_import(struct drm_device
*drm_dev,
--
1.7.4.1

Quoted 5 lines

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#3 lore raw

PATCH 2/2 drm/omap: fix flags in dma buf exporting

In reply to Dave Airlie

This patch fixes flags passed to dma buf exporting.

Signed-off-by Seung-Woo Kim <[email protected]>
Cc Rob Clark <[email protected]>

---
I found omap drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch.

 drivers/staging/omapdrm/omap_gem_dmabuf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/omapdrm/omap_gem_dmabuf.c +1 -1
index c6f3ef6..e5ffe72 100644
@@ -194,7 +194,7 @@ struct dma_buf_ops omap_dmabuf_ops = {
 struct dma_buf * omap_gem_prime_export(struct drm_device *dev,
 		struct drm_gem_object *obj, int flags)
 {
-	return dma_buf_export(obj, &omap_dmabuf_ops, obj->size, 0600);
+	return dma_buf_export(obj, &omap_dmabuf_ops, obj->size, flags);
 }
 
 struct drm_gem_object * omap_gem_prime_import(struct drm_device *dev,
Signature · 1 line
1.7.4.1
#4 lore raw

Re: [PATCH 2/2] drm/omap: fix flags in dma buf exporting

Quoted 4 lines · Seung-Woo Kim

This patch fixes flags passed to dma buf exporting.

Signed-off-by Seung-Woo Kim <[email protected]>
Cc Rob Clark <[email protected]>

Probably should go to GregKH, unless he doesn't mind this going in via drm tree (it won't conflict with any other recent patches). Either way,

Signed-off-by Rob Clark <[email protected]>
Quoted 27 lines

---
I found omap drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch.

 drivers/staging/omapdrm/omap_gem_dmabuf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/omapdrm/omap_gem_dmabuf.c +1 -2
index c6f3ef6..e5ffe72 100644
@@ -194,7 +194,7 @@ struct dma_buf_ops omap_dmabuf_ops = {
 struct dma_buf * omap_gem_prime_export(struct drm_device *dev,
                struct drm_gem_object *obj, int flags)
 {
-       return dma_buf_export(obj, &omap_dmabuf_ops, obj->size, 0600);
+       return dma_buf_export(obj, &omap_dmabuf_ops, obj->size, flags);
 }
 
 struct drm_gem_object * omap_gem_prime_import(struct drm_device *dev,
--

1.7.4.1

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel