mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform

PATCH In review Arend van Spriel 4 participants 8 messages Jan 4, 2013 – Jan 21, 2013

Subsystems (2)

MIPS Broadcom BCM47XX MIPS architecture

lore

Share & tools

lore

Arend van Spriel

author

2013-01-04 18:11 UTC #0 lore raw

PATCH 1/1 mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform

The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:

scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct

	dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
	dependencies (SSB_POSSIBLE && SSB && GPIOLIB)

which subsequently results in compile errors.

Cc Hauke Mehrtens <[email protected]>

Signed-off-by Arend van Spriel <[email protected]>

---
Fixing a Kconfig issue in our nightly Jenkins build.

Gr. AvS

---
 arch/mips/bcm47xx/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

arch/mips/bcm47xx/Kconfig +3 -0

index d7af29f..ba61192 100644
@@ -8,8 +8,10 @@ config BCM47XX_SSB
 	select SSB_DRIVER_EXTIF
 	select SSB_EMBEDDED
 	select SSB_B43_PCI_BRIDGE if PCI
+	select SSB_DRIVER_PCICORE if PCI
 	select SSB_PCICORE_HOSTMODE if PCI
 	select SSB_DRIVER_GPIO
+	select GPIOLIB
 	default y
 	help
 	 Add support for old Broadcom BCM47xx boards with Sonics Silicon Backplane support.

@@ -25,6 +27,7 @@ config BCM47XX_BCMA
 	select BCMA_HOST_PCI if PCI
 	select BCMA_DRIVER_PCI_HOSTMODE if PCI
 	select BCMA_DRIVER_GPIO
+	select GPIOLIB
 	default y
 	help
 	 Add support for new Broadcom BCM47xx boards with Broadcom specific Advanced Microcontroller Bus.

Signature · 1 line

1.7.10.4

Hauke Mehrtens

maintainer Acked-by on v1 1/1

2013-01-04 19:48 UTC #1 lore raw

Quoted 7 lines · Arend van Spriel

The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct

Quoted 8 lines

	dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
	dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
which subsequently results in compile errors.
Cc Hauke Mehrtens <[email protected]>
Signed-off-by Arend van Spriel <[email protected]>

Acked-by Hauke Mehrtens <[email protected]>

Quoted 4 lines

---
Fixing a Kconfig issue in our nightly Jenkins build.
Gr. AvS

Thanks for spotting and fixing this.

This should also go into 3.8.
This was a missing piece of a fix by Geert Uytterhoeven for an other bug in Kconfig of bcma and ssb:
https://lkml.org/lkml/2012/12/16/68
https://lkml.org/lkml/2012/12/16/69

Hauke

Sergei Shtylyov

2013-01-05 11:33 UTC #2 lore raw

In reply to Arend van Spriel

Hello.

Quoted 28 lines · Arend van Spriel

The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
	dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
	dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
which subsequently results in compile errors.
Cc Hauke Mehrtens <[email protected]>
Signed-off-by Arend van Spriel <[email protected]>
---
Fixing a Kconfig issue in our nightly Jenkins build.
Gr. AvS
---
  arch/mips/bcm47xx/Kconfig |    3 +++
  1 file changed, 3 insertions(+)
arch/mips/bcm47xx/Kconfig +0 -0
index d7af29f..ba61192 100644

arch/mips/bcm47xx/Kconfig config BCM47XX_SSB · line 11

Quoted 4 lines

arch/mips/bcm47xx/Kconfig +1 -0

@@ -8,8 +8,10 @@ config BCM47XX_SSB
  	select SSB_DRIVER_EXTIF
  	select SSB_EMBEDDED
  	select SSB_B43_PCI_BRIDGE if PCI
+	select SSB_DRIVER_PCICORE if PCI

This change doesn';t seem to be documented in your changelog. Maybe it's
worth another patch?

WBR, Sergei

Arend van Spriel

author

2013-01-06 21:14 UTC #3 lore raw

Quoted 40 lines · Sergei Shtylyov

Hello.
Quoted 28 lines · Arend van Spriel
The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
    dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
    dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
which subsequently results in compile errors.
Cc Hauke Mehrtens <[email protected]>
Signed-off-by Arend van Spriel <[email protected]>
---
Fixing a Kconfig issue in our nightly Jenkins build.
Gr. AvS
---
  arch/mips/bcm47xx/Kconfig |    3 +++
  1 file changed, 3 insertions(+)
arch/mips/bcm47xx/Kconfig +0 -0
index d7af29f..ba61192 100644
arch/mips/bcm47xx/Kconfig config BCM47XX_SSB · line 11
Quoted 4 lines
arch/mips/bcm47xx/Kconfig +1 -0
@@ -8,8 +8,10 @@ config BCM47XX_SSB
      select SSB_DRIVER_EXTIF
      select SSB_EMBEDDED
      select SSB_B43_PCI_BRIDGE if PCI
+    select SSB_DRIVER_PCICORE if PCI
This change doesn';t seem to be documented in your changelog. Maybe
it's worth another patch?

Quoted 2 lines

WBR, Sergei

Very observant. ;-) Yes. After fixing the other ones I got a warning on that one. I could resubmit the change with a more generic description or split it up as you suggest.

Ralf,

Please advice.

Gr. AvS

Ralf Baechle

2013-01-16 14:50 UTC #4 lore raw

Quoted 6 lines · Arend van Spriel

Quoted 5 lines
This change doesn';t seem to be documented in your changelog. Maybe
it's worth another patch?
WBR, Sergei

Quoted 7 lines

Very observant. ;-) Yes. After fixing the other ones I got a warning on that one. I could resubmit the change with a more generic description or split it up as you suggest.
Ralf,
Please advice.

For simplicity's sake I'm going to split this myself BUT putting changes that are not explained in changelog comments is a good way to get your dear maintainer grumpy :)

Ralf

Arend van Spriel

author

2013-01-21 09:41 UTC #5 lore raw

Quoted 12 lines · Ralf Baechle

Quoted 10 lines · Arend van Spriel
Quoted 5 lines
This change doesn';t seem to be documented in your changelog. Maybe
it's worth another patch?
WBR, Sergei
Very observant. ;-) Yes. After fixing the other ones I got a warning on that one. I could resubmit the change with a more generic description or split it up as you suggest.

Quoted 7 lines

Quoted 3 lines
Ralf,
Please advice.
For simplicity's sake I'm going to split this myself BUT putting changes that are not explained in changelog comments is a good way to get your dear maintainer grumpy :)

Thanks, Ralf

Appreciated. Hope you can keep that smile ;-)

Regards,
Arend

Quoted 2 lines

Ralf

Arend Van Spriel

author

2013-01-17 11:07 UTC #6 lore raw

In reply to Arend van Spriel

Quoted 7 lines

From: Arend van Spriel [[email protected]]
Sent: Friday, January 04, 2013 7:10 PM
The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:

Hi Ralf

Are you still intending to take this patch or did it slip by?

Gr. AvS

Quoted 15 lines

scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
        dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
        dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
which subsequently results in compile errors.
Cc Hauke Mehrtens <[email protected]>
Signed-off-by Arend van Spriel <[email protected]>
---
Fixing a Kconfig issue in our nightly Jenkins build.
Gr. AvS
---

Hauke Mehrtens

maintainer

2013-01-17 12:57 UTC #7 lore raw

Quoted 8 lines · Arend Van Spriel

Quoted 7 lines
From: Arend van Spriel [[email protected]]
Sent: Friday, January 04, 2013 7:10 PM
The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:

Quoted 5 lines

Hi Ralf
Are you still intending to take this patch or did it slip by?
Gr. AvS

This was applied by Ralf in his tree for linux next integration [0] [1].

@Ralf could you please also send these patches to Linus for 3.8.

Hauke

[0]:
http://git.linux-mips.org/?p=ralf/upstream-sfr.git;a=commitdiff;h=a9e985783ed936376de9f27eff54e37d584fb855;hp=3d2d03247632920aa21b42a0b032a4ffd44ce15e
[1]:
http://git.linux-mips.org/?p=ralf/upstream-sfr.git;a=commitdiff;h=b26d9ac76b22f53f1553d63c676dc2e70a8e3157;hp=a9e985783ed936376de9f27eff54e37d584fb855