Skip to contentSkip to conversation

power: max17040: use devm_kzalloc

PATCH Applied Devendra Naga 2 participants 2 messages Jan 6, 2013

lore
Share & tools
lore

Devendra Naga

author
#0 lore raw

PATCH 1/1 power: max17040: use devm_kzalloc

use devm_kzalloc and no need of error path and unload frees

Signed-off-by Devendra Naga <[email protected]>
---
 drivers/power/max17040_battery.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/power/max17040_battery.c +1 -3
index 22cfe9c..74a0bd9 100644
@@ -207,7 +207,7 @@ static int max17040_probe(struct i2c_client *client,
 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
 		return -EIO;
 
-	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
 	if (!chip)
 		return -ENOMEM;
 

@@ -225,7 +225,6 @@ static int max17040_probe(struct i2c_client *client,
 	ret = power_supply_register(&client->dev, &chip->battery);
 	if (ret) {
 		dev_err(&client->dev, "failed: power supply register\n");
-		kfree(chip);
 		return ret;
 	}
 

@@ -244,7 +243,6 @@ static int max17040_remove(struct i2c_client *client)
 
 	power_supply_unregister(&chip->battery);
 	cancel_delayed_work(&chip->work);
-	kfree(chip);
 	return 0;
 }
Signature · 1 line
1.7.10.4