Remove NETIF_F_NETNS_LOCAL from software devices.

When NETIF_F_NETNS_LOCAL feature is set in some network device, we do not allow this device to be moved from one network namespace to another (see dev_change_net_namespace()). Vlan device is not considered a local device and does not have the NETIF_F_NETNS_LOCAL feature. There is no reason that software devices like ppp and bridge will set the NETIF_F_NETNS_LOCAL feature. This patchset removes NETIF_F_NETNS_LOCAL from ppp and bridge devices.

* Changes from v1
Do not remove NETIF_F_NETNS_LOCAL from vxlan devices. Moving vxlan device to a different namesapce does not move the state of the UDP socket related to this vxlan device (Following Stephen Hemminger comment).

Rami Rosen (2):
[RFC PATCH v2 net-next 1/3] ppp: remove NETIF_F_NETNS_LOCAL from ppp
device features.
[RFC PATCH v2 net-next 2/3] bridge: remove NETIF_F_NETNS_LOCAL from
bridge device features.

 drivers/net/ppp/ppp_generic.c | 1 -
 net/bridge/br_device.c        | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

1.7.11.7

There is no need for NETIF_F_NETNS_LOCAL for ppp device; this patch removes it.

---
 drivers/net/ppp/ppp_generic.c | 1 -
 1 file changed, 1 deletion(-)

index 0b2706a..89b6fc5 100644
@@ -1073,7 +1073,6 @@ static void ppp_setup(struct net_device *dev)
 	dev->tx_queue_len = 3;
 	dev->type = ARPHRD_PPP;
 	dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;
-	dev->features |= NETIF_F_NETNS_LOCAL;
 	dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
 }
 

1.7.11.7

At least pppoe_rcv_core assumes that the ppp socket and the network devices are all in the same network namespace. So it looks like NETIF_F_NETNS_LOCAL is needed.

Eric

There is no need for NETIF_F_NETNS_LOCAL for bridge device; this patch removes it.

---
 net/bridge/br_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index e1bc090..0f88d21 100644
@@ -344,7 +344,7 @@ void br_dev_setup(struct net_device *dev)
 
 	dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
 			NETIF_F_GSO_MASK | NETIF_F_HW_CSUM | NETIF_F_LLTX |
-			NETIF_F_NETNS_LOCAL | NETIF_F_HW_VLAN_TX;
+			NETIF_F_HW_VLAN_TX;
 	dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
 			   NETIF_F_GSO_MASK | NETIF_F_HW_CSUM |
 			   NETIF_F_HW_VLAN_TX;

1.7.11.7

At the very least add_del_if assumes are network devices are in the same network namespace as the bridge. So removing NETIF_F_NETNS_LOCAL is not safe.

Eric

After you saw the case for vxlan I am disappointed you respun this patchset without asking the question: Could other devices suffer from the same class of problem.

It didn't take me more than a few minutes of looking to see that the bridge and the ppp network device have the same class of issue as vxlan.