Skip to contentSkip to conversation

iio: mxs-lradc: indexes are unsigned

PATCH In review Fabio Estevam 3 participants 3 messages Jan 8, 2013 – Jan 9, 2013

Subsystems (4)
Arm i.MX and Layerscape Staging IIO Staging - industrial io
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 iio: mxs-lradc: indexes are unsigned

From: Fabio Estevam <[email protected]>

Fix the following warning when building with W=1 option:

drivers/staging/iio/adc/mxs-lradc.c: In function 'mxs_lradc_trigger_handler':
drivers/staging/iio/adc/mxs-lradc.c:244:2: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/staging/iio/adc/mxs-lradc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/mxs-lradc.c +1 -1
index fb31b45..6cf3af8 100644
@@ -239,7 +239,7 @@ static irqreturn_t mxs_lradc_trigger_handler(int irq, void *p)
 	struct mxs_lradc *lradc = iio_priv(iio);
 	const uint32_t chan_value = LRADC_CH_ACCUMULATE |
 		((LRADC_DELAY_TIMER_LOOP - 1) << LRADC_CH_NUM_SAMPLES_OFFSET);
-	int i, j = 0;
+	u32 i, j = 0;
 
 	for_each_set_bit(i, iio->active_scan_mask, iio->masklength) {
 		lradc->buffer[j] = readl(lradc->base + LRADC_CH(j));
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw

Dear Fabio Estevam,

Quoted 10 lines

From: Fabio Estevam <[email protected]>

Fix the following warning when building with W=1 option:

drivers/staging/iio/adc/mxs-lradc.c: In function 'mxs_lradc_trigger_handler': drivers/staging/iio/adc/mxs-lradc.c:244:2:
warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by Fabio Estevam <[email protected]>

Maybe use "unsigned int" instead? Either way:

Acked-by Marek Vasut <[email protected]>
Quoted 9 lines
---
 drivers/staging/iio/adc/mxs-lradc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/iio/adc/mxs-lradc.c index fb31b45..6cf3af8 100644

drivers/staging/iio/adc/mxs-lradc.c static irqreturn_t mxs_lradc_trigger_handler(int irq, · line 245

Quoted 8 lines
drivers/staging/iio/adc/mxs-lradc.c +1 -1
@@ -239,7 +239,7 @@ static irqreturn_t mxs_lradc_trigger_handler(int irq,
 void *p) struct mxs_lradc *lradc = iio_priv(iio);
 	const uint32_t chan_value = LRADC_CH_ACCUMULATE |
 		((LRADC_DELAY_TIMER_LOOP - 1) << LRADC_CH_NUM_SAMPLES_OFFSET);
-	int i, j = 0;
+	u32 i, j = 0;
 
 	for_each_set_bit(i, iio->active_scan_mask, iio->masklength) {
 		lradc->buffer[j] = readl(lradc->base + LRADC_CH(j));

Best regards,
Marek Vasut

maintainer
#2 lore raw
Quoted 6 lines · Marek Vasut

Dear Fabio Estevam,

Quoted 4 lines

From: Fabio Estevam <[email protected]>

Fix the following warning when building with W=1 option:

Quoted 9 lines
Quoted 6 lines

drivers/staging/iio/adc/mxs-lradc.c: In function 'mxs_lradc_trigger_handler': drivers/staging/iio/adc/mxs-lradc.c:244:2:
warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by Fabio Estevam <[email protected]>

Maybe use "unsigned int" instead? Either way:

Agreed, I've switched it over on the assumption no one will mind.

If one of you wants to check I didn't do anything silly that would be great.

Quoted 1 line
Acked-by Marek Vasut <[email protected]>

added to fixes-togreg branch of iio.git on git.kernel.org

Quoted 26 lines
Quoted 10 lines
---
 drivers/staging/iio/adc/mxs-lradc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/iio/adc/mxs-lradc.c index fb31b45..6cf3af8 100644

drivers/staging/iio/adc/mxs-lradc.c static irqreturn_t mxs_lradc_trigger_handler(int irq, · line 245

Quoted 8 lines
drivers/staging/iio/adc/mxs-lradc.c +1 -1
@@ -239,7 +239,7 @@ static irqreturn_t mxs_lradc_trigger_handler(int irq,
 void *p) struct mxs_lradc *lradc = iio_priv(iio);
 	const uint32_t chan_value = LRADC_CH_ACCUMULATE |
 		((LRADC_DELAY_TIMER_LOOP - 1) << LRADC_CH_NUM_SAMPLES_OFFSET);
-	int i, j = 0;
+	u32 i, j = 0;
 
 	for_each_set_bit(i, iio->active_scan_mask, iio->masklength) {
 		lradc->buffer[j] = readl(lradc->base + LRADC_CH(j));

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html