Skip to contentSkip to conversation

clk: mxs: Index is always positive

PATCH In review Fabio Estevam 3 participants 3 messages Jan 8, 2013 – Jan 15, 2013

Subsystems (2)
Arm i.MX and Layerscape Common clk
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 clk: mxs: Index is always positive

From: Fabio Estevam <[email protected]>

Fix the following warnings when building with W=1 option:

drivers/clk/mxs/clk-imx23.c: In function 'mx23_clocks_init':
drivers/clk/mxs/clk-imx23.c:149:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] drivers/clk/mxs/clk-imx23.c:165:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
...

drivers/clk/mxs/clk-imx28.c: In function 'mx28_clocks_init':
drivers/clk/mxs/clk-imx28.c:227:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] drivers/clk/mxs/clk-imx28.c:244:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by Fabio Estevam <[email protected]>

----

 drivers/clk/mxs/clk-imx23.c |    2 +-
 drivers/clk/mxs/clk-imx28.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/clk/mxs/clk-imx23.c +1 -1
index 8dd476e..b5c06f9 100644
@@ -99,7 +99,7 @@ static enum imx23_clk clks_init_on[] __initdata = {
 int __init mx23_clocks_init(void)
 {
 	struct device_node *np;
-	int i;
+	u32 i;
 
 	clk_misc_init();
drivers/clk/mxs/clk-imx28.c +1 -1
index db3af08..126370a 100644
@@ -154,7 +154,7 @@ static enum imx28_clk clks_init_on[] __initdata = {
 int __init mx28_clocks_init(void)
 {
 	struct device_node *np;
-	int i;
+	u32 i;
 
 	clk_misc_init();
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following warnings when building with W=1 option:

drivers/clk/mxs/clk-imx23.c: In function 'mx23_clocks_init':
drivers/clk/mxs/clk-imx23.c:149:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] drivers/clk/mxs/clk-imx23.c:165:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
...

Quoted 5 lines

drivers/clk/mxs/clk-imx28.c: In function 'mx28_clocks_init':
drivers/clk/mxs/clk-imx28.c:227:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] drivers/clk/mxs/clk-imx28.c:244:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Shawn Guo <[email protected]>
#2 lore raw

Quoting Shawn Guo (2013-01-08 21:50:19)

Quoted 10 lines · Fabio Estevam
Quoted 9 lines

From: Fabio Estevam <[email protected]>

Fix the following warnings when building with W=1 option:

drivers/clk/mxs/clk-imx23.c: In function 'mx23_clocks_init':
drivers/clk/mxs/clk-imx23.c:149:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] drivers/clk/mxs/clk-imx23.c:165:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
...

Quoted 7 lines
Quoted 5 lines

drivers/clk/mxs/clk-imx28.c: In function 'mx28_clocks_init':
drivers/clk/mxs/clk-imx28.c:227:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] drivers/clk/mxs/clk-imx28.c:244:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Shawn Guo <[email protected]>

Pulled into clk-next.

Thanks,
Mike