Skip to contentSkip to conversation

net: fec: Remove 'inline' declarations

PATCH Applied Fabio Estevam 2 participants 2 messages Jan 8, 2013 – Jan 9, 2013

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v3 1/1 net: fec: Remove 'inline' declarations

From: Fabio Estevam <[email protected]>

Fix the following warning when building with W=1 option:

drivers/net/ethernet/freescale/fec.c:810:1: warning: '__inline__' is not at beginning of declaration [-Wold-style-declaration]

The inline declaration is pointless in this function, so just remove it.

While at it, also remove the other 'inline' declarations.

Signed-off-by Fabio Estevam <[email protected]>

---
Changses since v2:
- Update Subject
- Remove other inline
Changes since v1:
- Remove the 'inline'

 drivers/net/ethernet/freescale/fec.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/freescale/fec.c +3 -3
index a379319..16a1640d 100644
@@ -807,7 +807,7 @@ fec_enet_interrupt(int irq, void *dev_id)
 
 
 /* ------------------------------------------------------------------------- */
-static void __inline__ fec_get_mac(struct net_device *ndev)
+static void fec_get_mac(struct net_device *ndev)
 {
 	struct fec_enet_private *fep = netdev_priv(ndev);
 	struct fec_platform_data *pdata = fep->pdev->dev.platform_data;

@@ -1562,12 +1562,12 @@ static void fec_reset_phy(struct platform_device *pdev)
 	gpio_set_value(phy_reset, 1);
 }
 #else /* CONFIG_OF */
-static inline int fec_get_phy_mode_dt(struct platform_device *pdev)
+static int fec_get_phy_mode_dt(struct platform_device *pdev)
 {
 	return -ENODEV;
 }
 
-static inline void fec_reset_phy(struct platform_device *pdev)
+static void fec_reset_phy(struct platform_device *pdev)
 {
 	/*
 	 * In case of platform probe, the reset has been done
Signature · 1 line
1.7.9.5
maintainer Applied
#1 lore raw

From: Fabio Estevam <[email protected]>
Date: Tue, 8 Jan 2013 01:42:56 -0200

Quoted 11 lines

From: Fabio Estevam <[email protected]>

Fix the following warning when building with W=1 option:

drivers/net/ethernet/freescale/fec.c:810:1: warning: '__inline__' is not at beginning of declaration [-Wold-style-declaration]

The inline declaration is pointless in this function, so just remove it.

While at it, also remove the other 'inline' declarations.

Signed-off-by Fabio Estevam <[email protected]>

Applied to net-next.