Skip to contentSkip to conversation

added infozip package

PATCH New Jan Pedersen 2 participants 2 messages Jan 8, 2013

lore
Share & tools
lore

Jan Pedersen

author
#0 lore raw

PATCH 1/1 added infozip package

Signed-off-by Jan Pedersen <[email protected]>
---
 package/Config.in          |    1 +
 package/infozip/Config.in  |   10 ++++++++++
 package/infozip/infozip.mk |   43 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 54 insertions(+)
 create mode 100644 package/infozip/Config.in
 create mode 100644 package/infozip/infozip.mk
package/Config.in +1 -0
index 49db380..9cf29f4 100644
@@ -14,6 +14,7 @@ endif
 source "package/lzop/Config.in"
 source "package/lzma/Config.in"
 source "package/xz/Config.in"
+source "package/infozip/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"
package/infozip/Config.in new file +10 -0
new file mode 100644
index 0000000..1a4b756
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_INFOZIP
+	bool "infozip"
+	help
+	  Zip is a compression and file packaging/archive utility. 
+	  Although highly compatible both with PKWARE's PKZIP and 
+	  PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip, 
+ 	  our primary objectives have been portability and other-than-MSDOS 
+	  functionality. 
+
+	  http://infozip.sourceforge.net/Zip.html
package/infozip/infozip.mk new file +43 -0

43 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 added infozip package

Dear Jan Pedersen,

Thanks for contributing this package!

Quoted 6 lines · Jan Pedersen
package/infozip/infozip.mk new file +0 -0
new file mode 100644
index 0000000..996a709

package/infozip/infozip.mk line 8

Quoted 8 lines
package/infozip/infozip.mk new file +8 -0
@@ -0,0 +1,43 @@
+#############################################################
+#
+# infozip
+#
+#############################################################
+INFOZIP_VERSION:=30
+INFOZIP_SOURCE:=zip$(INFOZIP_VERSION).tgz
+INFOZIP_SITE:=ftp://ftp.info-zip.org/pub/infozip/src/

Please use = instead of :=. So, something like:

INFOZIP_VERSION = 30
INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src/

Also, please add the INFOZIP_LICENSE and INFOZIP_LICENSE_FILES fields (see the Buildroot manual for details).

package/infozip/infozip.mk line 16

Quoted 8 lines
package/infozip/infozip.mk new file +8 -0
+INFOZIP_DIR = $(BUILD_DIR)/zip$(INFOZIP_VERSION)
+
+$(DL_DIR)/$(INFOZIP_SOURCE):
+	$(call DOWNLOAD,$(INFOZIP_SITE)/$(INFOZIP_SOURCE))
+
+$(INFOZIP_DIR)/.source: $(DL_DIR)/$(INFOZIP_SOURCE)
+	$(ZCAT) $(DL_DIR)/$(INFOZIP_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+	touch $@

[...]

Snip. Arggh, this is a manual .mk file. This is something we have deprecated since a long time. Please use the generic-package infrastructure instead.

See
http://buildroot.org/downloads/manual/manual.html#_infrastructure_for_packages_with_specific_build_systems
for details on how to use this infrastructure, and the many examples available in Buildroot.

Could you rework this package to use the generic-package infrastructure?

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com